From: "Nuno Sá" <noname.nuno@gmail.com>
To: "David Lechner" <dlechner@baylibre.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Marcelo Schmitt" <marcelo.schmitt1@gmail.com>
Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ad7280a: fix ad7280_store_balance_timer()
Date: Fri, 10 Oct 2025 20:02:44 +0100 [thread overview]
Message-ID: <efeeda046354cabd7da93d5afa64417260fa7c82.camel@gmail.com> (raw)
In-Reply-To: <20251010-iio-adc-ad7280a-fix-ad7280_store_balance_timer-v1-1-e11746735192@baylibre.com>
On Fri, 2025-10-10 at 10:44 -0500, David Lechner wrote:
> Use correct argument to iio_str_to_fixpoint() to parse 3 decimal places.
>
> iio_str_to_fixpoint() has a bit of an unintuitive API where the
> fract_mult parameter is the multiplier of the first decimal place as if
> it was already an integer. So to get 3 decimal places, fract_mult must
> be 100 rather than 1000.
>
> Fixes: 96ccdbc07a74 ("staging:iio:adc:ad7280a: Standardize extended ABI naming")
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
Reviewed-by: Nuno Sá <nuno.sa@analog.com>
> drivers/iio/adc/ad7280a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7280a.c b/drivers/iio/adc/ad7280a.c
> index
> dda2986ccda075fbfa04851a1ceac7a186b47537..50a6ff7c8b1c73905fabdef119d41204c32b590c
> 100644
> --- a/drivers/iio/adc/ad7280a.c
> +++ b/drivers/iio/adc/ad7280a.c
> @@ -541,7 +541,7 @@ static ssize_t ad7280_store_balance_timer(struct iio_dev
> *indio_dev,
> int val, val2;
> int ret;
>
> - ret = iio_str_to_fixpoint(buf, 1000, &val, &val2);
> + ret = iio_str_to_fixpoint(buf, 100, &val, &val2);
> if (ret)
> return ret;
>
>
> ---
> base-commit: a9682f53c2d1678b93a123cdaa260e955430bc5c
> change-id: 20251010-iio-adc-ad7280a-fix-ad7280_store_balance_timer-126bc5b4ee90
>
> Best regards,
next prev parent reply other threads:[~2025-10-10 20:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-10 15:44 David Lechner
2025-10-10 19:02 ` Nuno Sá [this message]
2025-10-12 18:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=efeeda046354cabd7da93d5afa64417260fa7c82.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®