From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7D8B5CE7A88 for ; Sat, 23 Sep 2023 12:22:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231964AbjIWMWn (ORCPT ); Sat, 23 Sep 2023 08:22:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43104 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231916AbjIWMW0 (ORCPT ); Sat, 23 Sep 2023 08:22:26 -0400 Received: from omta040.useast.a.cloudfilter.net (omta040.useast.a.cloudfilter.net [44.202.169.39]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A9EE10FA; Sat, 23 Sep 2023 05:21:41 -0700 (PDT) Received: from eig-obgw-5010a.ext.cloudfilter.net ([10.0.29.199]) by cmsmtp with ESMTP id jq44q9ExAyYOwk1dkq0hjq; Sat, 23 Sep 2023 12:21:40 +0000 Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with ESMTPS id k1djq8ZS6IDdmk1djqBXPq; Sat, 23 Sep 2023 12:21:40 +0000 X-Authority-Analysis: v=2.4 cv=HcYH8wI8 c=1 sm=1 tr=0 ts=650ed854 a=1YbLdUo/zbTtOZ3uB5T3HA==:117 a=P7XfKmiOJ4/qXqHZrN7ymg==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=IkcTkHD0fZMA:10 a=zNV7Rl7Rt7sA:10 a=wYkD_t78qR0A:10 a=NEAV23lmAAAA:8 a=XYAwZIGsAAAA:8 a=ag1SF4gXAAAA:8 a=VwQbUJbxAAAA:8 a=cm27Pg_UAAAA:8 a=HvF037n1xESchLcPDVoA:9 a=QEXdDO2ut3YA:10 a=E8ToXWR_bxluHZ7gmE-Z:22 a=Yupwre4RP9_Eg_Bd0iYG:22 a=AjGcO6oz07-iQ99wixmX:22 a=xmb-EsYY8bH0VWELuYED:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=embeddedor.com; s=default; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=en96eDpqHEC5cTsa0g6yfTOKsB03MEcqDobnTEbdTV0=; b=nzanB6MPlno+BPJvBU+4JqCPU7 QPTsZvshifp0NhPTadV6aM+7kFd3BttlswHRrdKYqtODGTh631k9IWfNEfwJ6pLI6V2t4VY9eaKpg 0yG67ZjoG9CxeRkjPkQPlXeiujqOBgKQzdbln0zwvvJn79ePiGqOVRIce/vsy5bKe8snbM/ZKfXjW VuTq9hD8n+vyWyYaUGqdSSUn8ab63rWutJdpVh2aFKZTXdstA5SdrUFeCbxzuhO46PunP5/jaMPy8 RR3waj25PJApzPYm9JpvzknB+wxSaF9QUzVlJAKe286u4EZC6us6RTKVLDBax9265Ar+jbe1CICIc s+SYNN8Q==; Received: from [94.239.20.48] (port=34528 helo=[192.168.1.98]) by gator4166.hostgator.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.96) (envelope-from ) id 1qjy6U-003epr-0i; Sat, 23 Sep 2023 03:35:06 -0500 Message-ID: Date: Sat, 23 Sep 2023 10:36:10 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] serial: 8250_pci1xxxx: Annotate struct pci1xxxx_8250 with __counted_by Content-Language: en-US To: Kees Cook , Kumaravel Thiagarajan Cc: Tharun Kumar P , Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, Nathan Chancellor , Nick Desaulniers , Tom Rix , linux-kernel@vger.kernel.org, llvm@lists.linux.dev, linux-hardening@vger.kernel.org References: <20230922175242.work.442-kees@kernel.org> From: "Gustavo A. R. Silva" In-Reply-To: <20230922175242.work.442-kees@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 94.239.20.48 X-Source-L: No X-Exim-ID: 1qjy6U-003epr-0i X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.98]) [94.239.20.48]:34528 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 0 X-Org: HG=hgshared;ORG=hostgator; X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfM9C0+bJkRfeC1hVRHNnL09J6LgPyUTJdEfaQvtjL3NX8bZ4OYd2NZaM6s1d8njcBn654yTQT7sE1wq3RKbVjhkwdaw3nB4GZYsh+L/a4EF5FxF0spIY LerZSzzL/8GB1R9iSHCEbXygcJDHVdiCo9urB8RlitCihH5j6copCmUR02Toh0Jd249xKSHBGFf2iUH4icnu2TyTmPp3GJvoZVfLAZQb+TB0WX5FUzPkRo1S Lu6PYckXk4HOroSdKc/Rk41WRzzDCdRVSMPo7bMQZErKZDWdr66y5c8wE8B/dcgwunr1FqqCcWgFJmy6JD/DxQ== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 9/22/23 11:52, Kees Cook wrote: > Prepare for the coming implementation by GCC and Clang of the __counted_by > attribute. Flexible array members annotated with __counted_by can have > their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS > (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family > functions). > > As found with Coccinelle[1], add __counted_by for struct pci1xxxx_8250. > > [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci > > Cc: Kumaravel Thiagarajan > Cc: Tharun Kumar P > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > Cc: linux-serial@vger.kernel.org > Signed-off-by: Kees Cook Reviewed-by: Gustavo A. R. Silva Thanks -- Gustavo > --- > drivers/tty/serial/8250/8250_pci1xxxx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_pci1xxxx.c b/drivers/tty/serial/8250/8250_pci1xxxx.c > index a3b25779d921..0da9847f3e91 100644 > --- a/drivers/tty/serial/8250/8250_pci1xxxx.c > +++ b/drivers/tty/serial/8250/8250_pci1xxxx.c > @@ -107,7 +107,7 @@ static const int logical_to_physical_port_idx[][MAX_PORTS] = { > struct pci1xxxx_8250 { > unsigned int nr; > void __iomem *membase; > - int line[]; > + int line[] __counted_by(nr); > }; > > static int pci1xxxx_get_num_ports(struct pci_dev *dev)