From: Paolo Bonzini <pbonzini@redhat.com>
To: Sean Christopherson <seanjc@google.com>
Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH v3 5/6] KVM: x86: make several AVIC callbacks optional
Date: Fri, 18 Feb 2022 18:17:50 +0100 [thread overview]
Message-ID: <eff2543a-10ab-611a-28e2-18999d21ddd8@redhat.com> (raw)
In-Reply-To: <Yg/IGUFqqS2r98II@google.com>
On 2/18/22 17:23, Sean Christopherson wrote:
> The "AVIC" callbacks are being deleted, not
> made optional, it's kvm_x86_ops' APICv hooks that are becoming optional.
Maybe "make several APIC virtualization callbacks optional".
>> +KVM_X86_OP_OPTIONAL(apicv_post_state_restore)
>
> apicv_post_state_restore() isn't conditional, it's implemented and wired up
> unconditionally by both VMX and SVM.
True, on the other hand there's no reason why a hypothetical third
vendor would have to support it. The call is conditional to
apicv_active being true.
Paolo
next prev parent reply other threads:[~2022-02-18 17:18 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 18:08 [PATCH v3 0/6] kvm: x86: better handling of optional kvm_x86_ops Paolo Bonzini
2022-02-17 18:08 ` [PATCH v3 1/6] KVM: x86: return 1 unconditionally for availability of KVM_CAP_VAPIC Paolo Bonzini
2022-02-18 15:44 ` Sean Christopherson
2022-02-23 13:21 ` Maxim Levitsky
2022-02-17 18:08 ` [PATCH v3 2/6] KVM: x86: use static_call_cond for optional callbacks Paolo Bonzini
2022-02-18 15:46 ` Sean Christopherson
2022-02-17 18:08 ` [PATCH v3 3/6] KVM: x86: remove KVM_X86_OP_NULL and mark optional kvm_x86_ops Paolo Bonzini
2022-02-18 15:52 ` Sean Christopherson
2022-02-17 18:08 ` [PATCH v3 4/6] KVM: x86: warn on incorrectly NULL members of kvm_x86_ops Paolo Bonzini
2022-02-18 16:18 ` Sean Christopherson
2022-02-17 18:08 ` [PATCH v3 5/6] KVM: x86: make several AVIC callbacks optional Paolo Bonzini
2022-02-18 16:23 ` Sean Christopherson
2022-02-18 17:17 ` Paolo Bonzini [this message]
2022-02-18 17:37 ` Sean Christopherson
2022-02-18 17:41 ` Paolo Bonzini
2022-02-17 18:08 ` [PATCH v3 6/6] KVM: x86: allow defining return-0 static calls Paolo Bonzini
2022-02-18 16:29 ` Sean Christopherson
2022-02-18 17:20 ` Paolo Bonzini
2022-02-18 17:33 ` Sean Christopherson
2022-03-17 17:43 ` Maxim Levitsky
2022-03-17 22:30 ` David Laight
2022-03-18 16:29 ` Paolo Bonzini
2022-03-18 17:28 ` Peter Zijlstra
2022-03-18 17:47 ` Peter Zijlstra
2022-03-18 18:02 ` Peter Zijlstra
2022-03-18 23:03 ` David Laight
2022-03-20 13:58 ` Maxim Levitsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff2543a-10ab-611a-28e2-18999d21ddd8@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®