From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2B856373BE4 for ; Wed, 18 Mar 2026 10:33:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773829998; cv=none; b=S1PAhTpWpuILlecED9ZE2T7RQp7LAwHWr+GBgkhbkaNk4NI9Me6ElKiTmlxs3nxFdMxB01kqeQghO6kBdyjEeoe47kSdW5MaFbRP2AGCn3BOIEie4c1eUHmgU5zmQF3vnExv7Ho7Xn0UuZs3DFNFE426OthHr9Rb1m4ASCizxQw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773829998; c=relaxed/simple; bh=fHT07WGvsF5oyKJPCxxx+aAXOYyKPsTUTXwpeKqag3w=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ASblOycpnplKBML8j+q62RvlOiIaNtFqBtEY4XuRK1qUbrvzaG2P58x+/lis1KuHlXiRWpufJQIhgJkb7bm1BZ6RwkBKKUc56U63xFfNrvonNZQSEjlaVNTNzdTKzwP7nO8pgD/lHE8N4gMEVWP4xLkTq1lpnKuIHqHiYkhSwrQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=RL9l5bPA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VAeq5G5a; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="RL9l5bPA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VAeq5G5a" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62I91IUi2730235 for ; Wed, 18 Mar 2026 10:33:14 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6K+3Nv2mtVzd2XCCEAvRvSqh92obrJDkBtTqu9w2Q7Q=; b=RL9l5bPAcn2R0LtZ IKpeE74hQoYbrp9z+/HcGBTKg7GICKcpjQBlHntYm96WdkeFOWY5r6IX/g7glbGh 4O83s+dYGBu2RczoFdwT/0U8Qd0MF5Nj2A8so03iu4MNxc8bTUiNd+PRgfgsYALf /HLQw8ZZyriU5Oq9xn7U8XE2xV0usgRQUD1L/XrXmIBprRJwzXhpRRsL9pRiDio8 1uP4FXEUukxpGl8hZl+47Y0nMOnhjS6aaaLrDGMa8qWOJMmPjI8y4CeHlTq63xGz D1lVF2xQ1JyRd9ufONyLGuK74Eeqn3qkfpsCRKRHd3bHev39gYnAj1X2L/J88Pai rHVZQg== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cy8kjvd6q-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 18 Mar 2026 10:33:13 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2aad5fec175so325292275ad.2 for ; Wed, 18 Mar 2026 03:33:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773829993; x=1774434793; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6K+3Nv2mtVzd2XCCEAvRvSqh92obrJDkBtTqu9w2Q7Q=; b=VAeq5G5auBlht4Yo+vI1jvzBskIhaJxmsG2M+4BDX4oeIFshjAgAaAjz/8xcTpRrEh YzaGhT+BAdT4j2Y+KvvuUlZo5rHb9Gx/hRNFnV8hWwPOt4B1j5Yqj0D11rdffinuK+mC NdnWLNfUf9rl+sk+6pDU6jfrUyfk1jN1JgmB06mNL1JRmTOX3W6B8KkQ9JJDbPjxaolS 7MH4RtnOaWOjRaKjN6jHRfsSOe05hxt38efFLdHVGk+N0sU7u5sLI2OvJDNUEPbPrRgw kNs3nZxbDluRd5ohXWRZRgIR5SAztZeS1tvpGnA4EF3gJIQrCrtEtwpss1eHqLTj3BHX izLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773829993; x=1774434793; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6K+3Nv2mtVzd2XCCEAvRvSqh92obrJDkBtTqu9w2Q7Q=; b=AQ64d9PyavmUyXvy+WLywPnLmS4OMBIgVRkZ/p6T05xWglGs0kDzfOrryRmOiVeig0 viqpMOyYb3uMsAogBWy0X+KvTVnq7og0+TJGNqXr8T1TyX2XNgHnQGa9HGm+7mtzCob6 O4aus4+jsVh/2as9fOHjrEnRJU87mTKwRJ5uuXz9rklBdURX/AIRYKYGgbrUj/AM9+Y2 CjqXtXafWV3vYrVUfP8TzlGO2ShQqPArHuI/lXgaa65qiAVynYHxe8DJ3QleG4jH2Y+i qSh2DdyYB+Aa/DfWp3H2olxHzdhfmSEP3wGSa1OG7GAohLNbY5MjNk7FAIJEUgKSDZAN BSMg== X-Forwarded-Encrypted: i=1; AJvYcCV7Bk6hblVUfJX9HzDAFkBw5d5j3Vkan38iS+OZPBA7e3erwDT9WZM9R+Aq6XEIwAKVYnKoTQF+WqTiJAo=@vger.kernel.org X-Gm-Message-State: AOJu0YyDUoW28reiqvgNnzCc6v4+8tL7NxFgQmeGHL0QDjlX8mYWliYx gsoRDDxQTXjk4h8QznN0+7yNDet9PacqIgEB5LFym3vyZO9nSABBG/wwXZJgYk7XoHiue0oZdzX RR3FuJOlqgSnFI3+XByrpIUAFMpgYY2mLg603uo1gneqqhEiSppz6GcA4ohIF3IzrEg4= X-Gm-Gg: ATEYQzzzqh3E2P9xq9SRWmzQWrek13bNNCUH9E5NHUQBQVsIpDalg42blV55/G9YEY2 7MPbWRoXrXR7AXT58AwFg3xoM/3EViUSTC1HEn+L8SfymlhjOp+8YD6Q68ZT7BsiOX5wxB/WL77 6t/ymKjkRqTaVyg7nV6aa6b24inWZqQRsV7q6h85FxX5ctkiQAM5CtWJW3CqfPLm9yxrv2yDc5Z tg9mC5+VEV7b8W35XeA6ZXlOowIoa2tMB27ObbsPNpBG2XV0umwj4FEvCGa9Neu68D5JfB4NZPP zj/+j7KPqyV5+TzgLWxeKZYq7G/ohJ1TOVxSkeVLFiVitc3A5ZXfr6LuKbV7mcCe7w1lJKZXE9y Q2WPAL8zwLAY6bE9jS7/gMhDk+VPa2HgwWV+0ysIQcnzZVsR/O2h11Q== X-Received: by 2002:a17:903:1986:b0:2b0:6140:aa65 with SMTP id d9443c01a7336-2b06e3ca13amr28724955ad.30.1773829992782; Wed, 18 Mar 2026 03:33:12 -0700 (PDT) X-Received: by 2002:a17:903:1986:b0:2b0:6140:aa65 with SMTP id d9443c01a7336-2b06e3ca13amr28724725ad.30.1773829992350; Wed, 18 Mar 2026 03:33:12 -0700 (PDT) Received: from [10.0.0.3] ([106.222.229.118]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b06e605108sm30601495ad.60.2026.03.18.03.33.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Mar 2026 03:33:11 -0700 (PDT) Message-ID: Date: Wed, 18 Mar 2026 16:03:07 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v7 7/8] media: qcom: iris: split firmware_data from raw platform data Content-Language: en-US To: Dmitry Baryshkov , Dikshita Agarwal Cc: Vikash Garodia , Abhinav Kumar , Bryan O'Donoghue , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260316-iris-platform-data-v7-0-fc79f003f51c@oss.qualcomm.com> <20260316-iris-platform-data-v7-7-fc79f003f51c@oss.qualcomm.com> <3ee87252-6b90-a389-0621-5b0b8d2f87ff@oss.qualcomm.com> From: Dikshita Agarwal In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE4MDA4OSBTYWx0ZWRfX9pAJaeJTq9Gq jmZs9uQnpuUQlRSCA8+q4RRerFnq5rDmKvKuEIQMYF7UbfoqMbefk3gkGoPm050YczjH7VEtLfK NFjD5mu6k0j18cgl0O12ptdsA08GnC0aLujsolc9wYOFgDgZ4lXuvXNvgxrL6IcfHTidI6SL8w3 wLCjjEeU6vQcEABBfw8zL1A/5NzINo5bCxoKov/y+S3OFrQ3Wp6MMlgX8Ryr9H3j9WLuS1bDIIc qu6UEw8uVkaaLI3APFwV1Sf6HOEpqRVu1NijspPa6QrtnCaV64rMLniR5lQbZl5BmgPjb5k93tY B8l96+9KeAIyGyB9QqP2orAawy8eRCRI+ngSVgq+g4REWabxkaxwXVJy84ZiRZIs1dAfPbXcrfu BepsR3qfF26pEbY7gEVTN9J4uZ2b6ngVHqB5rt20GIya0YKVeuCDoGmjulMPwLixvPXVVgxQvoJ cpBro/8NbMafnr+87IQ== X-Authority-Analysis: v=2.4 cv=P8I3RyAu c=1 sm=1 tr=0 ts=69ba7f69 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=RgczR8+8wRjDfzPIf2UjDw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=DwhbU6C3bo7Dc5u7oEUA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: k_g5J9MXsGU6-kaIZiBf7Fg7r40C5uCH X-Proofpoint-GUID: k_g5J9MXsGU6-kaIZiBf7Fg7r40C5uCH X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-18_01,2026-03-17_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 clxscore=1015 priorityscore=1501 suspectscore=0 lowpriorityscore=0 adultscore=0 spamscore=0 malwarescore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603180089 On 3/18/2026 3:59 PM, Dmitry Baryshkov wrote: > On Wed, Mar 18, 2026 at 02:35:30PM +0530, Dikshita Agarwal wrote: >> >> >> On 3/17/2026 12:24 AM, Dmitry Baryshkov wrote: >>> Having firmware-related fields in platform data results in the tying >>> platform data to the HFI firmware data rather than the actual hardware. >>> For example, SM8450 uses Gen2 firmware, so currently its platform data >>> should be placed next to the other gen2 platforms, although it has the >>> VPU2.0 core, similar to the one found on SM8250 and SC7280 and so the >>> hardware-specific platform data is also close to those devices. >>> >>> Split firmware data to a separate struct, separating hardware-related >>> data from the firmware interfaces. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> drivers/media/platform/qcom/iris/iris_buffer.c | 82 +++---- >>> drivers/media/platform/qcom/iris/iris_core.h | 2 + >>> drivers/media/platform/qcom/iris/iris_ctrls.c | 8 +- >>> .../platform/qcom/iris/iris_hfi_gen1_command.c | 8 +- >>> .../platform/qcom/iris/iris_hfi_gen2_command.c | 66 +++--- >>> .../platform/qcom/iris/iris_platform_common.h | 82 ++++--- >>> .../media/platform/qcom/iris/iris_platform_gen1.c | 67 +++--- >>> .../media/platform/qcom/iris/iris_platform_gen2.c | 246 ++++----------------- >>> drivers/media/platform/qcom/iris/iris_probe.c | 3 +- >>> drivers/media/platform/qcom/iris/iris_vidc.c | 10 +- >>> 10 files changed, 205 insertions(+), 369 deletions(-) >>> >> >> >> >>> -struct iris_platform_data { >>> +struct iris_firmware_data { >>> void (*init_hfi_ops)(struct iris_core *core); >>> - u32 (*get_vpu_buffer_size)(struct iris_inst *inst, enum iris_buffer_type buffer_type); >>> - const struct vpu_ops *vpu_ops; >>> - const struct icc_info *icc_tbl; >>> - unsigned int icc_tbl_size; >>> - const struct bw_info *bw_tbl_dec; >>> - unsigned int bw_tbl_dec_size; >>> - const char * const *pmdomain_tbl; >>> - unsigned int pmdomain_tbl_size; >>> - const char * const *opp_pd_tbl; >>> - unsigned int opp_pd_tbl_size; >>> - const struct platform_clk_data *clk_tbl; >>> - const char * const *opp_clk_tbl; >>> - unsigned int clk_tbl_size; >>> - const char * const *clk_rst_tbl; >>> - unsigned int clk_rst_tbl_size; >>> - const char * const *controller_rst_tbl; >>> - unsigned int controller_rst_tbl_size; >>> - u64 dma_mask; >>> - const char *fwname; >>> - struct iris_fmt *inst_iris_fmts; >>> - u32 inst_iris_fmts_size; >>> - struct platform_inst_caps *inst_caps; >>> + >>> const struct platform_inst_fw_cap *inst_fw_caps_dec; >>> u32 inst_fw_caps_dec_size; >>> const struct platform_inst_fw_cap *inst_fw_caps_enc; >>> u32 inst_fw_caps_enc_size; >>> - const struct tz_cp_config *tz_cp_config_data; >>> - u32 tz_cp_config_data_size; >>> - u32 core_arch; >> >> This can also be tied to firmware data as this is required to be set for >> Gen2 only and is 0 for Gen1. > > Will it differ between platforms? Nope, same for all platforms with HFI Gen2. Thanks, Dikshita >