From: Hans de Goede <hdegoede@redhat.com>
To: rafirafi <rafirafi.at@gmail.com>
Cc: Sebastian Reichel <sre@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: axp288_fuel_gauge: Add the Meegopad T02 to the blacklist.
Date: Mon, 6 Apr 2020 17:44:04 +0200 [thread overview]
Message-ID: <eff57daf-6f71-1f6f-e4f9-5b5b1ed974cd@redhat.com> (raw)
In-Reply-To: <20200406140538.11894-1-rafirafi.at@gmail.com>
Hi,
On 4/6/20 4:05 PM, rafirafi wrote:
> From: Rafael Gandolfi <rafirafi.at@gmail.com>
>
> The Meegopad T02 is a PC in stick format and doesn't have a battery,
> it is reported with a random and constant battery charge but as
> discharging to userspace.
>
> Add it to the blacklist to avoid the bogus battery status reporting.
>
> Signed-off-by: Rafael Gandolfi <rafirafi.at@gmail.com>
Patch looks good to me:
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
> ---
> drivers/power/supply/axp288_fuel_gauge.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/power/supply/axp288_fuel_gauge.c b/drivers/power/supply/axp288_fuel_gauge.c
> index e1bc4e6e6f30..0bc548865a61 100644
> --- a/drivers/power/supply/axp288_fuel_gauge.c
> +++ b/drivers/power/supply/axp288_fuel_gauge.c
> @@ -717,6 +717,12 @@ static const struct dmi_system_id axp288_fuel_gauge_blacklist[] = {
> DMI_MATCH(DMI_PRODUCT_NAME, "STK1A32SC"),
> },
> },
> + {
> + /* Meegopad T02 */
> + .matches = {
> + DMI_MATCH(DMI_PRODUCT_NAME, "MEEGOPAD T02"),
> + },
> + },
> {
> /* Meegopad T08 */
> .matches = {
>
next prev parent reply other threads:[~2020-04-06 15:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-06 14:05 rafirafi
2020-04-06 15:44 ` Hans de Goede [this message]
2020-04-13 23:00 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eff57daf-6f71-1f6f-e4f9-5b5b1ed974cd@redhat.com \
--to=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafirafi.at@gmail.com \
--cc=sre@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®