From: Logan Gunthorpe <logang@deltatee.com>
To: Dave Jiang <dave.jiang@intel.com>,
linux-kernel@vger.kernel.org, linux-ntb@googlegroups.com,
Jon Mason <jdmason@kudzu.us>
Cc: Allen Hubbe <allenbh@gmail.com>, Serge Semin <fancer.lancer@gmail.com>
Subject: Re: [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset
Date: Wed, 9 Jan 2019 12:33:37 -0700 [thread overview]
Message-ID: <f0096e1a-4256-98e1-57d8-d18f5b01fbae@deltatee.com> (raw)
In-Reply-To: <57aae0aa-fb12-b686-9835-b5dc60d97878@intel.com>
On 2019-01-09 12:32 p.m., Dave Jiang wrote:
>> I'm resending this because I've recently found out that the change we
>> made to use the NTB struct device in DMA allocations is wrong and
>> needs to be reverted. Turns out that, when running with an IOMMU,
>> dma_alloc_coherent() will always fail if you pass it the NTB struct
>> device. This is because the device has not been assigned an IOMMU
>> group and the Intel IOMMU at least expect the devices to be on the PCI
>> bus and be able to find a proper bus-dev-fn number through a struct
>> pci device. Therefore, we must revert the change and I've changed
>> patch 2 to do this and remove the no longer necessary DMA mask
>> adjustments.
>
> For the revert, I think we should cc stable as well.
I agree it should go into stable too. But I thought the fixes tag would
make that happen...
Logan
next prev parent reply other threads:[~2019-01-09 19:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 19:22 Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 1/8] NTB: ntb_tool: reading the link file should not end in a NULL byte Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 2/8] NTB: Revert the change to use the NTB device dev for DMA allocations Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 3/8] NTB: Fix the default port and peer numbers for legacy drivers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 4/8] NTB: ntb_pingpong: Choose doorbells based on port number Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 5/8] NTB: perf: Don't require one more memory window than number of peers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 6/8] NTB: perf: Fix support for hardware that doesn't have port numbers Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 7/8] NTB: perf: Fix race condition when run with ntb_test Logan Gunthorpe
2019-01-09 19:22 ` [PATCH v3 8/8] NTB: ntb_test: Fix bug when counting remote files Logan Gunthorpe
2019-01-09 19:32 ` [PATCH v3 0/8] Fix breakage caused by the NTB multi-port patchset Dave Jiang
2019-01-09 19:33 ` Logan Gunthorpe [this message]
2019-02-11 14:40 ` Jon Mason
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f0096e1a-4256-98e1-57d8-d18f5b01fbae@deltatee.com \
--to=logang@deltatee.com \
--cc=allenbh@gmail.com \
--cc=dave.jiang@intel.com \
--cc=fancer.lancer@gmail.com \
--cc=jdmason@kudzu.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntb@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®