From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 99DAA372EC0 for ; Mon, 30 Mar 2026 04:44:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774845888; cv=none; b=K2uUmHXp98ONBQoHa8i9fQNKQhN79LsFakkfkIbZDG48wiOzp/S396BgycNelJHn6skAw/z210reMkEv7ghI/A5OyziN3BcUZJGYQuTPffTJ5f3toVtXavTeS2oMgnn7G51eGejzoX+hM+nX7uQT2PJDU0LYknzqS5Kqb/BDmpU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774845888; c=relaxed/simple; bh=OmgR+A5aBUyQQzCcbcUrE1vjUaKlJ7rD8ByB17WnhBQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BgdfzHeqxRwH/geRIy1iN63q/gofG8GizSFh0pLRBqStnZY02aT5m+iZewNnDOVhcFaGN31E0cDp1VoZee66D8LwV4W+JnhEs620/BruTzJGOL7+6mKuLVbFqbBxB6mpwtKOJ0IFlDTCbcoWVL4nf+hIgN/9RFYq0mkDbJmQNps= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X00b5A9c; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZzKGuhMq; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X00b5A9c"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZzKGuhMq" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62U4IUR4103746 for ; Mon, 30 Mar 2026 04:44:47 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gQZ545nZTJlyfVvOJC8d3yTp0OQR2nViDIMcw9VvpJM=; b=X00b5A9cYIPWiUzr 4Os1MaGeiCeHZ0ef1GKbuuGWqLse+K7crzI8NDw5dZa3jl1+MdHW8uZBr9FKafde WKy6AvFfMAsq0N75eaLO1CYNHrkr7s8oIHOqscV9NB8b88lFhp5nNVxZTC27G0hH 5wiTzqij+3kjE2xorDd2zDlA9T6+t7r2LnqNtKGyRskQ63vyAnr1hGN4E3F+2gaJ MruKYx+MZ18mOxajo+le+KjEfO0Yvte/lxTJCulUllvUyxf2KyUX1KpmVmu1EVh9 OMv+7l0GR76c7uae+PBqTRAedewxaXM2ApT7FIWo9ecvS4SHcoC7z5aEXay3frtl xqpnzQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d67714dm9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 30 Mar 2026 04:44:46 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-2b249975139so42669955ad.0 for ; Sun, 29 Mar 2026 21:44:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774845886; x=1775450686; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gQZ545nZTJlyfVvOJC8d3yTp0OQR2nViDIMcw9VvpJM=; b=ZzKGuhMqI7zk1LTG6Ccpf3x4Mq2m1fvzSWN7Ln3MgMgSXuMpnGBh4BOeCWVb6byEul qw1kW9/ie2oXDJRMH9fC9m6pHwfQf5WJEZhRtbu6kLhOtM1vxrNUab1J69JHb3ZLqyxP OsUL0M+baGPXyY+KxbefQCA9wmqRlbBvpHI/uwuehY2arrsa2PyswPgjNp/R18fojwYI sO/C67pTxIc9MfnK3go1IU4IwWc+OydJP+Rz7cZ0ER7jPWWjfq2M36y9T1X2abpUzlDf tzC6bRv7Tcf1uBJRmF7L9zJECG+XGKXRKM+hnr1QdJHymRjWNNdlbrXO1IIiD5VkFAcF Cd5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774845886; x=1775450686; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=gQZ545nZTJlyfVvOJC8d3yTp0OQR2nViDIMcw9VvpJM=; b=Nkwp/b+/S5teFqAYkV7fcFKFd4o+gwFR3wdoXlzR5GFPqpvQwODbUuH4zTuj+h7PTE bd8CZdpewtdXUfUo9WgEM+TRr1lVizVn89236YXH6dog8/T0irvJzYP3jI7YVzUHrNcS AB3sRdI+Cr+wqwTJAD2QgcspQgIsu4MVNx3YYB/VMyuk5RrYPjxBb48gfKliwBhi+odX xBlrdoPni9e7dO177XV5UkcEOy3I5oBjtsxh2JE4ETJOO+2FHslZUUEQ3Kmtn7+vI2EV tdR4kP0U7yMiQ5FKVtrspnsnKyM1lVQJWMIcDRua5CKZtx8Wd3dlhZnUrLb6hBaX51hs mIpQ== X-Forwarded-Encrypted: i=1; AJvYcCVSHy3/iyfdmDH6CId8pXfO+rF0XD7KJPkcdL8qcHSSb/G0C9fhcxYvsQ1i8y6p1TKKU2T3XwvtPep0R88=@vger.kernel.org X-Gm-Message-State: AOJu0YwTfUR4w8nnjcgvE3U5Mv/J8Qyq6lRXtc/DOmYdmbRv14xhrwam bzb/IUrF8j3bjYjiS5VZgA0dNfjrn1AB80UQEIqipqNrs6OXhifao7gryqfVG7Su24zYvYi3Qi1 LaoTOMlousKOjb0mA8a5BBdj2b8HVQZbXoTks+MXU+vGtW5ZsBNvYQFDBtihM/0GqRFY= X-Gm-Gg: ATEYQzyOb+wAQEWaStL9M62XUtg29vfXzj3Qq8Gr1L1l0YnBP+vYe/jonn3ygDKRJXZ c9ZMkIrzriwMkzMwBeOC8vR22bZw76pSSpAeSmdJ64my+U8u0YOD4Y38oUdxx1xB8T9nfftULuN JowBTdo3GwLngIURnNgyg9iRiPikpS/F5DzG1lMUm/Ziext6HOHxMfYuQiDAf27FIv5AoxII1KJ D3gElfCoTgtj+yXREqavKDpogFs5vhzZMa/rZv/LLaF/sAwK/t0RBkSZXrIrX4DJmLzulKep9r9 N4ZLcdc3U2nblyZ4L3Jv8IYnEI6YRwplMuWUuIR97l1YB/a4o7Iw6mtkQxRZAYeDWsuW1miLQPv N8c2WEQfnPcgP4zat99Pc98lRaLCb/cMBwI0TJPxJiBJe/yyjmCxTew== X-Received: by 2002:a17:902:c946:b0:2ae:a8a8:92f3 with SMTP id d9443c01a7336-2b0cdcfa1d8mr123676615ad.44.1774845886329; Sun, 29 Mar 2026 21:44:46 -0700 (PDT) X-Received: by 2002:a17:902:c946:b0:2ae:a8a8:92f3 with SMTP id d9443c01a7336-2b0cdcfa1d8mr123676315ad.44.1774845885832; Sun, 29 Mar 2026 21:44:45 -0700 (PDT) Received: from [10.218.4.221] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2b24264256asm64599685ad.13.2026.03.29.21.44.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 29 Mar 2026 21:44:45 -0700 (PDT) Message-ID: Date: Mon, 30 Mar 2026 10:14:40 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 6/6] arm64: dts: qcom: sc7180: Add QSPI memory interconnect path To: Dmitry Baryshkov Cc: Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260324-spi-nor-v1-0-3efe59c1c119@oss.qualcomm.com> <20260324-spi-nor-v1-6-3efe59c1c119@oss.qualcomm.com> Content-Language: en-US From: Viken Dadhaniya In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: vmLGkPbtrizS55iI7om98roIZd8RJN2_ X-Authority-Analysis: v=2.4 cv=efYwvrEH c=1 sm=1 tr=0 ts=69c9ffbe cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=GBELfx7eKJZFaBSPsRQA:9 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-ORIG-GUID: vmLGkPbtrizS55iI7om98roIZd8RJN2_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzMwMDAzMyBTYWx0ZWRfXw7Fha6DM2jBI F7cCesKsHcnKQP5toYbk+uASkS2Zg+vptM9OpjlGRHPqL4O0MqO9Qsz542DZOqSFZOCjXwZgSsP 63bfGnMCu+y8s0VshHWBReFcX6ux3FxmowN3mTrFBSVptvOh3+r5vStUz7Ax7lltHnmjShH1pu3 tYdWRFMpcor6lU33/sBdcRgDrkquMWPgPXlyA2FLeaFuOzBkZL1QRh9wdt1Qh+qNhQ1GWBJWAkU Aizs+zDu1/Y5l0cGg3cxWSX6eifRCZHi3a6awdgE9ulTJEGThzVSVR5wJ2qg5mkA7Rqctx/xrHn kt+qBLpCC0KgSz2B1EFyjvGAI6xNNMEbSLTkFnNzHr7ah7AEkEtfqcWyJ7dUqQtS+RpWIyRtswd s47/buufI6CxdYirUhd1/iGWS42oKPXlF8dx8UInJWTi07DeyjBOEIVrCQUR9FGfePCK+PanIww 2JwnHNK8lnxK0U0HpTA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-29_05,2026-03-28_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 adultscore=0 clxscore=1015 spamscore=0 priorityscore=1501 impostorscore=0 lowpriorityscore=0 phishscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603300033 On 3/25/2026 2:24 AM, Dmitry Baryshkov wrote: > On Tue, Mar 24, 2026 at 06:43:23PM +0530, Viken Dadhaniya wrote: >> Add the missing QSPI-to-memory interconnect path alongside the existing >> configuration path. Without this path, the interconnect framework cannot >> correctly vote for the bandwidth required by QSPI DMA data transfers. >> >> Signed-off-by: Viken Dadhaniya >> --- >> arch/arm64/boot/dts/qcom/sc7180.dtsi | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> index 45b9864e3304..7093b39e1509 100644 >> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi >> @@ -2864,9 +2864,10 @@ qspi: spi@88dc000 { >> clocks = <&gcc GCC_QSPI_CNOC_PERIPH_AHB_CLK>, >> <&gcc GCC_QSPI_CORE_CLK>; >> clock-names = "iface", "core"; >> - interconnects = <&gem_noc MASTER_APPSS_PROC 0 >> - &config_noc SLAVE_QSPI_0 0>; >> - interconnect-names = "qspi-config"; >> + interconnects = <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_QSPI_0 0>, >> + <&aggre1_noc MASTER_QSPI 0 &mc_virt SLAVE_EBI1 0>; > > The same, please use QCOM_ICC_TAGs Sure, I will add it in v2. > >> + interconnect-names = "qspi-config", >> + "qspi-memory"; >> power-domains = <&rpmhpd SC7180_CX>; >> operating-points-v2 = <&qspi_opp_table>; >> status = "disabled"; >> >> -- >> 2.34.1 >> >