From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (mail-dm6nam04on2053.outbound.protection.outlook.com [40.107.102.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3BDDB17F4F2 for ; Fri, 10 Jan 2025 20:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.102.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736541109; cv=fail; b=m50jcuShCCat6qp1JdJqq/6bdZeoX4IMb1bp8bYK/ebz5jJUNqgmPhNXXRoQT7O4JJlX3w4zsKulAcPLjMx2pi0KFVA4dkTCuPP93NLGomzk83eQhOSZ6gmDj+XAUxewNnWtxQcPQi+YkOTbVLWRlMCR/p7yGoNC38ty3deHz2k= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736541109; c=relaxed/simple; bh=r92DNwcs5PaBAtQZVvyPE4kVKDRcnL4ZKQ/qLqGKsh0=; h=Message-ID:Date:Subject:To:Cc:References:From:In-Reply-To: Content-Type:MIME-Version; b=UFeOkoOUPmBI+6Hh0pKzsX/FoplYlXEZaedjvW4gY0QXeeszy23dd/UOCaZjp7Fhu3Yk/yabNvQ6ngGenfDizZtvO9pzCru/VkhI1kz27JZwjiraW5maTy+rA5irNWssSa+lQRtvoOEQUVrhK3JgshzJZsME6WOV2Ld4N9sghdY= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=KbkTfRJ9; arc=fail smtp.client-ip=40.107.102.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="KbkTfRJ9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=vinLoGW4LXR8/gqMsIE1PRMa4n1pDDInDbw3cvNYSfDeWJwchcwmu5XYTCTzQmkiqiW5gfzTFqWtK8WAb1mi0WA4+NBydKiEZm46xm/9yDMscbLS226DINy/dSWkVpl91HwJ+Zpnfvkqj3+TYtrsDy5ZskTp15HymanWEtUgPyoir7M0x8225WGwWd4+ces/KdrwE/1u5bM1QlyTHj6aTyhjL0kbSHKSPWM8rFCed9POuQ2R9Z5wwyYcbGoGaggmkcmbjzPS8RwDQZ14UI+OV2F0UwnfyvAascDppsqe/VWBPbGYk3V7bGeaEGJXD1KBuduOJxhAbdfBxOlISCH2fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EBE1graixZPRQcpsZXsmqYBpPo1EJuNXWE//EHKi0bQ=; b=GTgGoN60/l26RkqecLgK0l1T4KYDXI4aqW+cbq2z2uKyJP3BrUW1GuEuY1mhcLuq55Mpi2RIqwZeDduHLHKID9iLCcCzarABjJSphJackSZKozQnGMSOO/RhMFFM/A3F2DcdiHir279GEOIGBD9E7g/qMgvlF2QjwrcTssbxF4SeSzeQrq85t5I6sG4Uk3jDtFaDvPUjddfIvx32+zkUbQS9WiNzimx84MMew8ypvllVdA0kg/QNcGCqjriUjEa5B5RG6sAAmhKDoSUfHDIjahkYP34CMwjPLB+/Svj/c0fpP071mpiUPaTos4arxyFQY3WFq3VGMmsj8NsFlFDw5Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EBE1graixZPRQcpsZXsmqYBpPo1EJuNXWE//EHKi0bQ=; b=KbkTfRJ949ReR7KYT7Gci93ZZ7L3NytouOBM85wL0sUtnFHwfwc8HRIX0IU11jvW5mFgsfk12+8JAvdjJIzqpVmgDM7F9rMr2Q/gLiJQ18l74+hi2a2fgddHtV9xnag0+W7QiwD8+pbVXvtJ9DixKgCRrHolw3oReStvpRx1lrs= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) by SJ2PR12MB7866.namprd12.prod.outlook.com (2603:10b6:a03:4cc::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.17; Fri, 10 Jan 2025 20:31:45 +0000 Received: from DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::20a9:919e:fd6b:5a6e]) by DM4PR12MB5070.namprd12.prod.outlook.com ([fe80::20a9:919e:fd6b:5a6e%7]) with mapi id 15.20.8335.011; Fri, 10 Jan 2025 20:31:45 +0000 Message-ID: Date: Fri, 10 Jan 2025 14:31:42 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH 04/12] x86/mm: get INVLPGB count max from CPUID Content-Language: en-US To: Rik van Riel , x86@kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@meta.com, dave.hansen@linux.intel.com, luto@kernel.org, peterz@infradead.org, tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com, akpm@linux-foundation.org, nadav.amit@gmail.com, zhengqi.arch@bytedance.com, linux-mm@kvack.org References: <20241230175550.4046587-1-riel@surriel.com> <20241230175550.4046587-5-riel@surriel.com> <3bf6f37a386ef8afeefee54202283023c0581f58.camel@surriel.com> From: Tom Lendacky In-Reply-To: <3bf6f37a386ef8afeefee54202283023c0581f58.camel@surriel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MN2PR06CA0025.namprd06.prod.outlook.com (2603:10b6:208:23d::30) To DM4PR12MB5070.namprd12.prod.outlook.com (2603:10b6:5:389::22) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR12MB5070:EE_|SJ2PR12MB7866:EE_ X-MS-Office365-Filtering-Correlation-Id: 4203dc86-e7af-4d28-21d1-08dd31b5cd2a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?bmVnNkllU1FKRnp5RmQwVWg3R0dUd2pLckwwWGVjTmN3NmtyUUg5Sk5WaTRD?= =?utf-8?B?dHdsN2E3QmU0RTdvbmhtZ1gyOEt1RTVWQkp0SWNCMkh1aWxtUFRnQXV6aUJG?= =?utf-8?B?U25USjBzZHNCRHZCazlZbHAvVGJVNHJXeTgxVHREam9kblBZVFBCRTlNY1Vx?= =?utf-8?B?U2I2N0RwL0hpcnNIS2UrTHp2RDhsNkwwK1RQMHdxTmZ3VDVTd09JUlNuM2Fy?= =?utf-8?B?TGtTRWRZUmVqUUVhS2pDbXBydkZZNjQ3NGtUMWtWZ0pTdENXMDM0dE9pMEVz?= =?utf-8?B?NzJqbXNWbW5vc1dPZFhQSVdLaFd5ajRGYmZBdC9xRm8vM2gySExOcG1UTHlW?= =?utf-8?B?L2lIQjhIZCttUlU4WGhSbVZHT2M0U0psQ1EzUW9uNXNxS24rU29PYjQ4UDZ1?= =?utf-8?B?MzZ5cUVwcERZNTRrUTB2T1Yrd3J3Y0hWVVhSb2lHSzdHL29vN2tZY3BKWTlN?= =?utf-8?B?dUZ1WUZVQ0FJV3M4TVRuUHJBL2tCWDViZkJudTFMM1pBcmU5VkZ0czl1dnNz?= =?utf-8?B?cEZCVmdpb1hId3MyS3Zma2pWck0wYnlIWUFUU1h1QVlEUnVtc0dBR0NvMHpl?= =?utf-8?B?UWNETFdVZmx5NTFqZC9XSkFDSEI1MFpoZERYTUJiVDNSMll5Q1FxbXNqQW0y?= =?utf-8?B?VW5HS3NzUFN5cVBFWE1CbjJTeHlwTE1IMGZJb0NadktvYzYzNGptN012c0VJ?= =?utf-8?B?ZmdEZDcwRXBldmlBbFY3Q3V2eGZTL2JnZ0FLVnQxY3VYd3orcHM0bEVLRlZW?= =?utf-8?B?bktvRjhQaDIrT1NyTHc0NXAyNmJSd3BCZU1XOVl0M0kva0hodGF6RXp3M0lG?= =?utf-8?B?UWlFT2NKVHpERFFMV3FRdEgraGZ4enE2d3gyVHlsT3RYYkV5ZnJZMlRsZHBO?= =?utf-8?B?cnFiK3JzL1Uvb2NJZ3RWK1dPUEVMdlA1dVRGd2JSZFNGUVo2WWhieGwybEdV?= =?utf-8?B?QmE0YzJzQ0xLaUM2cUhLNDBUdGtJRHlYL25mQzUvKzIzZW9YaFpTYWladkJs?= =?utf-8?B?SmxFVzFrMi9USDJyeW15Umk0R3h6b0hULzNIQ3FkaW1RM2w3N2VuQVdkdEhO?= =?utf-8?B?N2pTcWNQcU9UdStGaWlmbFNnd242S3VuVkFGTWNlMnBtcVJHL2p1cGJEaVlH?= =?utf-8?B?UkN5SlgycmNQTUVrRUp1SWJMN2FPaFI0N2c1eXlkTHFPRVd4Ykw2NnpnSGww?= =?utf-8?B?dVRIc1pBdlphbDZzcisxSHZIN0FtOGYwTGlhZlZ6QUYvOWlkSkhPSjRQWkZx?= =?utf-8?B?RjIvQXJCLy84M1JGZm5OaXlUdDFBNGVzcWJBR1RSS1F5QWlYNEFONk1qc1ll?= =?utf-8?B?U01CczNnK29seDVHOWp4NHpONUhTZUh1R0RnVWdUSDIyc29iY292VHRkVkNv?= =?utf-8?B?TUc2elpBUEFpbE8vWG5OT1p5d3hPVHdMa1FtdEtWRnRpNzBTck9sRmNZNlZW?= =?utf-8?B?L3Y1aE1pUE1EUUFDM09ZZDN6akxxRFVWb2tBbWh6YmpYbVNvQkQ5YmlwTFNM?= =?utf-8?B?d3dubXhSRm9nMmUxcDRwMmZNSnRwNENvUkg4ZG8ybURkMlhvV0xpeEVicnc5?= =?utf-8?B?aERUb3l4UU52dHhRY2VBRDJOaTc1U2xyVWIzNWI1Qk1oZlNrRmk5c3ZMZ0lV?= =?utf-8?B?TlhUSUhlM3pxT0V5ODF2VVpycktqRDR1L3ppWHdmMlR0VVVIVEhFTWZCRnEy?= =?utf-8?B?dVY0NlNyWnRHeitmVk5WWjBJdVhPeHNYSXF6NEtWU2JRUVZnbWpldndlOVpG?= =?utf-8?B?UkhEQ3lkbnNXQnhrSFdiVUI2Wkhualk1TG1hbXJNZTdkNjZtRnc0WEFXYVhy?= =?utf-8?B?WVdGMmtSK2hMdVMzVk91cTRDeVRRQkI5UmRIMzFXbUs2UDFjNHAwQk5hT0ln?= =?utf-8?Q?aJs8VZGJXaeI0?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR12MB5070.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(366016)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?L3BTZmZEZjUrN0VtVWJncnZPQkFlaDdkSTVvSHlMTzVkRm5Da2NqRHNjUGZh?= =?utf-8?B?OVpNNm52V0VZYXRPSEI4Q282VzVYUUNGN1B4RXN4WmtZQ2J6ZGxmR3dld1RQ?= =?utf-8?B?STY5bDJFb3JNcDhtN0JlTFhEVVpNdDd5MFZuMkFFOXlibnNBU3ZkMmYrcDVu?= =?utf-8?B?RXBaQklKYm00V08yVHJLVG9PbEdYOXl3d0xUOFlJK0NrVkxRNnNTaWVlSUpB?= =?utf-8?B?ZXVKaTNBeUVLQVUvcUhxZmZDZ01WcTByZFhqVk5yVlh2bGdOaitFTjVKMy9M?= =?utf-8?B?UjQ2WCtWaWYrRHovQW13WFpMMElkR0hMKzNTLzZ5dGRQeTFmZ0RqSFpNZ1Jw?= =?utf-8?B?c2ljTXZWa04rYy80bER4WW5MM3BXTElOc3dqaWVJS1JhRXVSbXZOeWxZRHJu?= =?utf-8?B?RTVHOElGOWdNQjNvTFhTZ201K2hxN2cyczNORTJwNU9uZjNKaW1QT3EzNkJa?= =?utf-8?B?MjFzejZMeUVZemlSalJ5ZFJpU2g0TzhyYmY1b29Ba0c0VjlqLzNGWUZMb0o1?= =?utf-8?B?eVAyaHdGbDJJUFJRdUdXaG9MbzRLL21sVlp4MUxaUVh1bFdscXo0UGVla2s5?= =?utf-8?B?RFpERmRoWUVuaE5TZFlBMUsrdEdQdnl3eHh3THV4TlJKVzJ0azg1bGVQa20w?= =?utf-8?B?UktNR1lsR2xnQlc4SVZURnVSMHN1YXlkZjRaNFBUOHBoMXI4dW1vMTluZkxx?= =?utf-8?B?NGZiWjkyYWtEeVoxbEpRdjdnSERqdnI1NEErTk56MzVWWXVuL0xPaHZYS3hr?= =?utf-8?B?M0ZvSXBrS3NpaTFrcjV5aU1qQzlQaEMzMHF2ZXBBaXZpd0NYeVNSaUNHUnN3?= =?utf-8?B?ckgrOVZVYmZDamVkeVExZmxLbmpTYVA1OVdFZmdINUN4MEhid2w0dGVXOXZs?= =?utf-8?B?U0IvcU50T09RdjAwblh2Vy8zWnRkRU9sc09WeUFGU0xPcDR3T1M3K1F0MkN1?= =?utf-8?B?MjFsNFVldTNLMXY5WjZOSXJHU2wvUzNLV2xpa1hOTytKZ3BsbEQ0VGhrTDdE?= =?utf-8?B?bEJrSG45VGtEOU9uOEhjSnVyMi9SKzUwTFowazFBQnlJTkN5Q1JUTTYrTnZI?= =?utf-8?B?WU0vRUR3dXpWT3NTREpaYU96L01BNTBYNnJNS0tXYTEwMlVCcGlNK2NjQ1FS?= =?utf-8?B?M0ZxVlVSMTdoam1sVkRqTk1nYS82Y044Z2t3MndzbUpyd09Td3ByQ29GZTVJ?= =?utf-8?B?d1creDJDcEVUaE9vUmozVGh1dmVISk5SSFNBWWQ5MlRVTWpDSWREdFZJL3Np?= =?utf-8?B?czRoZC9Fd3pJWXR0TjlhQVg2Y1dSU2ZWSHFsbGEraFBRbXJFbmxIeHBEbDla?= =?utf-8?B?RnhIOUVBU1JJY1pQYkUxekQvSmNQS3UyanJwRmdpL2dCdzcwbWtiSkhPcDdm?= =?utf-8?B?a1hZNm5SdERMOTRDeHBHcENUKzV1NjZSYk5KeDNZN250OHJCcllWRlV4Q1ZW?= =?utf-8?B?cWE0WnJLdGhmVzBqK3pDNlAvSi9GL0R4Yjhmek03MmcwZ1FqL3dabFRBc3cw?= =?utf-8?B?TWRwQUU2QUdlRXJKWjZuOHFtQ2J5bFFPNU95d3p5QzJxSHpOMERlLzZEUTF4?= =?utf-8?B?UHNJeGFWZWFyUXRieFBTN080SVZzWVJ3VzNzb2pXYUZ3MWdrUXZOSmYvL3Jh?= =?utf-8?B?REcyQW15ekU3Wk8vTFQrdGY1eWxYMmhwaHJwVHNVNFVudm92emVKT1R2VzJ0?= =?utf-8?B?R0ZlTGxqZlB2cFg2eHdteDBkOGVydVYra00zTGNUcDlNVXg4L0VkdEZPa3Va?= =?utf-8?B?eExqZ05IaXhoMm4vTW1Bc2QvVFpsSVRmK2dKTGp5QXBWZm9Kc3c5VGJpVGtk?= =?utf-8?B?TTg2REY3N2VvakdUY0VWQUpiSWRDeG9XOGFxVG5TYTFKZk1HWVZLK0s3b1Rm?= =?utf-8?B?bkl5R3ZDNnNTZmhtaE1hTys0RDh4TWkzUzE5R3JRbldVZGZRK1NXMlo0TmhJ?= =?utf-8?B?VDRncXNVM3V6K3lxN0FIeGNHdmZwWWxabVVVTjQwWTRkcGdpdFY1U2RnS08y?= =?utf-8?B?QjZiQkRMN1BvVmpGNklqT2hmSkY0T05DU2VQQ2FpOXRKMFI4RmJvL0JGTnJk?= =?utf-8?B?aG5DYWdjL21yZG9neTRrZXgxTnEyNUY4M2FQemU2T284SEsyeloxWDJKemtx?= =?utf-8?Q?UdVv5Iu10LUKIxiRw92Rf1GyX?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4203dc86-e7af-4d28-21d1-08dd31b5cd2a X-MS-Exchange-CrossTenant-AuthSource: DM4PR12MB5070.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2025 20:31:45.8968 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HE2rqq72umTUMBsvmCUxNPKakbe9BB59Z7+53xYO4cZKQYvQRDFVRUxgROC/RChoPktYMTqWxlg07xdcIZR1RA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB7866 On 1/10/25 14:27, Rik van Riel wrote: > On Fri, 2025-01-10 at 12:44 -0600, Tom Lendacky wrote: >> On 12/30/24 11:53, Rik van Riel wrote: >>> >>> +++ b/arch/x86/kernel/cpu/amd.c >>> @@ -1135,6 +1135,14 @@ static void cpu_detect_tlb_amd(struct >>> cpuinfo_x86 *c) >>>   tlb_lli_2m[ENTRIES] = eax & mask; >>>   >>>   tlb_lli_4m[ENTRIES] = tlb_lli_2m[ENTRIES] >> 1; >>> + >>> + if (c->extended_cpuid_level < 0x80000008) >>> + return; >> >> Can this just be based on cpu_feature_enabled(X86_FEATURE_TLBI), e.g: >> >> if (cpu_feature_enabled(X86_FEATURE_TLBI)) >> invlpgb_count_max = (cpuid_edx(0x80000008) & 0xffff) >> + 1 >> > I don't see X86_FEATURE_TLBI defined in the tip > tree. Which CPUID bit does that need to be? Sorry, I meant X86_FEATURE_INVLPGB. Thanks, Tom > >> Then you can squash this and the previous patch. > > Heh, I already squashed the previous commit into > what is patch 6 in this series, as requested by > Borislav :) >