From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B27CB355048 for ; Thu, 21 May 2026 08:29:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352155; cv=none; b=C7B86h8HNDaeHEvgF9LFEemrOpieVFx5+thMkyTBH8IYVukSFn/A0BPZR4pGJyhtWkpAfXEcmB9lV6jBAaT4sEPZfLimmD7aWuf6Lsil9SStDlFLdZwi3Ba99VdzLhKX5MeOJP4zqNStV9rMg7aBuUmVqy9aKZzqC9e9hfBQ9fo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779352155; c=relaxed/simple; bh=Cmhs6ceQf/BjER7N8/6GDJCLq2/BYD0NYwP6KHJhYUQ=; h=Message-ID:Date:MIME-Version:Cc:Subject:To:References:From: In-Reply-To:Content-Type; b=k9h3yehMyihKEpcQ55G2drlKJjCvvNy4KH4RBGMP9dZkdgm2QOvbljV7ObUfLyIzY7+g7IuGVKA/EYWjtXlPVwl1JfYG1ssJSyrSQqAXfZeYv+wHc0BdpxeRNKtQzNP0pgUQsEejOSkSo67R4K/o4QW0Ln4ySsf1Sx9BjMUSBWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=JKuRjNOd; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="JKuRjNOd" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 129B21F000E9; Thu, 21 May 2026 08:29:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779352154; bh=vOCEfgNYXKiVGJd798lyzXOfQOk4wWjeEy9YzVjrJn8=; h=Date:Cc:Subject:To:References:From:In-Reply-To; b=JKuRjNOd1CE6RzL6kH02FLD+ke3nSr25Q3kBoqP46hvSROeYDc3c/TMjThJIPBlEw B7BUXjjAzYQKhcLNhe/qm3gLUm78PcZOLCsnHY4ySO4e3/r6rASs+DJ5v+Plx4bKKH Fin8t9fO106smxzD7i1qgj8MPCrcu32faz81C+tC/M/z/cOx54p52Wyk+Vtd4NxeZe 9XJTUmRH4W5oM5sLCusyLBzq9moC7AEm2kNyNhkydZCClKFFkWU6Ze2UfzA9izdfEz Gjt1Rray3LU/G5WTrLfDcHvmdbskQHyPCHqodqVfBeU4xsOm3HNqF6OXDVY/tz9KFe nuZi0mh5p5wOQ== Message-ID: Date: Thu, 21 May 2026 16:29:09 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Cc: chao@kernel.org, yangyongpeng@xiaomi.com, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, qiwenjie@xiaomi.com Subject: Re: [PATCH] f2fs: pass correct iostat type for single node writes To: Wenjie Qi , jaegeuk@kernel.org References: <20260520120705.1263756-1-qiwenjie@xiaomi.com> Content-Language: en-US From: Chao Yu In-Reply-To: <20260520120705.1263756-1-qiwenjie@xiaomi.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/20/26 20:07, Wenjie Qi wrote: > f2fs_write_single_node_folio() takes an io_type argument, but still > passes FS_GC_NODE_IO to __write_node_folio() unconditionally. > > This was harmless while the helper was only used by > f2fs_move_node_folio(), whose caller passes FS_GC_NODE_IO. However, > commit fe9b8b30b971 ("f2fs: fix inline data not being written to disk > in writeback path") made f2fs_inline_data_fiemap() call the helper with > FS_NODE_IO for FIEMAP_FLAG_SYNC. > > Honor the caller supplied io_type so inline-data FIEMAP sync writeback is > accounted as normal node IO instead of GC node IO, while the GC path > continues to pass FS_GC_NODE_IO explicitly. > Cc: stable@kernel.org > Fixes: fe9b8b30b971 ("f2fs: fix inline data not being written to disk in writeback path") > Signed-off-by: Wenjie Qi Reviewed-by: Chao Yu Thanks,