mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@fb.com>
To: Shaohua Li <shli@fb.com>, <linux-kernel@vger.kernel.org>
Cc: <Kernel-team@fb.com>
Subject: Re: [PATCH] blk-stat: fix a typo
Date: Fri, 2 Dec 2016 20:19:39 -0700	[thread overview]
Message-ID: <f00d75fa-d76e-50e1-2182-38de2731f2d1@fb.com> (raw)
In-Reply-To: <a579d4ff-59ad-760f-18f8-aceb88f71391@fb.com>

On 12/02/2016 08:16 PM, Jens Axboe wrote:
> On 12/02/2016 06:13 PM, Shaohua Li wrote:
>> Signed-off-by: Shaohua Li <shli@fb.com>
>> ---
>>  block/blk-stat.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/block/blk-stat.c b/block/blk-stat.c
>> index 688c958..4d01185 100644
>> --- a/block/blk-stat.c
>> +++ b/block/blk-stat.c
>> @@ -12,7 +12,7 @@
>>  static void blk_stat_flush_batch(struct blk_rq_stat *stat)
>>  {
>>  	const s32 nr_batch = READ_ONCE(stat->nr_batch);
>> -	const s32 nr_samples = READ_ONCE(stat->nr_batch);
>> +	const s32 nr_samples = READ_ONCE(stat->nr_samples);
>>  
>>  	if (!nr_batch)
>>  		return;
>>
> 
> Gah, that sucks. Thanks, added for 4.10.

BTW, this was added right before inclusion, all the previously posted
versions were not broken in this way. So thanks for spotting this!

-- 
Jens Axboe

      reply	other threads:[~2016-12-03  4:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-03  1:13 Shaohua Li
2016-12-03  3:16 ` Jens Axboe
2016-12-03  3:19   ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f00d75fa-d76e-50e1-2182-38de2731f2d1@fb.com \
    --to=axboe@fb.com \
    --cc=Kernel-team@fb.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shli@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®