From: Bart Van Assche <bvanassche@acm.org>
To: Brian Masney <bmasney@redhat.com>,
jejb@linux.ibm.com, martin.petersen@oracle.com
Cc: alim.akhtar@samsung.com, avri.altman@wdc.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
hugo@hugovil.com, quic_nguyenb@quicinc.com
Subject: Re: [PATCH v3 1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init
Date: Mon, 14 Aug 2023 12:31:31 -0700 [thread overview]
Message-ID: <f01040be-dfa5-fe60-fba5-410fccc1d50e@acm.org> (raw)
In-Reply-To: <20230814184352.200531-2-bmasney@redhat.com>
On 8/14/23 11:43, Brian Masney wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index 129446775796..409d176542e1 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -9235,8 +9235,9 @@ static int ufshcd_variant_hba_init(struct ufs_hba *hba)
>
> err = ufshcd_vops_init(hba);
> if (err)
> - dev_err(hba->dev, "%s: variant %s init failed err %d\n",
> - __func__, ufshcd_get_var_name(hba), err);
> + dev_err_probe(hba->dev, err,
> + "%s: variant %s init failed err %d\n",
> + __func__, ufshcd_get_var_name(hba), err);
> out:
> return err;
> }
This opportunity could have been used to improve the grammar of the reported
error message. Anyway:
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
next prev parent reply other threads:[~2023-08-14 19:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 18:43 [PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe() Brian Masney
2023-08-14 18:43 ` [PATCH v3 1/2] scsi: ufs: core: convert to dev_err_probe() in hba_init Brian Masney
2023-08-14 19:31 ` Bart Van Assche [this message]
2023-08-14 21:18 ` Brian Masney
2023-08-14 21:24 ` Bart Van Assche
2023-08-14 18:43 ` [PATCH v3 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm_init Brian Masney
2023-08-15 3:25 ` Bao D. Nguyen
2023-08-21 20:45 ` [PATCH v3 0/2] scsi: ufs: convert probe to use dev_err_probe() Martin K. Petersen
2023-08-25 1:12 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f01040be-dfa5-fe60-fba5-410fccc1d50e@acm.org \
--to=bvanassche@acm.org \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=bmasney@redhat.com \
--cc=hugo@hugovil.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=quic_nguyenb@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®