From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1931E2253EF for ; Thu, 12 Feb 2026 15:01:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770908493; cv=none; b=UUXd4v8Kll/Bz7AYxe2aNqgaLchkPcIQI73l3hWOfkrKoDRVs5s2jWjGLZLs4oZRHLgogRenbpWYXyKz44EKCn9f8FGW/UtYAKJtPkt4HOO4Z7cS+ONbd8ubaGRgVNRb1sNweGqGzkQa63Q5HPUe7WpMwcjpzQK/RhKGdd/gaHo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770908493; c=relaxed/simple; bh=LWfPVJFhuZRaigIzhk5OdpvGw4AR/InmFYo5/gO3ktk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=cH1gZYppe1pNdL/cQhAUnJ46IL0pWwgNIE78iEZuqjCP0maV+wLF/Tal3WQ7fv68No8EYHtbDG6unld6d5saio9ItQazc8MWtTjWkYllauH1rk4qSLhwdl9c5YkuRGPx+QpuCfCOAYTxCWNt/dYgWlYqumN5TH587ENv00uiS44= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YVH+lzwC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=TdSYUuPx; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YVH+lzwC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="TdSYUuPx" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 61CDReH54033332 for ; Thu, 12 Feb 2026 15:01:31 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Td8TkWhaFGm2U4+qFTUwHeU05QZK/KaVCrS+oH4rQ4Y=; b=YVH+lzwCwaaTjQUD pgCzHVxmFw0NmNAqwG5GeoX5m3rr0pvjBdYdxZia4OXbTQFTOX1dMiOIhW3JUxYt uAP/F7shw6cHXBEqVuz9XLlq/FPTbNGJzoxGiw4o0u+NXkf0jnzU9kqJTuqbDTZh DrRv7HmOhsY9wuIYZORwy7XbMEaLSIWQB4H+6HA1o8VK939EAgttKlkvNC9W8Dca TgpRHmHmzYln7VoqA9oW+SOdJrr/l6/IZhdvPcXM98QFJSiWvFx+qHY4ifFPNr2S WdPkatyhMLP92Fv9Slx5A2f+9gMP37yx/i0eBeqfVFqxnf9TGrhOYsGHxCRYhtER DLI9MQ== Received: from mail-oo1-f69.google.com (mail-oo1-f69.google.com [209.85.161.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c9ck2h09b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 12 Feb 2026 15:01:30 +0000 (GMT) Received: by mail-oo1-f69.google.com with SMTP id 006d021491bc7-662bf7602b2so2028140eaf.1 for ; Thu, 12 Feb 2026 07:01:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1770908490; x=1771513290; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Td8TkWhaFGm2U4+qFTUwHeU05QZK/KaVCrS+oH4rQ4Y=; b=TdSYUuPxO7Og4HV2K+fgQfNEfnX9r2sQmNecQEb6x8SIvIRf02Jd2CnVBK8fLc2asE ayagm9ID3GdDexb8jzb/Ip9T51c5zJ+L4ZsGW2W6ZyjW0rQKgFMiwXUdoaJmjb/SnjOs 5BIsDEl5zha2vd59r5442vfYlazfc0fPXIyx+vunVaHcVHUmHOoCUbq4faoU1kDqZ9vD JC1Lw2pe+at/qMWZl/7pKTTDQnSYiEwrH+id8YbrUPZ8+CRmcdqQ3d3rtdu/VDVS1v6z sXzf8Q6M5evh+GZflN+G6YquUtu8LIPTk09aHP0PZ+gsPPzLod6cD4oOsfLEQybe0k/r dy6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770908490; x=1771513290; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Td8TkWhaFGm2U4+qFTUwHeU05QZK/KaVCrS+oH4rQ4Y=; b=oHmFYQeZVLeJuOH0x7KzW4R5Or6gr3goFYn/enPYHN3dQx/pPK+JuduvZhzP3UrQ7R GAyNaJS4W3JzKZrtgNTunkYWXmLfU/RtL9+831sPw+TOlzgWoW24G/3RDIDs2AojCg7s VvPYP4XF90caerabpt8xfjPCaMZ/Jpwh3UM2CcPZAf/+bCe6aNZaCTqpLtduJw3qUykE qA9oseS2GiiGm5c0k+5PYkBRgvA6th7Gw/pIS8e37ShaRwbCjpehFLEgMUqDwVoFoT0P dk+xuBZBE2EgsUETcSFzcE/7jak5VIBs0XinexvaA5DGOwshwYYpWtLeWOIJkGtz/wRr VvSQ== X-Forwarded-Encrypted: i=1; AJvYcCViq62ttkJQnQfMvrkbqCHn+M1aSZSbWaxNKVhcHL0trKrYzdv7S3mAQz5lw9AhfUe2EcG0LsM5Nrq25Fo=@vger.kernel.org X-Gm-Message-State: AOJu0YwxalfcMJuGa/IMgSUrZ+Q96Xv9RgwG6iJjcZ5S93CIRuTfgIgA aR+HTWCqAvd3Y0Ts9xnv9aUWdBU9vumVHsn6LBgZqkkvzCec+XLJ8ZpAw3KpBEiw6KrZgKzqY8J Pt845HswqmBS1R+PIeP3kNXHGBuWAoafJV27AggvJ8L9FoiuW3Esi0qPNfuxbas48H2M= X-Gm-Gg: AZuq6aJFrtDMGQ4j4aEGzeBgyJ3Uf5PDR0jOcbPwmvk0vAfdQFltp4GSNDiwNFqNp+S +LtNRqcru8fgxqJAapM91btyk8ZRYfIJqDwqTrbAGqMX/rduV2QCn+J2VQB10vrLKYjuAFt4ysZ vG46/0a+Mgsqqc4qVG6VS/+yGOXnDfxPKBzb6KvD11nn9k/KbX6M4nTYLbcHSlAeYOqVbi4Dauu p67O8pch3MSOkXFLDaH5fDzlFb1SRPZTtSUfVO1kmhRKp4niCItATNwDL8RJCFwOMD8VpnkYN5l F3xua0ngQVVnljJ2Gt+IcBzgxx/eH75xa5wP0N8WIK4b1owX7IMZSTfifIEysaGP9QBJR6yJGKu h5Osgr2aDZsp7g2H95z230gn2q0jI7PVaepROMMS1QK5XSQY= X-Received: by 2002:a05:6830:2b25:b0:7cf:d0f6:a1eb with SMTP id 46e09a7af769-7d4b29884b4mr1211343a34.1.1770908485947; Thu, 12 Feb 2026 07:01:25 -0800 (PST) X-Received: by 2002:a05:6830:2b25:b0:7cf:d0f6:a1eb with SMTP id 46e09a7af769-7d4b29884b4mr1211260a34.1.1770908485219; Thu, 12 Feb 2026 07:01:25 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65a3cec9e7asm1834360a12.12.2026.02.12.07.01.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 12 Feb 2026 07:01:23 -0800 (PST) Message-ID: Date: Thu, 12 Feb 2026 16:01:21 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] wifi: ath11k: Silence remoteproc probe deferral prints To: Bjorn Andersson , Jeff Johnson Cc: linux-arm-msm@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260212-ath11k-silence-probe-deferr-v1-1-b8a49bb3c332@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260212-ath11k-silence-probe-deferr-v1-1-b8a49bb3c332@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=cd7fb3DM c=1 sm=1 tr=0 ts=698deb4a cx=c_pps a=lVi5GcDxkcJcfCmEjVJoaw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=HzLeVaNsDn8A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Mpw57Om8IfrbqaoTuvik:22 a=GgsMoib0sEa3-_RKJdDe:22 a=EUspDBNiAAAA:8 a=IsMmzSx_pjv120c435IA:9 a=QEXdDO2ut3YA:10 a=rBiNkAWo9uy_4UTK5NWh:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMjEyMDExNSBTYWx0ZWRfX60mWT40x140Y re4aqQrF0C2DbCXs4cSeMLj8t+p5nk+Dmb+vIxjltCCwyFPx6NPuFGu92mTRttm2fUk/dxuoKoN CnBxkgMbLDxqWwCeZjQmbax7F6RqroJNRfnuw3dQIlRBI3cx8jwMwUe8E6Ahisf1x27CTpSBwE5 j6flO+BC56XX9kQ+sKiGjZasoFaNalqlMgsRoXU+YKVu9Ih68FCdYRyVc09sDtwO3mokxY9tcJ6 hPFdbosU1LKldh/YE3aS/tgeH/POm+Sg1o8AoHRuB32uHlEvhrZuZ9Qe/dWg8au83RT7kWne1LF KfSFQ3dTkU2mllCyUyWJAczXKUlaUr5jB8+68DEeNCEz+PohOG3IxvZJSHaUurDFQqhM1Fq3GtM bjserpaRCNlO+MBBtwOaMuWj2qcV9uxSB9j/yExYbfyiNc74tDBxMhi6lMiPyB1boNT3FDND4S2 X1e84OrT3/iYlW9qKKw== X-Proofpoint-GUID: TGFHFlx8-kk9mT_y_6SHrgsEGTORE8Uy X-Proofpoint-ORIG-GUID: TGFHFlx8-kk9mT_y_6SHrgsEGTORE8Uy X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-02-12_04,2026-02-12_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 priorityscore=1501 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 bulkscore=0 phishscore=0 adultscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2602120115 On 2/12/26 3:52 PM, Bjorn Andersson wrote: > Upon failing to resolve the remoteproc phandle one ath11k_dbg() and one > ath11k_err() is used to tell the user about the (presumably) temporary > failure. > > Reduce the log spam by removing the duplicate print and switching to > dev_err_probe(), in line with how ath12k handles this error. > > Signed-off-by: Bjorn Andersson > --- > drivers/net/wireless/ath/ath11k/ahb.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c > index 8dfe9b40c12626649639fc1dd9da0e5e0c2dcaf1..08d3a0c8f105b26b1548c5d6006f6ea162fe58ff 100644 > --- a/drivers/net/wireless/ath/ath11k/ahb.c > +++ b/drivers/net/wireless/ath/ath11k/ahb.c > @@ -807,10 +807,8 @@ static int ath11k_core_get_rproc(struct ath11k_base *ab) > } > > prproc = rproc_get_by_phandle(rproc_phandle); > - if (!prproc) { > - ath11k_dbg(ab, ATH11K_DBG_AHB, "failed to get rproc, deferring\n"); > - return -EPROBE_DEFER; > - } > + if (!prproc) > + return dev_err_probe(&ab->pdev->dev, -EPROBE_DEFER, "failed to get rproc\n"); I'd like to think this doesn't really change the behavior, but I'd rather see this that in-house print functions.. > ab_ahb->tgt_rproc = prproc; > > return 0; > @@ -1190,10 +1188,8 @@ static int ath11k_ahb_probe(struct platform_device *pdev) > ath11k_ahb_init_qmi_ce_config(ab); > > ret = ath11k_core_get_rproc(ab); > - if (ret) { > - ath11k_err(ab, "failed to get rproc: %d\n", ret); > + if (ret) > goto err_ce_free; > - } If the rproc handle is unavailable at this point, we undo quite a bit of work in .probe.. would it make sense to move this check way above? Konrad