mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Kent Overstreet <kent.overstreet@gmail.com>,
	linux-kernel@vger.kernel.org
Cc: Dave Hansen <dave.hansen@intel.com>,
	Matthew Wilcox <willy@infradead.org>,
	"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>
Subject: [PATCH] Generic radix tree: add kernel-doc chapter
Date: Mon, 10 Sep 2018 16:18:42 -0700	[thread overview]
Message-ID: <f02c9f2a-ca10-4485-e747-89d003a50ab2@infradead.org> (raw)
In-Reply-To: <20180907165635.8469-5-kent.overstreet@gmail.com>

From: Randy Dunlap <rdunlap@infradead.org>

Add a generic-radix-tree chapter to core-api kernel documentation.

Also fix a few kernel-doc warnings for misssing function (or macro)
parameters:

../include/linux/generic-radix-tree.h:93: warning: Function parameter or member '_radix' not described in 'genradix_free'
../include/linux/generic-radix-tree.h:161: warning: Function parameter or member '_idx' not described in 'genradix_iter_init'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Dave Hansen <dave.hansen@intel.com>
Cc: linux-doc@vger.kernel.org
---
 Documentation/core-api/generic-radix-tree.rst |   13 +++++++++++++
 Documentation/core-api/index.rst              |    1 +
 include/linux/generic-radix-tree.h            |   12 ++++++++----
 3 files changed, 22 insertions(+), 4 deletions(-)

--- /dev/null
+++ linux-next-20180910/Documentation/core-api/generic-radix-tree.rst
@@ -0,0 +1,13 @@
+
+=================================
+Generic radix trees/sparse arrays
+=================================
+
+.. kernel-doc:: include/linux/generic-radix-tree.h
+   :doc: Generic radix trees/sparse arrays
+
+generic radix tree functions
+----------------------------
+
+.. kernel-doc:: include/linux/generic-radix-tree.h
+   :functions:
--- linux-next-20180910.orig/Documentation/core-api/index.rst
+++ linux-next-20180910/Documentation/core-api/index.rst
@@ -27,6 +27,7 @@ Core utilities
    errseq
    printk-formats
    circular-buffers
+   generic-radix-tree
    mm-api
    gfp_mask-from-fs-io
    timekeeping
--- linux-next-20180910.orig/include/linux/generic-radix-tree.h
+++ linux-next-20180910/include/linux/generic-radix-tree.h
@@ -1,16 +1,18 @@
 #ifndef _LINUX_GENERIC_RADIX_TREE_H
 #define _LINUX_GENERIC_RADIX_TREE_H
 
-/*
- * Generic radix trees/sparse arrays:
+/**
+ * DOC: Generic radix trees/sparse arrays
  *
  * Very simple and minimalistic, supporting arbitrary size entries up to
  * PAGE_SIZE.
  *
  * A genradix is defined with the type it will store, like so:
+ *
  * static GENRADIX(struct foo) foo_genradix;
  *
  * The main operations are:
+ *
  * - genradix_init(radix) - initialize an empty genradix
  *
  * - genradix_free(radix) - free all memory owned by the genradix and
@@ -86,6 +88,7 @@ void __genradix_free(struct __genradix *
 
 /**
  * genradix_free: free all memory owned by a genradix
+ * @_radix: the genradix to free
  *
  * After freeing, @_radix will be reinitialized and empty
  */
@@ -130,7 +133,8 @@ void *__genradix_ptr(struct __genradix *
 void *__genradix_ptr_alloc(struct __genradix *, size_t, gfp_t);
 
 /**
- * genradix_ptr - get a pointer to a genradix entry, allocating it if necessary
+ * genradix_ptr_alloc - get a pointer to a genradix entry, allocating it
+ *			if necessary
  * @_radix:	genradix to access
  * @_idx:	index to fetch
  * @_gfp:	gfp mask
@@ -151,7 +155,7 @@ struct genradix_iter {
 /**
  * genradix_iter_init - initialize a genradix_iter
  * @_radix:	genradix that will be iterated over
- * @_idx	index to start iterating from
+ * @_idx:	index to start iterating from
  */
 #define genradix_iter_init(_radix, _idx)			\
 	((struct genradix_iter) {				\



  reply	other threads:[~2018-09-10 23:18 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-07 16:56 [PATCH 0/6] flex_arrays -> genradix; prep work for bcachefs Kent Overstreet
2018-09-07 16:56 ` [PATCH 1/6] openvswitch: convert to kvmalloc Kent Overstreet
2018-09-07 17:19   ` Matthew Wilcox
2018-09-07 16:56 ` [PATCH 2/6] md: " Kent Overstreet
2018-09-07 17:49   ` Matthew Wilcox
2018-09-07 18:16     ` Kent Overstreet
2018-09-07 16:56 ` [PATCH 3/6] selinux: " Kent Overstreet
2018-09-07 17:08   ` Tetsuo Handa
2018-09-07 17:50     ` Kent Overstreet
2018-09-13  2:27       ` Paul Moore
2018-09-07 16:56 ` [PATCH 4/6] Generic radix trees Kent Overstreet
2018-09-10 23:18   ` Randy Dunlap [this message]
2018-09-07 16:56 ` [PATCH 5/6] proc: commit to genradix Kent Overstreet
2018-09-07 16:56 ` [PATCH 6/6] Drop flex_arrays Kent Overstreet
2018-09-07 18:49   ` Randy Dunlap
2018-12-13 12:30   ` Xin Long
2018-12-13 14:41     ` Matthew Wilcox
2018-12-13 15:51       ` Neil Horman
2018-12-13 16:45         ` Matthew Wilcox
2018-12-13 18:09           ` Neil Horman
2018-12-17 12:50             ` Kent Overstreet
2018-12-18 12:19               ` Neil Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f02c9f2a-ca10-4485-e747-89d003a50ab2@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=dave.hansen@intel.com \
    --cc=kent.overstreet@gmail.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®