From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752295AbdFAQCQ (ORCPT ); Thu, 1 Jun 2017 12:02:16 -0400 Received: from mout.web.de ([212.227.15.14]:59855 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752540AbdFAQBb (ORCPT ); Thu, 1 Jun 2017 12:01:31 -0400 Subject: [PATCH 2/3] ARM: dmabounce: Delete an error message for a failed memory allocation in two functions From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, Alexander Duyck , Andrew Morton , Bart Van Assche , =?UTF-8?B?SsO2cmcgUsO2ZGVs?= , Krzysztof Kozlowski , Russell King , Vineet Gupta Cc: LKML , kernel-janitors@vger.kernel.org References: <697e7810-d280-08f3-2a24-026ff41e15a3@users.sourceforge.net> Message-ID: Date: Thu, 1 Jun 2017 18:00:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <697e7810-d280-08f3-2a24-026ff41e15a3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:YMKYbkSCcPf+viWzDP4U9dhTHLNxfn3Qe26vlCM8EyZLst8nIBm RqhT5neYGzq8tL0q12VGvsFiB0QZUv1WmQX0mz4pJAHPeYPGvCrmsT2ZAn7UJQ7BkrZqTMh Wx5/PBoyLBLW7MShaLftjFrFY0hWKvVmcp7TYwhHEMjmePZmSNJqsee6stEeCkup8OCVnsH 4IbN/hVqwEaGTeLWOf6jg== X-UI-Out-Filterresults: notjunk:1;V01:K0:ZhEbzX6bcUE=:mxZg7DouzMuBzVXD7n1iFy 95AHLhsLTqWAn5GwXf5wncxVAAch5pYVaW6Lv9DqDUnpt8gFJpelzfGGpb7kZiyqyxv2Ru/Kw 77XhGdfHybtjWQcdAgKrq5uEnwSPOF8HZ2G+EOBZ/jILfwEA50MHlEGaIMcwBx9+C+dREBYiY +X60lid7Yu8XuURwZnvj/VADI1KoNs3AnrZdfA3Q0g8l7Ac49V2xUdycyAHriOf1jcIS3EKpY 3N8ewTQsTcNxeAxxWQ8njYBW3W7FlYhItcaKBzxgbR3cEgfzlTObXbNtGfSiumXkm+MpzdxDJ ZwFLRZ3CoqBbpb34iTAJF7UN6NYymDJvnbJLLPHGHYtUKaO3UA9O83h0N15mnSJ9Wz5jy3hHT ++ZFHpybPmmrkoyY7LewM0oUisRMtgOA5sjdeAmPLkWkthQOoE8epUMfTfvx3m8kasqZWAPVH fUhDevkO4J00PsZDDNKdBwklL/YRgDY/GPbPx0+jfhfsnVA8BHhRFshNZtpq17lFeeV11ws+/ Hbj3CN5o9slcCxeEsUAxXDNKVRak5x+SNJigZHLu9hdN1jTVH7KP7r4X+wB9lXakVO7mfXGRv 6AXQFC/l5/QRckko6yS3igT1oFPbUrYF2+FCeNeUPwoTR4eJblBVVTyR1pnpHVnSUCbEGFP4t /NO7ugz5NaEGgEpM8wENcRrvXyrCx5orPmXY42bdbT9BjrdNfK053qUgfrHIaddX03faiZRhc /jYh4GoKeulCTGHsR2kI1R/Rr9cg6UmIf7iKZhGB9mhrNGE+ML3JmhqP4XhZ5QOxrdyMeXNYE l+/ZHb0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 1 Jun 2017 17:10:39 +0200 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- arch/arm/common/dmabounce.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/arch/arm/common/dmabounce.c b/arch/arm/common/dmabounce.c index fcdecb2de242..9ef7ab64b3d8 100644 --- a/arch/arm/common/dmabounce.c +++ b/arch/arm/common/dmabounce.c @@ -127,7 +127,5 @@ alloc_safe_buffer(struct dmabounce_device_info *device_info, void *ptr, - if (buf == NULL) { - dev_warn(dev, "%s: kmalloc failed\n", __func__); + if (!buf) return NULL; - } buf->ptr = ptr; buf->size = size; @@ -491,8 +489,5 @@ int dmabounce_register_dev(struct device *dev, unsigned long small_buffer_size, - if (!device_info) { - dev_err(dev, - "Could not allocated dmabounce_device_info\n"); + if (!device_info) return -ENOMEM; - } ret = dmabounce_init_pool(&device_info->small, dev, "small_dmabounce_pool", small_buffer_size); -- 2.13.0