From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2915838BF74 for ; Mon, 16 Mar 2026 10:48:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658094; cv=none; b=eafu3XII3tZLU320cyHxUBY4Xh3+0O8xUZeFYYd2paaGK18P9sNd3zz0sw43L3fx7S3l2FCd9gzXE+//sEf/wvdELJl2XYzTParuJH+L+zIbRbPixlDoRnMeOx29LsGksZ8vUNl671UbS3PHSO8WAK23VyvG59UilqH5U5dfiUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773658094; c=relaxed/simple; bh=RvKLcKkFi38KdIwPbZcxye0llCWFTvcL/SQDV4UaCb4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZsEnpRsdNrcjTcNxgivc6KCzk7L4KkyjAmnSQpIxEcofzzUEJmxTsW6CCfXJL3ofznYY26kQZk1mrzmbsIcVFFiEXY3gFidGPNAvow7jdmmammNCh1JL3x61H1m9TNeXbAspxg8AI5we8JK9zWVtpm2w0xlNe7nXjVommtzN4wI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=Gaj1RaG+; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="Gaj1RaG+" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-48540d21f7dso52042515e9.0 for ; Mon, 16 Mar 2026 03:48:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1773658089; x=1774262889; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=COAVljU9VJ7FLI0cTY3WOLojAyLOilMuqo6ThWcTiZA=; b=Gaj1RaG+WOoqtud/+UB/fubOZjPECaJ/7hVuIMW96A9o1G5f6Yq0/IfNVWFabxETpp 2A01acbmpW4X0Wbuejy5TGLqshTXET9/arwqvO5Lcs5dt1KAxG/kImrQaj/EOckkL+Sw Wi/xXdmbD68B1R6n+UTinlvXonRmJyLI9Pj8z7XCxuOdPa3mLZrSEZ4wmCtVTgXtyfEl KyLnB+p3ydnfiNP41j1kYp7aE5TulW3dWso80oMpc+iYnxxUEBPJ2Ra1jhJ9LM31pYcO KCsNTFik5i1gieAUfDehCP7K0HA42p7lIfZ7Xtkv88epr97ObFXFQFvR+vUwkubocui9 lAuA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773658089; x=1774262889; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=COAVljU9VJ7FLI0cTY3WOLojAyLOilMuqo6ThWcTiZA=; b=EAPdpuG6ikqidP7n7CwYircZTVKDJFdY7LpVsHevQ/xxGLGseI08P/eGoFECiKmsvY UqFeOy7oMbTsDOUXwfZal6MDRwLNQtBfjd0fCkda9txBFLXWMzvKMi7cVSq4ha+Vo1bz ESD2K9bmL5N0XlywNixZdXDjDttmAkCI+GmmCrIcBph5uIH6lVVoyv4SgOnNo7f9P6zQ kprp02qPOo+8UXDsfdW6A6w0q9n0/M0d7noEfyLCxnghfiqlPhFcUM2AeTjV4oquy6UA ORiwqKonOD0HwjtY6rjSAp5aWckeyoUDFu36lNIJ7F30B/QPqkFLqNDz9PxdwXyl7fv7 dZug== X-Forwarded-Encrypted: i=1; AJvYcCUqx98hj9pbt37y4cViK2Kth2bcRkgb16z85h+RJyw5OJobjJwKFncGFZKBalL9sN1dYuh+/RLg0hlZUyo=@vger.kernel.org X-Gm-Message-State: AOJu0Yxk/c6ar1Q4g/2pT5FDUu5RRBn9O+/SoE9JUKMObNEzLjKdHMnH YSwcZQ4N2qM8HWysgZrk97wFk37EHzZBloglc/A31WR3ubMtUmCiCMddObrkJAvvJ/c= X-Gm-Gg: ATEYQzzEOdeYZkDDMf5HlBxb+/Qo8g0zaTUJ8IVzlSTXu9y3Valhthc6m4Znw58fKuf 3XOXjOvwCUEes8+9+VSXkq//V6T/Qa2DnhKgDinUDPS+mXMvghdFyjNbaXzTeU5M2yW8BqCXCpO uPc5gF69kyCiX9iRvZQE7azPNoF4Z9KocQx+tD4BbCte1fMSx0cSsw+tYqxy8Ju89iteb5xXicD cRYhqjguQdYbOn/Ra96zdoNa2ubwkM5VGQiGOfEIhaZlSJ5zeuYT/0t0OAZcWtaRz3/7s1II4XK ipyu82Rg/pjcxx5JPejJNv7J2YzC6Yc3RnY0P0oMnEWuUTw7TWhsXxalqpm1RDpcfTefWOyIhO5 lyj4lhr/6z7VvQhHPIJ2Ds9oxsKx5HmceeFvlEIN1Y6fbbLIWHSmmwjgNcUVWSED/nUHtpW8m+j wFW7aUdARgfK+WVbS5Q8vFGT0D9byKuOgpyz3HzGoqq4h3 X-Received: by 2002:a05:600c:3b14:b0:485:3aa1:a7f0 with SMTP id 5b1f17b1804b1-485566cfbadmr214165865e9.4.1773658089472; Mon, 16 Mar 2026 03:48:09 -0700 (PDT) Received: from [10.100.51.209] (nat2.prg.suse.com. [195.250.132.146]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48556395df4sm86533895e9.0.2026.03.16.03.48.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Mar 2026 03:48:09 -0700 (PDT) Message-ID: Date: Mon, 16 Mar 2026 11:48:07 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] module: remove MODULE_VERSION() To: Greg Kroah-Hartman Cc: linux-modules@vger.kernel.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Shyam Saini , Kees Cook , Thorsten Blum , Christoph Hellwig References: <2026031341-evolve-repeater-987b@gregkh> <2026031303-prelaunch-creation-3fce@gregkh> Content-Language: en-US From: Petr Pavlu In-Reply-To: <2026031303-prelaunch-creation-3fce@gregkh> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/13/26 4:46 PM, Greg Kroah-Hartman wrote: > On Fri, Mar 13, 2026 at 03:20:42PM +0100, Greg Kroah-Hartman wrote: >> Module "versions" do not make sense as the kernel is built all at once, >> the "version" is the overall kernel version number, so modules can not >> really be described as having a unique version given that they rely on >> the infrastructure of the whole kernel. >> >> For now, just make this an "empty" define, to keep existing code >> building properly as the tree is slowly purged of the use of this over >> time. >> >> This macro will be removed entirely in the future when there are no >> in-tree users. >> >> Cc: Luis Chamberlain >> Cc: Petr Pavlu >> Cc: Daniel Gomez >> Cc: Sami Tolvanen >> Cc: Aaron Tomlin >> Cc: Shyam Saini >> Cc: Kees Cook >> Cc: Thorsten Blum >> Cc: Christoph Hellwig >> Signed-off-by: Greg Kroah-Hartman >> --- >> include/linux/module.h | 56 +++++++++--------------------------------- >> kernel/params.c | 30 ---------------------- >> 2 files changed, 11 insertions(+), 75 deletions(-) > > > Sami just pointed out to me off-list that maybe I should also drop the > srcversion stuff too. I'll gladly do that too, does anyone know if > anyone even uses that anymore? Despite its name, I believe srcversion is primarily used to identify binaries. Nowadays, modules contain build IDs, which is a standard mechanism for this. The information is available already via /sys/module//notes/.note.gnu.build-id, so removing the srcversion data makes sense to me. -- Thanks, Petr