mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@kernel.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	linux-serial@vger.kernel.org,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Kunihiko Hayashi" <hayashi.kunihiko@socionext.com>,
	"Masami Hiramatsu" <mhiramat@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: Niklas Schnelle <schnelle@linux.ibm.com>
Subject: Re: [PATCH v3 1/6] serial: 8250: Change dl_read/write to handle value as u32
Date: Wed, 10 May 2023 07:47:48 +0200	[thread overview]
Message-ID: <f03cd481-c5ee-2561-ea0a-b1ce5d039631@kernel.org> (raw)
In-Reply-To: <20230509113924.19540-2-ilpo.jarvinen@linux.intel.com>

On 09. 05. 23, 13:39, Ilpo Järvinen wrote:
> Divisor latch read/write functions currently handle the value is int.

*as* int?

> As the value is related to HW context, u32 makes much more sense than a
> signed type.
> 
> While at it, name the parameters in the callback signature.
...
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
...
> @@ -847,7 +847,7 @@ static void disable_rsa(struct uart_8250_port *up)
>   static int size_fifo(struct uart_8250_port *up)
>   {
>   	unsigned char old_fcr, old_mcr, old_lcr;
> -	unsigned short old_dl;
> +	unsigned int old_dl;

I am missing the context, but why not u32 here?

thanks,
-- 
js
suse labs


  reply	other threads:[~2023-05-10  5:47 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-09 11:39 [PATCH v3 0/6] serial: Separate RT288x/Au1xxx code into own file Ilpo Järvinen
2023-05-09 11:39 ` [PATCH v3 1/6] serial: 8250: Change dl_read/write to handle value as u32 Ilpo Järvinen
2023-05-10  5:47   ` Jiri Slaby [this message]
2023-05-09 11:39 ` [PATCH v3 2/6] serial: 8250: Document uart_8250_port's ->dl_read/write() Ilpo Järvinen
2023-05-09 11:39 ` [PATCH v3 3/6] serial: 8250: Add dl_read/write, bugs and mapsize into plat_serial8250_port Ilpo Järvinen
2023-05-10  5:55   ` Jiri Slaby
2023-05-09 11:39 ` [PATCH v3 4/6] serial: 8250: RT288x/Au1xxx code away from core Ilpo Järvinen
2023-05-09 11:39 ` [PATCH v3 5/6] serial: 8250_rt288x: Name non-standard divisor latch reg Ilpo Järvinen
2023-05-09 11:39 ` [PATCH v3 6/6] serial: 8250_rt288x: Remove unnecessary UART_REG_UNMAPPED Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f03cd481-c5ee-2561-ea0a-b1ce5d039631@kernel.org \
    --to=jirislaby@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hayashi.kunihiko@socionext.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mhiramat@kernel.org \
    --cc=philmd@linaro.org \
    --cc=schnelle@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®