mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: Gwendal Grignou <gwendal@chromium.org>,
	bleung@chromium.org, groeck@chromium.org, lee.jones@linaro.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 24/30] mfd: cros_ec: Update I2S API
Date: Thu, 25 Apr 2019 10:50:06 +0200	[thread overview]
Message-ID: <f04768c8-c87c-a076-c279-e6de63fd41e3@collabora.com> (raw)
In-Reply-To: <20190424232918.243308-25-gwendal@chromium.org>

Hi Gwendal,

On 25/4/19 1:29, Gwendal Grignou wrote:
> Improve I2S API.
> 
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> ---
>  include/linux/mfd/cros_ec_commands.h | 44 +++++++++++++---------------
>  1 file changed, 20 insertions(+), 24 deletions(-)
> 

[snip]

>  
> -/*
> - * For subcommand EC_CODEC_GET_GAIN.
> - */
> -struct ec_response_codec_gain {
> -	uint8_t left;
> -	uint8_t right;
> -} __ec_align1;

You should probably also update sound/soc/codecs/cros_ec_codec.c to the new
struct name in this patch, otherwise we'll get a compiler error.


>  
>  /*****************************************************************************/
>  /* System commands */
> 

Thanks,
 Enric

  reply	other threads:[~2019-04-25  8:50 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-24 23:28 [PATCH 00/30] Update cros_ec_commands.h Gwendal Grignou
2019-04-24 23:28 ` [PATCH 01/30] mfd: cros_ec: Update license term Gwendal Grignou
2019-04-24 23:28 ` [PATCH 02/30] mfd: cros_ec: Zero BUILD_ macro Gwendal Grignou
2019-04-24 23:28 ` [PATCH 03/30] mfd: cros_ec: set comments properly Gwendal Grignou
2019-04-24 23:28 ` [PATCH 04/30] mfd: cros_ec: add ec_align macros Gwendal Grignou
2019-04-24 23:28 ` [PATCH 05/30] mfd: cros_ec: Define commands as 4-digit UPPER CASE hex values Gwendal Grignou
2019-04-24 23:28 ` [PATCH 06/30] mfd: cros_ec: use BIT macro Gwendal Grignou
2019-04-24 23:28 ` [PATCH 07/30] mfd: cros_ec: Update ACPI interface definition Gwendal Grignou
2019-04-24 23:28 ` [PATCH 08/30] mfd: cros_ec: move HDMI CEC API definition Gwendal Grignou
2019-04-24 23:28 ` [PATCH 09/30] mfd: cros_ec: Remove zero-size structs Gwendal Grignou
2019-04-24 23:28 ` [PATCH 10/30] mfd: cros_ec: Add Flash V2 commands API Gwendal Grignou
2019-04-24 23:28 ` [PATCH 11/30] mfd: cros_ec: Add PWM_SET_DUTY API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 12/30] mfd: cros_ec: Add lightbar v2 API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 13/30] mfd: cros_ec: Expand hash API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 14/30] mfd: cros_ec: Add EC transport protocol v4 Gwendal Grignou
2019-04-24 23:29 ` [PATCH 15/30] mfd: cros_ec: Complete MEMS sensor API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 16/30] mfd: cros_ec: Fix event processing API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 17/30] mfd: cros_ec: Add fingerprint API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 18/30] mfd: cros_ec: Fix temperature API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 19/30] mfd: cros_ec: Complete Power and USB PD API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 20/30] mfd: cros_ec: Add API for keyboard testing Gwendal Grignou
2019-04-24 23:29 ` [PATCH 21/30] mfd: cros_ec: Add Hibernate API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 22/30] mfd: cros_ec: Add Smart Battery Firmware update API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 23/30] mfd: cros_ec: Add I2C passthru protection API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 24/30] mfd: cros_ec: Update I2S API Gwendal Grignou
2019-04-25  8:50   ` Enric Balletbo i Serra [this message]
2019-04-24 23:29 ` [PATCH 25/30] mfd: cros_ec: Add API for EC-EC communication Gwendal Grignou
2019-04-24 23:29 ` [PATCH 26/30] mfd: cros_ec: Add API for Touchpad support Gwendal Grignou
2019-04-24 23:29 ` [PATCH 27/30] mfd: cros_ec: Add API for Fingerprint support Gwendal Grignou
2019-04-24 23:29 ` [PATCH 28/30] mfd: cros_ec: Add API for rwsig Gwendal Grignou
2019-04-24 23:29 ` [PATCH 29/30] mfd: cros_ec: Add SKU ID and Secure storage API Gwendal Grignou
2019-04-24 23:29 ` [PATCH 30/30] mfd: cros_ec: Add Management API entry points Gwendal Grignou
2019-04-25  8:12 ` [PATCH 00/30] Update cros_ec_commands.h Lee Jones
2019-04-25 11:19   ` Enric Balletbo i Serra
2019-04-25 16:00     ` Gwendal Grignou
2019-04-25 16:11       ` Enric Balletbo i Serra
2019-04-25 16:38         ` Gwendal Grignou
2019-04-25 17:40           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f04768c8-c87c-a076-c279-e6de63fd41e3@collabora.com \
    --to=enric.balletbo@collabora.com \
    --cc=bleung@chromium.org \
    --cc=groeck@chromium.org \
    --cc=gwendal@chromium.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome