From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964989AbcJ1Jcx (ORCPT ); Fri, 28 Oct 2016 05:32:53 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33192 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934978AbcJ1Jcv (ORCPT ); Fri, 28 Oct 2016 05:32:51 -0400 Subject: Re: [PATCH] kvm/x86: Show WRMSR data is in hex To: Borislav Petkov , KVM References: <20161027181445.25319-1-bp@alien8.de> Cc: LKML , =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= From: Paolo Bonzini Message-ID: Date: Fri, 28 Oct 2016 11:32:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161027181445.25319-1-bp@alien8.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/10/2016 20:14, Borislav Petkov wrote: > From: Borislav Petkov > > Add the "0x" prefix to the error messages format to make it unambiguous > about what kind of value we're talking about. > > Signed-off-by: Borislav Petkov > Cc: Paolo Bonzini > Cc: "Radim Krčmář" > --- > arch/x86/kvm/x86.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 7f9fa2d8f4e4..46cd7870d751 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -2262,7 +2262,7 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > /* Drop writes to this legacy MSR -- see rdmsr > * counterpart for further detail. > */ > - vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data %llx\n", msr, data); > + vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data 0x%llx\n", msr, data); > break; > case MSR_AMD64_OSVW_ID_LENGTH: > if (!guest_cpuid_has_osvw(vcpu)) > @@ -2280,11 +2280,11 @@ int kvm_set_msr_common(struct kvm_vcpu *vcpu, struct msr_data *msr_info) > if (kvm_pmu_is_valid_msr(vcpu, msr)) > return kvm_pmu_set_msr(vcpu, msr_info); > if (!ignore_msrs) { > - vcpu_unimpl(vcpu, "unhandled wrmsr: 0x%x data %llx\n", > + vcpu_unimpl(vcpu, "unhandled wrmsr: 0x%x data 0x%llx\n", > msr, data); > return 1; > } else { > - vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data %llx\n", > + vcpu_unimpl(vcpu, "ignored wrmsr: 0x%x data 0x%llx\n", > msr, data); > break; > } > Applied to kvm/master, thanks. Paolo