From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752114AbdGGLDL (ORCPT ); Fri, 7 Jul 2017 07:03:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31553 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034AbdGGLDK (ORCPT ); Fri, 7 Jul 2017 07:03:10 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 907247CE06 Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx04.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 907247CE06 Subject: Re: [PATCH] platform/x86: silead_dmi: Add touchscreen info for I.T.Works TW891 2-in-1 To: Darren Hart Cc: Andy Shevchenko , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170701101522.13646-1-hdegoede@redhat.com> <20170706223915.GA19728@fury> From: Hans de Goede Message-ID: Date: Fri, 7 Jul 2017 13:03:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170706223915.GA19728@fury> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.28]); Fri, 07 Jul 2017 11:03:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 07-07-17 00:39, Darren Hart wrote: > On Sat, Jul 01, 2017 at 12:15:22PM +0200, Hans de Goede wrote: >> Add touchscreen info for I.T.Works TW891 2-in-1. >> > > ... > >> + /* I.T.Works TW891 */ >> + .driver_data = (void *)&itworks_tw891_data, >> + .matches = { >> + DMI_MATCH(DMI_SYS_VENDOR, "To be filled by O.E.M."), > > *groan* you're trolling me now right? ;-) Nope, sorry, this seemed better then matching on a single string. FWIW I did an internet search for TW891 and there are no other devices named TW891. >> + DMI_MATCH(DMI_PRODUCT_NAME, "TW891"), > > I presume there are no other identifying strings? Correct if there was something better I would have used it. > Pushed to testing. Thank you. Regards, Hans