From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11749190075 for ; Mon, 30 Sep 2024 14:00:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727704856; cv=none; b=Wva+An3PCDSrNAy0nCzQIA3XmqCG/HbtZEYyxbJn+cEUYQgQXEC9juVKXwRJgHTUTChoI8+Qd0PKA5quOcSKvPrdSep7iFnTH1IpmthzpmF8jeeCOSEdUWpJmCDJDKQNUyrdZomD1xd0cKYQyFfoHIaihrmLV541KYMU61ZWvfw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727704856; c=relaxed/simple; bh=dPR/MK3GE8NMOYtuwtlYVjIQEgLz8dluF1iNQdnetFQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=r9OXF8ljA+HlcEd1idwfOOVBvgvwW0sFkBqGd8F/eZ6IjMWgAmEJJq4sW2RwVf3G7RFNChFfQ8woIuCgG69Fv0Xhb60OxHGuFR84lKMJxT48n07c1Y36SomQvffAT0ofAzTZt82ITcjJAZcdAdH+pk3Zlx3pRYlc+rhgrM6xC9A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=GQxk+AtD; arc=none smtp.client-ip=209.85.218.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="GQxk+AtD" Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a8d60e23b33so666168366b.0 for ; Mon, 30 Sep 2024 07:00:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1727704853; x=1728309653; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=B9iC2N/12abllbC0V03F2t6+J5vMpvZXd0nYPLT3vBQ=; b=GQxk+AtDRzVwE4BSso2inG1NN6dn7yuWJP4MGZ8T2Hr72INxz6r2wJsqB03HvZCLuA sIUxsGRMofzr7hyMBOsERKCgsFNA2qu/L1hrPCo+SE8GcM18gzHpvoMzSpeNcbU0+ekM ysityzc3HzLU97n1LsD4Z8J/e/1CSjG30V6rJsx4C1x59ykyrdF4SgnyGVFiL8mg7BKg IujqOfstxZM/sD7wOa8l/LcOc9+GtR8/cfjKl1XBXJ/4MAYcxOgHig6cGWt9Dmlq/0qp DZj8AU6KCXuBVg5aWrab2Awtq+rQDNfSZa8JFK+J+PPPcwcj4vBN1DDFXHBZJmtTRZID YPgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727704853; x=1728309653; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=B9iC2N/12abllbC0V03F2t6+J5vMpvZXd0nYPLT3vBQ=; b=C9Yrq+eWRDFzCaDXunSwqoEpx/jCEcITS1n6lEanjGT9xH1W/tmoNZgVPUVuMHycr1 ABA8WLxhRn8NMySblryUN+ndJVQtxrkTySCoOhd46niaM4elh4fuwVmxnWoqffoj4bVI lJeNoVuPFWS/ujMqJOnm5XrQVsIwYgw7rPi7vu2tggMlXrRNwH3yFBKavGOjDXL16Ggw bjO6ph+yz1X0zO1XNwS9G5JwXfFmfq3qag8clDssntkdl+gHRg8ihSfBV6eR6FegPsxw KyLTotYiEx1rYuyo7GP62+/dC5DGmTmLIEcGCRDbdXDJxTJugRQYPyHTKJSq647p+KV8 NZAw== X-Forwarded-Encrypted: i=1; AJvYcCVxdUUdmXkolUq6SgRveyA4Iz9yojnTKABfajmUbbcgB8vsn+DAfD2IYsJcaZMAOHC7rvE12wxHksXdkBY=@vger.kernel.org X-Gm-Message-State: AOJu0Yz/F3CUDjaKh9fPIbRLqJvW/zVb4aHJ+h8y8D3qitO58usdjOuG CIS3o/0UtXNs40RXtYEUZwznV30PSKZQp0N+i8TKuisR6nyZ98cH6e7bNKT3JXE= X-Google-Smtp-Source: AGHT+IHrW1k6OyoeAr7X2J4sCHCj9NzoUl8sq6E2Ub0OP+VdkpEDGrA+mzsk7GWeJcQA5FmXlP3tnw== X-Received: by 2002:a17:906:c104:b0:a86:b762:52ec with SMTP id a640c23a62f3a-a93c4adf8ebmr1289043666b.51.1727704853182; Mon, 30 Sep 2024 07:00:53 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a93c297bceesm532099966b.187.2024.09.30.07.00.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 07:00:51 -0700 (PDT) Date: Mon, 30 Sep 2024 17:00:46 +0300 From: Dan Carpenter To: Andy Walls , Julia Lawall Cc: Hans Verkuil , Laurent Pinchart , Ricardo Ribalda , Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans de Goede , Andy Shevchenko , Mike Isely , Olli Salonen , Maxim Levitsky , Sean Young , Sergey Kozlov , Abylay Ospan , Jemma Denson , Patrick Boettcher , Ming Qian , Zhou Peng , Michal Simek , Jean-Christophe Trotin , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Eddie James , Joel Stanley , Andrew Jeffery , Hans Verkuil , Tomasz Figa , Marek Szyprowski , Tim Harvey , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Niklas =?iso-8859-1?Q?S=F6derlund?= , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org Subject: Re: [PATCH 00/45] media: Use string_choice helpers Message-ID: References: <20240930-cocci-opportunity-v1-0-81e137456ce0@chromium.org> <20240930122157.GF31662@pendragon.ideasonboard.com> <4873f3a0-bd82-4ace-a783-10ea137284d6@xs4all.nl> <7D358236-19F8-4F94-89A0-F379F193971F@md.metrocast.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7D358236-19F8-4F94-89A0-F379F193971F@md.metrocast.net> On Mon, Sep 30, 2024 at 08:57:44AM -0400, Andy Walls wrote: > No human being really code reviews sweeping editorial change like these thoroughly. I wonder if there is some way to verify that people are actually running the Coccinelle script that they say they are without doing anything extra on the side. I use a script to filter out mechanical changes. https://github.com/error27/rename_rev It's kind of a pain in the butt to review something like this. The command would be something like: rename_rev.pl -e 's/(.*?,|^\W+)(.*) \? "enabled" : "disabled"/$1str_enabled_disabled($2)/' -e 's/(.*?,|^\W+)(.*) \? "enable" : "disable"/$1str_enable_disable($2)/' -e 's/(.*,|^\W+)(.*) \? "low" : "high"/$1str_low_high($2)/' -e 's/(.*,|^\W+)(.*) \? "on" : "off"/$1str_on_off($2)/' -e 's/(.*,|^\W+)(.*) \? "true" : "false"/$1str_true_false($2)/' -e 's/(.*,|^\W+)(.*) \? "high" : "low"/$1str_high_low($2)/' -e 's/(.*,|^\W+)(.*) \? "read" : "write"/$1str_read_write($2)/' For every email in the series there was another new str_foo_bar() function so the command line kept getting longer and longer. It doesn't work perfectly, but it's often good enough so I can spot the interesting bits. regards, dan carpenter