From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939646AbdD0TsT (ORCPT ); Thu, 27 Apr 2017 15:48:19 -0400 Received: from mout.web.de ([212.227.15.4]:61170 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939018AbdD0TsJ (ORCPT ); Thu, 27 Apr 2017 15:48:09 -0400 Subject: [PATCH 2/2] of_coresight: Use devm_kcalloc() in of_coresight_alloc_memory() From: SF Markus Elfring To: linux-arm-kernel@lists.infradead.org, Chunyan Zhang , Mathieu Poirier , Mike Leach , Pratik Patel , "Suzuki K. Poulose" Cc: LKML , kernel-janitors@vger.kernel.org References: <52619d05-65c4-149d-f355-cf9c037a0c9b@users.sourceforge.net> Message-ID: Date: Thu, 27 Apr 2017 21:47:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.0.1 MIME-Version: 1.0 In-Reply-To: <52619d05-65c4-149d-f355-cf9c037a0c9b@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:genPIYDBocqoCs7JkiujaToiLIx0ufbwtCCr4X9Vfi96HAFIpdA aBXdoEgbdhrJAwftPQQ5GKEU/+MHz3YSwnhM/4RGbgnfEyEIplBBXjlWo8Ax55oyD+iTq2C aF6FBtqgO1wqz7P2RvU4dyepVqwzIOwV4uxi2PlMDds/9KsRLRtQLuDebdYfB+1DxVCmG4l zqYA4oTyULnr3ey8zNBVg== X-UI-Out-Filterresults: notjunk:1;V01:K0:bfGPa+Cjmm4=:N1wbgyp95a2MePjHWF+D0B 1EFpC+Lo7A8fXw9xYIW4d+C/VYpFK10JDf5qDDbWUMYUgVZpJHavKoDzCJpGcnrs4ZvuRdAd4 oagtpHnWzu5uqO2qvwKroTU+q+PsxSzOnQGsHzXXU3qwzvoy1d7a9S1w/UzAUfU5EJ9z4qDNF R5jAELqh3Fv3SKi9rjYcJ/MYgs78urY2D47lfC7ku81obo8XJlcC4S37dm4D+YGqGRFdZ6+2G L75KfDgFabDumi9Y5vX0aqomZJgHpEvtRb9QWGY9qvqfeykq9l7DRtH0pKdDNAVb7MzNV6aaC 55iTSTeZ8SWL4oa3suCMrBr/vZtGaQkgj2d3afq+T2IL1iUxo2E0d6hLlw02Gt9nkVQcDrFUk irSEnPVqs4PdN2IGDB+sPkPQGQ80n5PlGqgX4TGAUiZ9FoxC62DAwXYdptUibRhsxRLAe4rEi 3Rb/NfFIEInMcqO8nFNdegYHTOhpoI2cVqqbdaGzWBVAXoH/GggTNbCeQi0oYBoB9mtRtLeen wDaYjnV3xR4xx6qhjojYhbMGto9xG6Wz9Ghfa8+OxHlvgeblbC97Rb3NCSsv3pe2tBpNUiDr8 ci+6AWJ83VQKJjZZ7xW+oTHyW/WGuMvWEPLFC0QY0PcNyMIMdW1an3e6W5LgYSvjxywyKGB8Z bPJuYW/wrGE87CW/CpJ2hy+c+PYwYOPlzrlRp856D5FQGqYXxPkb3Jd7D24JBO4E9sPXSpOm/ ilv8jKTvtLFR6RL2uOuggpiU0pqSCCL66K1QNVBY8JAZW8Xno86kcJcRVqo7MoUAoB6e6QP01 C3flcf6 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 27 Apr 2017 21:29:12 +0200 Multiplications for the size determination of memory allocations indicated that array data structures should be processed. Thus use the corresponding function "devm_kcalloc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/hwtracing/coresight/of_coresight.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/hwtracing/coresight/of_coresight.c b/drivers/hwtracing/coresight/of_coresight.c index 09142e99e915..1e622912cd0f 100644 --- a/drivers/hwtracing/coresight/of_coresight.c +++ b/drivers/hwtracing/coresight/of_coresight.c @@ -78,21 +78,21 @@ static int of_coresight_alloc_memory(struct device *dev, struct coresight_platform_data *pdata) { /* List of output port on this component */ - pdata->outports = devm_kzalloc(dev, pdata->nr_outport * + pdata->outports = devm_kcalloc(dev, pdata->nr_outport, sizeof(*pdata->outports), GFP_KERNEL); if (!pdata->outports) return -ENOMEM; /* Children connected to this component via @outports */ - pdata->child_names = devm_kzalloc(dev, pdata->nr_outport * + pdata->child_names = devm_kcalloc(dev, pdata->nr_outport, sizeof(*pdata->child_names), GFP_KERNEL); if (!pdata->child_names) return -ENOMEM; /* Port number on the child this component is connected to */ - pdata->child_ports = devm_kzalloc(dev, pdata->nr_outport * + pdata->child_ports = devm_kcalloc(dev, pdata->nr_outport, sizeof(*pdata->child_ports), GFP_KERNEL); if (!pdata->child_ports) -- 2.12.2