From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F0019C282CE for ; Wed, 22 May 2019 12:30:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C558B217F9 for ; Wed, 22 May 2019 12:30:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="g96lwHJ1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729335AbfEVMaV (ORCPT ); Wed, 22 May 2019 08:30:21 -0400 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51683 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728744AbfEVMaU (ORCPT ); Wed, 22 May 2019 08:30:20 -0400 Received: by mail-wm1-f67.google.com with SMTP id c77so2052750wmd.1 for ; Wed, 22 May 2019 05:30:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=bWFk7Dku220BSIRMzb9u9QC4G1aGkz5eeVURI5VAO6k=; b=g96lwHJ1ode6GDHOpCNuIGXm9CyJMyL30+7sF/XHZsGNh83VKrt4oHQElsVQcq3Px6 BOLZCXg2OkSQeBvD3hxSeV4p2mhTpmNUGC5+Hk9dDKEZ2kCwnFtdO3vkgr14OreE2lST el4z4ZbLjBnZDmCh9cbIxr5CVw4rtQtIgsScMOQB7jjEHWklwSnumvckNFx9JoklMZdT Pagwhsw3cJsXOGpV22J+QEU5RyEKqs5w/+Nmh5uFkwv9vQ5LGI2FSuj3qYd/u0u6rlVC 9YVaMPU1e9ul/YO63BYEVxcUJFXVRQjaOAlw1VdSX/bIM/KVJjpW9PCFv7aHz6XbHE2Z EysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=bWFk7Dku220BSIRMzb9u9QC4G1aGkz5eeVURI5VAO6k=; b=ZAWhEp6zLS8LDZXyQ2HO1vV8tePlz80qmzqBMNTtoIi9vZ2e4wUL5/8v1ix8vX0T4B hMxCZLCbz4OkjLxOiVUdMjNSgseyQuiG+aOtAxT9Y3BhJK1S52j5mcY+7IN5ejDVdlaX NgkYLEnklj80QHJUnFiLiVhywjpnjqxWmlGIx5Ayaeetzfs0UU42gSBAuNRx3teXrCLw GSKF7XozdNp/c01ngGr5RoUsFZe9yCp44jhzi7oe25jH11LJhTzukb/yEgyO/X94P+/B xLgELa9uLDpA4sb1iGXJqsZ10T+hu0IydlsBWXyuhuF8LO19c8wydTIUXt5ctHDKhrCR g0VQ== X-Gm-Message-State: APjAAAWg7sBP4P86b589zvqesn5EVPInmivjGoPER2HWbYG212L1Hed8 KBl2JDd8zjUfy0nw6RAojCcfqw== X-Google-Smtp-Source: APXvYqwcEWVPtTAR2IKfdlPTMN56ztuBh3i4KBntxk3eiRbthNztynbpp3p0eM5amjYVUHiszLA3qQ== X-Received: by 2002:a1c:eb18:: with SMTP id j24mr7077335wmh.32.1558528218123; Wed, 22 May 2019 05:30:18 -0700 (PDT) Received: from [10.1.203.87] (nat-wifi.sssup.it. [193.205.81.22]) by smtp.googlemail.com with ESMTPSA id y4sm3952952wmj.20.2019.05.22.05.30.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 22 May 2019 05:30:17 -0700 (PDT) Subject: Re: [PATCH v3 1/3] thermal: rockchip: fix up the tsadc pinctrl setting error To: Heiko Stuebner , Enric Balletbo Serra Cc: Elaine Zhang , Mark Rutland , "devicetree@vger.kernel.org" , huangtao@rock-chips.com, Linux PM list , xxx@rock-chips.com, xf@rock-chips.com, linux-kernel , Eduardo Valentin , "open list:ARM/Rockchip SoC..." , Rob Herring , Zhang Rui , Linux ARM , Doug Anderson , vicencb@gmail.com References: <1556618986-18923-1-git-send-email-zhangqing@rock-chips.com> <785392a0-282a-1e51-a4d6-a6d5ca478949@linaro.org> <2174314.1vfUlvne1O@phil> From: Daniel Lezcano Message-ID: Date: Wed, 22 May 2019 14:30:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <2174314.1vfUlvne1O@phil> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/05/2019 14:27, Heiko Stuebner wrote: [ ... ] >> As this change is now in mainline and is causing veyron to hang I'd >> suggest reverting this change for now. Even fixing the root cause >> (maybe the one I pointed above) after this patch we will have the >> thermal driver to fail because "gpio" and "otpout" states are not >> defined nor documented (a change on this will need some reviews and >> acks and time I guess). > > I definitly agree here. Handling + checking the binding change > as well as needed fallback code is definitly not material for -rc-kernels > so we should just revert for now and let Elaine fix the issues for 5.3. > > Anyone volunteering for sending a revert-patch to Eduardo? :-) I can't right now :/ -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog