From: Dragan Simic <dsimic@manjaro.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
heiko@sntech.de, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] docs: dt-bindings: Specify ordering for properties within groups
Date: Wed, 05 Mar 2025 10:53:48 +0100 [thread overview]
Message-ID: <f05919742c34f5d4489d2cd711c7736f@manjaro.org> (raw)
In-Reply-To: <166a7b77-74e3-40b7-a536-ee56850d9318@kernel.org>
Hello Krzysztof,
On 2025-03-05 10:36, Krzysztof Kozlowski wrote:
> On 05/03/2025 09:45, Dragan Simic wrote:
>>
>> diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst
>> b/Documentation/devicetree/bindings/dts-coding-style.rst
>> index 8a68331075a0..15de3ede2d9c 100644
>> --- a/Documentation/devicetree/bindings/dts-coding-style.rst
>> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
>> @@ -133,6 +133,12 @@ The above-described ordering follows this
>> approach:
>> 3. Status is the last information to annotate that device node is or
>> is not
>> finished (board resources are needed).
>>
>> +The above-described ordering specifies the preferred ordering of
>> property
>> +groups, while the individual properties inside each group shall use
>> natural
>> +sort order by the property name. More specifically, natural sort
>> order shall
>> +apply to multi-digit numbers found inside the property names, while
>> alpha-
>> +numerical ordering shall apply otherwise.
>
> The last sentence was not here and I don't get the point. Natural sort
> order should be always preferred over alpha-numerical for properties.
> About which other case ("...apply otherwise.") are you thinking?
Yes, I added that sentence in the v2 to, hopefully, clarify the natural
sort order itself a bit. I've researched the natural sort order a bit
further, and it technically applies only to the multi-digit numbers
found
inside the sorted strings. That's what I wanted to explain, and "shall
apply otherwise" refers to applying the alpha-numerical sort order to
the
remainders of the sorted strings, i.e. to everything but the multi-digit
numbers found in the property names.
next prev parent reply other threads:[~2025-03-05 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-05 8:45 Dragan Simic
2025-03-05 9:36 ` Krzysztof Kozlowski
2025-03-05 9:53 ` Dragan Simic [this message]
2025-03-06 8:38 ` Krzysztof Kozlowski
2025-03-06 8:57 ` Dragan Simic
2025-03-07 7:14 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f05919742c34f5d4489d2cd711c7736f@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®