From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4D4BA477E21 for ; Thu, 30 Apr 2026 18:19:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777573160; cv=none; b=TT29w2soXupftS35oouRFI8W5gwOGdMCoL+fplrwmSTIpGFKHcPJyQBDMxGVfKrhpB8IIXoNBJnyfBY41vNIH+CJvxQKtNuc5kpjG5blnKneNCseaZp6I/a6hlzxYXp5mZ4p4QppsUWLV5NYB05asbp7BbyRC6DUbwdqkFTEyfM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777573160; c=relaxed/simple; bh=+qKaXpiv7eeIklafuIHZY8c2GZ7k4CIdfO5iNFUHTqU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JEK6fkhv5z6Yy/P0DdexGCCPCz9a+0nEAmjvjqhC0Pam5EIyT6CtLDwLO+BgrXbMgcTJ9h48uUr+BXy1XRuBYpXLY0UecVSx5M8ckpyAI2W+f69EEx+zhqXQLQMb/ORsE44hZTkARXmNhlMsEKfZowKOkrv1BwYv26f5mSWGgtw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bK5J7/5W; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bK5J7/5W" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-c7b9f54d3deso768168a12.1 for ; Thu, 30 Apr 2026 11:19:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1777573159; x=1778177959; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :from:to:cc:subject:date:message-id:reply-to; bh=nMVHhZ1eUgYJb8AUkhSy4uV/Dn/nEc7kSE5GQyo6dnA=; b=bK5J7/5W7wia4UUgDIMb4kAy0K87FBRFSjcatE7sQZ5h99GpEhAvRX2jOt81fLzccI a5ierDJqtLRLtRkVh+R0TRcEG5BhpVofLD66au/+LZXrJq7K6hl/IT2XA3OiXSxYQ5bt 8vcMStSr7kL1dPyN8Eat4mT8/IYLPhRbccw41WczmKB5iQmUXuZ+OuEIDZd1ihwlj3jb eEZLjF05nUiS43chHB9vuGOCyuhhE1dnMuwHF8SzaTCKph5ScMgGWE0E6+jRgLR3MD6J 11cO9yRsc0RoV/dVNaIGOw3bSBiAveOe5zTBRzBZwBVsba9ONKG81ixIuWI/yodN/RIC x7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777573159; x=1778177959; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:sender :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nMVHhZ1eUgYJb8AUkhSy4uV/Dn/nEc7kSE5GQyo6dnA=; b=g9rEB8FsB9mC56hNcVdUS+S0yi+3xpyUEY7hk8auQpaKkKtCVcQqiA9QCagUONjEiW mbheHejUDqH7egfF+k6QVSzoo2GZVFa8dYtiIlJ5vk05GrrbHtcI6zrgYpycz2vYQZHz /8im95jAcC3FszJHT7iJnvyWc0qrN34vE1Y/+QhqNcu8mrhdj1PnvaSfQwfFTX1RwEq5 8pBOLUSbkiRprpkr2plDH8lTRNJj7iXWvqsJ2rEM4s3NctjfuSJFzKRo7/2wH4alEARS VO7ErULO5CsFmKtW57RjrqPpC4pjaOhQj+JIsGFCOagytF7QZQyiMHzzJWnSey8SJ0PS BLxg== X-Forwarded-Encrypted: i=1; AFNElJ8x8Gr7UxrH8/VCRGaviVFkw829ngurN/oYua+VSm7OO/BdgcXVS7RLjMqZ7BUbQyevNXVOedl9chmySDw=@vger.kernel.org X-Gm-Message-State: AOJu0YyPBXDfx4VooaH3pYiKOYnMQpZ/sf5QL17JzdiKds3WcIIGQq3P fXH0s2xvrmxIrSqAyBrB75GzXPOlpYAn2ux6egy6ccrBZPd/37oDLGpPEIqWGA== X-Gm-Gg: AeBDiesXy2DVdNqrn5CwKSc9C1MU2EZQIilrMqP/bgNLLrYpmue/RCcafFMGXqcIlIK sbpwoFfMFkP4dJSGShEAw+8VO+iPdneoNr865DqhnapJ7AkFBd4k7PbJQz5Floz1Lg/R9dVjyWE qka1FAPUTy0TM86XdLH8fGkvq0dkUkm1kwRyIZU2WLi0nk2GkMX7ugmvGrqE4Lr3Amtp6y5oq1D MY9muHQeEbhLN2UmHuFf9hzJ3olxbUQ8kwxLF0x5s31QkkPKF1S/7M7yjOng7RQ7UrBn8GC5jn5 tkymk6GNrU5a1HqkSJzCCR9dIC/+Du19zJvxEIc2easrd0tWHCnoZybdO6ZwKbg/JsLVUwTwXbi quCreDE7ch+Canq/sL7ArOcYHYmsqPQzP5IShoYoHWBxihBTv02s1LXg4WIOdv8MQNpA/9sHX8a TZ5/EwWCjHtdQGz/zdNR4nUIZlJTrO02FEZG7xJX/kjJys2KAa4o+GRWEmnQ== X-Received: by 2002:a05:6a00:1745:b0:82f:a6bf:bee7 with SMTP id d2e1a72fcca58-834fdc96838mr4660286b3a.49.1777573158627; Thu, 30 Apr 2026 11:19:18 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83515acfbcdsm325989b3a.30.2026.04.30.11.19.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Apr 2026 11:19:18 -0700 (PDT) Sender: Guenter Roeck Date: Thu, 30 Apr 2026 11:19:16 -0700 From: Guenter Roeck To: Sasha Levin Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hwmon: Remove stale CONFIG_SENSORS_SBRMI Makefile reference Message-ID: References: <20260426000319.55908-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260426000319.55908-1-sashal@kernel.org> On Sat, Apr 25, 2026 at 08:03:19PM -0400, Sasha Levin wrote: > kconfiglint reports: > > X001: CONFIG_SENSORS_SBRMI referenced in Makefile but not defined > in any Kconfig > > The SB-RMI hardware monitoring driver was originally introduced in > commit 5a0f50d110b3 ("hwmon: Add support for SB-RMI power module") with > both a Kconfig entry (CONFIG_SENSORS_SBRMI) and a Makefile line > (obj-$(CONFIG_SENSORS_SBRMI) += sbrmi.o) in drivers/hwmon/. > > Commit e156586764050 ("hwmon/misc: amd-sbi: Move core sbrmi from hwmon to > misc") > moved the driver to drivers/misc/amd-sbi/ to support additional > functionality beyond hardware monitoring. That commit correctly removed the > Kconfig entry from drivers/hwmon/Kconfig, moved the source file > drivers/hwmon/sbrmi.c to drivers/misc/amd-sbi/sbrmi.c, and created new > Kconfig/Makefile entries in drivers/misc/amd-sbi/ with a renamed symbol > (CONFIG_AMD_SBRMI_I2C). > > However, the Makefile line in drivers/hwmon/Makefile was not removed in > that commit. The orphaned line references a CONFIG symbol that no longer > exists and a source file that is no longer present, so it has no effect > on the build — but it is dead code that should be cleaned up. > > Remove the stale Makefile reference. > > Assisted-by: Claude:claude-opus-4-6 kconfiglint > Signed-off-by: Sasha Levin Applied. Thanks, Guenter