From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 450791E505 for ; Tue, 7 Apr 2026 04:36:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775536585; cv=none; b=hU4cHzMfdJjJavLOEXm0TKyYZs/l+2o2JR1L7v6rj8Sr0t2awoaC2s3bs/7n70dNjgNp46Pkdb+NG0DvusBMGShvD8ZiTF+rwjgN4Ck8O05n+6PLH0htm+ySImb1QZtrA6BKDrC8Pre/lRFUmo4fJQ2UaQ/5ghqOkxFrEMQNj7c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775536585; c=relaxed/simple; bh=JgDKTasJUayLCHD+Kc/rGxSiOf8rZ8VEd4Sv851vOr4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=VVZAwYcyqOEcCrizQVT5g3OaqbGEu4GNDd1SMv1qblxkLCL3Jwn7uh6GSdHWxvThi5yb6MfKSAJaqj4Zo4sFR8u8tzUbezho4piOMWIvYsddlklL2/w7gsopOUOwChKpxayBoO/k5vWnw5ABP7F54FuC9xAXAYzAlzVju7/sRWs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Lf0FvsxA; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ozj6roag; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Lf0FvsxA"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ozj6roag" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 636LSGUw2328036 for ; Tue, 7 Apr 2026 04:36:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= J94ZVuzwu9K2fbOoqhqmXlR+x27Ar5N3kXchAi9R2to=; b=Lf0FvsxAlVdOcsKz sF0Sq3+l3YNb6Mvm1IVITwmD0DWFI8Bsq/j+zXulyiuQK4O1xbuIHsLrPOAy1IBG 2c+JWW7Fl14WpvIyd3mzyci1y/c0LXMLMhDlV1u/AgSnkh2AJmIbcUEj65G7CP32 b9+WUuofJV+kwMEqJFziUAdJ535tsLvS4rxjWFjvBMJ9T7rNC0/egsif/+IBIoEk 0lkN3h/a8mrRFUiyBHFwTW84KiI9JkQidDd0ta5MNojQ9ToCFyCoWCE2wRaBcPax SDVjZA32ssIBfvM6uF1Pb1HOcxWNTr5s/MIkWiojdDm9mVtU17MXNKNykikoJdOC LI0LhQ== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dcms4s0y6-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 07 Apr 2026 04:36:22 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-35c12a3bbb9so4791455a91.3 for ; Mon, 06 Apr 2026 21:36:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775536582; x=1776141382; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=J94ZVuzwu9K2fbOoqhqmXlR+x27Ar5N3kXchAi9R2to=; b=Ozj6roagpXV1cA0sjfoj1KAYtOixg6/IG4SckWWkQNHXtKnRP8192NvjG3t3BOL3zB wIt54FaD5Dmui2aCKP/b6CzG1+KoqZlV4vbZs7RJf/Ez63PRbSWT+IEGUmXOXNk5vyhl xUo2wQ+uu6kmqjVUWFXVHIKg22eNZCYCpUaU+TVzeuCqigbFacHUL+6cAu4/Ny7yfAoz 6NU5qfDbXaZYkliNzEKwVHta7sCgLCMB3c21RTFx2fvZM4NutqVJXo3rYudu0Fbwmm+6 oSAm/yQB/eiyX3u40Li5i6SFnnKVvg+xuVjgbxDJXHNOEVHfC51uPvXOI2p0Dn5d/sz7 zG2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775536582; x=1776141382; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=J94ZVuzwu9K2fbOoqhqmXlR+x27Ar5N3kXchAi9R2to=; b=rpoKMuV1r+UMQVRG1LaSSRz/M8O5qy5dFKQlxLi4SrPabPfn7PRmv5DamnST9nGXeF MBLZS0M90yXgK8qbCL0alEfCWVlbcyHMgAartk05utplHsktM1rpJyBjuk0YHIo1KHyl XHk1HxfpfvxuJdMiIzNVgFTZo5IxfESElutdiDgUnqSll7lQT2kBRVLOUyCuo3SgGWHz v2zxysy2kotLz6A5EfVqvn3/Giq7Mwp9FKzubEd+zE2X0tdVz9kloWu3LH13LNEQGVY7 QzNxM2auF9GZtP5oE9ydPIZZZE0SOXiBXoQ+8qxjxPIaX8Y1AglFdnT5yGSfv8FHfTZg 5Q6g== X-Forwarded-Encrypted: i=1; AJvYcCWvY0ZVOqfqb1JjUyJY9bs/4YZ2wykFhE1Sjr0ltG3D8pYRCtuy5wGEv6Q/IlGQdqywB4x7hQP4/KoBTC4=@vger.kernel.org X-Gm-Message-State: AOJu0YyGhcorawSZNOWmkc81Vb1NUyXNKY8pizVVg2NT7omoESthECtl ud4nWJd7zKvnEbS+WB/NCTFnnw3Gdr3L1RLBpNv+MA7rtIfWws/9k4g6lRm4uQsz/kV2yBWs5qE S+DxxOzI/x+sm3n7KbwM38+KSohAyr11zdbJ4Jxz6XZHeaBKudyKG6nEyv0TVtVeIHFc= X-Gm-Gg: AeBDietgQjuOwCmjWy4xWZAMvzc2erikYKM9z6LyNlQnvnhX++evyBZtKCt+uJVjh+q tdG4xJgRKWyZyFHw9sihPMNH/Q9K10FfHvkS57buegqwfwRDetiaUxphsCSV9CE7ahxmk7B/ygK qTW3PTazbvD2xJUKZNBel5XKiCzGOvmSt8+ThwMaZv6MMPUqBILYL8bVBDfp13nVSoGXtpadmug PkM+PupKBjTezA+wXy1+Ix9Evnt4hyBRGzVA5vGHnILaOsV15wZrq5GgdVUWiEmYICaQpF2gDoN oFUBp/mlRD/NlSwrBaeKUH7UF4pWxBf3LFFcEB6/5rJV1anhLSqFEtSK/eCHFWf2j9w+pOiAkhM /BME6LsjHmZr/38eo+9z+MF6g+LnSTW1TK82xATVibxXonDP4X35q X-Received: by 2002:a05:6a20:3d05:b0:39b:fad0:6edc with SMTP id adf61e73a8af0-39f2edaab1emr16119212637.6.1775536581791; Mon, 06 Apr 2026 21:36:21 -0700 (PDT) X-Received: by 2002:a05:6a20:3d05:b0:39b:fad0:6edc with SMTP id adf61e73a8af0-39f2edaab1emr16119185637.6.1775536581336; Mon, 06 Apr 2026 21:36:21 -0700 (PDT) Received: from [10.217.223.92] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c76cffd9611sm11404687a12.17.2026.04.06.21.36.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 06 Apr 2026 21:36:20 -0700 (PDT) Message-ID: Date: Tue, 7 Apr 2026 10:06:16 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] arm64: dts: qcom: kodiak: Add iface clock for ice sdhc To: Dmitry Baryshkov Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260406-ice_emmc_clock_addition-v1-0-e7b237bf7a69@oss.qualcomm.com> <20260406-ice_emmc_clock_addition-v1-1-e7b237bf7a69@oss.qualcomm.com> Content-Language: en-US From: Kuldeep Singh In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDA3MDA0MSBTYWx0ZWRfX6jAyW2mSYfFx H4VyN/C4XmjiTwYiNf80M4QXerNHPNEd5mfhvEYhxbiHyS33LYjNPQDS5G6hd7xAtv8hA9BL5us 6bs/Osl6V+9nBLoOgI8ghGUdg5sj35qaNcUppssl4zeIdJdxtmUnKvFHCeH8WRoWSIkYGKAvliY J0jmlYyQtTgDGrCQGsUropwPKyG2HzSQy3oxv5g3BrP8oNuMPZZyAnmPYoW7r3KhwJAIfjlRX7V 7CkfHC77P2D23P8vj6eSCq/sZdXJWDBxRC7ZXWRtJrUYEU3E/cIvS4IJvu4PmPPaDPdBELw2Qyv +frsmq3BdcxFVPPVHH7JeYQCxQkkmyQiGmHKDi9yTFUhaM6WOaiM1/M9qrzxI5qxZ/XLnckv6n9 HsM6zjGIZUPvYbIgsu3EVF/GrADUv8HB4JqfuOxeIj3A3VOOmSMdRn8IjpHkeBp0LtylOgezYvk y3/RHNhjGi72+XPqy5A== X-Proofpoint-ORIG-GUID: oy6SkdnapAthvYRr_TlKVASMYtPeJOHe X-Authority-Analysis: v=2.4 cv=WNZPmHsR c=1 sm=1 tr=0 ts=69d489c6 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=gBggw25WdKopFYHr0XkA:9 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-GUID: oy6SkdnapAthvYRr_TlKVASMYtPeJOHe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-07_02,2026-04-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 bulkscore=0 phishscore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604070041 On 4/7/2026 12:43 AM, Dmitry Baryshkov wrote: > On Mon, Apr 06, 2026 at 10:00:36PM +0530, Kuldeep Singh wrote: >> Qualcomm in-line crypto engine (ICE) platform driver specifies and votes >> for its own resources. Before accessing ICE hardware during probe, to >> avoid potential unclocked register access issues (when clk_ignore_unused >> is not passed on the kernel command line), in addition to the 'core' >> clock the 'iface' clock should also be turned on by the driver. >> >> As bindings allow to specify 2 clocks, add iface clock now. >> >> Signed-off-by: Kuldeep Singh >> --- >> arch/arm64/boot/dts/qcom/kodiak.dtsi | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/kodiak.dtsi b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> index dda4697a61b7..5e6b659e8719 100644 >> --- a/arch/arm64/boot/dts/qcom/kodiak.dtsi >> +++ b/arch/arm64/boot/dts/qcom/kodiak.dtsi >> @@ -1082,7 +1082,8 @@ sdhc_ice: crypto@7c8000 { >> compatible = "qcom,sc7280-inline-crypto-engine", >> "qcom,inline-crypto-engine"; >> reg = <0x0 0x007c8000 0x0 0x18000>; >> - clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>; >> + clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; >> + clock-names = "core", "iface"; > > Inside the schema the clocks have maxItems:1. Please update the schema: > Documentation/devicetree/bindings/crypto/qcom,inline-crypto-engine.yaml Thanks for review Dmitry. Clocks maxItems are already 2 as per below dependent patch. Kindly check cover letter for dependency to understand more. https://lore.kernel.org/linux-arm-msm/20260323-qcom_ice_power_and_clk_vote-v4-0-e36044bbdfe9@oss.qualcomm.com/T/#m885402f4d828804501a3982ae8b8a5a028e15a89 -- Regards Kuldeep