From: Alex <alex.g@adaptrum.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: <f.fainelli@gmail.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <davem@davemloft.net>,
Gokhan Cosgul <gokhan@adaptrum.com>
Subject: Re: [PATCH v2] net/phy/vitesse: Configure RGMII skew on VSC8601, if needed
Date: Wed, 16 Nov 2016 08:44:30 -0800 [thread overview]
Message-ID: <f05f5f5d-a010-def2-314a-09a859f9eda3@adaptrum.com> (raw)
In-Reply-To: <20161116135053.GF19962@lunn.ch>
On 11/16/2016 05:50 AM, Andrew Lunn wrote:
> On Wed, Nov 16, 2016 at 01:02:33AM -0800, Alexandru Gagniuc wrote:
>> With RGMII, we need a 1.5 to 2ns skew between clock and data lines. The
>> VSC8601 can handle this internally. While the VSC8601 can set more
>> fine-grained delays, the standard skew settings work out of the box.
>> The same heuristic is used to determine when this skew should be enabled
>> as in vsc824x_config_init().
>>
>> +/* This adds a skew for both TX and RX clocks, so the skew should only be
>> + * applied to "rgmii-id" interfaces. It may not work as expected
>> + * on "rgmii-txid", "rgmii-rxid" or "rgmii" interfaces. */
>
> Hi Alexandru
>
> You should be able to make "rgmii" work as expected. If that is the
> phy mode, disable the skew.
And that's exactly the implemented behavior. See vsc8601_config_init()
below.
Alex
next prev parent reply other threads:[~2016-11-16 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 23:32 [PATCH] " Alexandru Gagniuc
2016-11-14 21:18 ` David Miller
2016-11-14 21:25 ` Florian Fainelli
2016-11-14 21:54 ` Alex
2016-11-16 3:12 ` David Miller
2016-11-16 9:02 ` [PATCH v2] " Alexandru Gagniuc
2016-11-16 13:50 ` Andrew Lunn
2016-11-16 16:44 ` Alex [this message]
2016-11-16 16:54 ` Andrew Lunn
2016-11-16 17:10 ` Alex
2016-11-16 22:54 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f05f5f5d-a010-def2-314a-09a859f9eda3@adaptrum.com \
--to=alex.g@adaptrum.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=gokhan@adaptrum.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®