mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@somainline.org>
To: Marijn Suijten <marijn.suijten@somainline.org>,
	phone-devel@vger.kernel.org
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@somainline.org>,
	Martin Botka <martin.botka@somainline.org>,
	Jami Kettunen <jami.kettunen@somainline.org>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Luca Weiss <luca@z3ntu.xyz>,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/10] arm64: dts: qcom: sm6350-lena: Include pm6350 and configure buttons
Date: Mon, 31 Oct 2022 22:13:05 +0100	[thread overview]
Message-ID: <f05f95d4-4ca6-6da5-d239-0531cff3ddfc@somainline.org> (raw)
In-Reply-To: <20221030073232.22726-6-marijn.suijten@somainline.org>



On 30.10.2022 08:32, Marijn Suijten wrote:
> Include pm6350 to inherit its GPIO and button configuration, and
> configure "resin" to serve as volume up, and gpio2 as volume down.
> 
> Signed-off-by: Marijn Suijten <marijn.suijten@somainline.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org>

Konrad
>  .../qcom/sm6350-sony-xperia-lena-pdx213.dts   | 31 +++++++++++++++++++
>  1 file changed, 31 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> index 9a96000fc95b..4512b0bf7fe1 100644
> --- a/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> +++ b/arch/arm64/boot/dts/qcom/sm6350-sony-xperia-lena-pdx213.dts
> @@ -4,7 +4,9 @@
>   */
>  /dts-v1/;
>  
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>  #include "sm6350.dtsi"
> +#include "pm6350.dtsi"
>  
>  / {
>  	model = "Sony Xperia 10 III";
> @@ -28,6 +30,35 @@ framebuffer: framebuffer@a0000000 {
>  			clocks = <&gcc GCC_DISP_AXI_CLK>;
>  		};
>  	};
> +
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&gpio_keys_state>;
> +
> +		key-volume-down {
> +			label = "volume_down";
> +			linux,code = <KEY_VOLUMEDOWN>;
> +			gpios = <&pm6350_gpios 2 GPIO_ACTIVE_LOW>;
> +		};
> +	};
> +};
> +
> +&pm6350_gpios {
> +	gpio_keys_state: gpio-keys-state {
> +		key-volume-down-pins {
> +			pins = "gpio2";
> +			function = PMIC_GPIO_FUNC_NORMAL;
> +			power-source = <0>;
> +			bias-disable;
> +			input-enable;
> +		};
> +	};
> +};
> +
> +&pm6350_resin {
> +	linux,code = <KEY_VOLUMEUP>;
> +	status = "okay";
>  };
>  
>  &sdc2_off_state {

  reply	other threads:[~2022-10-31 21:13 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-30  7:32 [PATCH 00/10] arm64: dts: qcom: sm6350: SD Card fixes, pm6350 keys and touchscreen for PDX213 Marijn Suijten
2022-10-30  7:32 ` [PATCH 01/10] arm64: dts: qcom: sm6350: Add resets for SDHCI 1/2 Marijn Suijten
2022-10-31  8:55   ` Luca Weiss
2022-10-31 21:12   ` Konrad Dybcio
2022-10-30  7:32 ` [PATCH 02/10] arm64: dts: qcom: sm6350: Add pinctrl for SDHCI 2 Marijn Suijten
2022-10-31  8:56   ` Luca Weiss
2022-10-31 21:12   ` Konrad Dybcio
2022-11-02 20:45   ` Krzysztof Kozlowski
2022-10-30  7:32 ` [PATCH 03/10] arm64: dts: qcom: sm6350-lena: Add SD Card Detect to sdc2 on/off pinctrl Marijn Suijten
2022-10-31 21:12   ` Konrad Dybcio
2022-11-02 20:45   ` Krzysztof Kozlowski
2022-10-30  7:32 ` [PATCH 04/10] arm64: dts: qcom: pm6350: Include header for KEY_POWER Marijn Suijten
2022-10-31  8:57   ` Luca Weiss
2022-10-31 21:12   ` Konrad Dybcio
2022-10-30  7:32 ` [PATCH 05/10] arm64: dts: qcom: sm6350-lena: Include pm6350 and configure buttons Marijn Suijten
2022-10-31 21:13   ` Konrad Dybcio [this message]
2022-10-30  7:32 ` [PATCH 06/10] arm64: dts: qcom: sm6350-lena: Define pm6350 and pm6150l regulators Marijn Suijten
2022-10-31 21:13   ` Konrad Dybcio
2022-10-30  7:32 ` [PATCH 07/10] arm64: dts: qcom: sm6350-lena: Provide power to SDHCI 2 (SDCard slot) Marijn Suijten
2022-10-31 21:14   ` Konrad Dybcio
2022-10-30  7:32 ` [PATCH 08/10] arm64: dts: qcom: sm6350-lena: Enable QUP and GPI DMA Marijn Suijten
2022-10-31 21:14   ` Konrad Dybcio
2022-10-30  7:32 ` [PATCH 09/10] arm64: dts: qcom: sm6350-lena: Configure Samsung touchscreen Marijn Suijten
2022-10-31 21:14   ` Konrad Dybcio
2022-10-30  7:32 ` [PATCH 10/10] arm64: dts: qcom: sm6350: Add apps_smmu with streamID to SDHCI 1/2 nodes Marijn Suijten
2022-10-31  8:58   ` Luca Weiss
2022-10-31 21:15   ` Konrad Dybcio
2022-11-08  1:27 ` [PATCH 00/10] arm64: dts: qcom: sm6350: SD Card fixes, pm6350 keys and touchscreen for PDX213 Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f05f95d4-4ca6-6da5-d239-0531cff3ddfc@somainline.org \
    --to=konrad.dybcio@somainline.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jami.kettunen@somainline.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®