From: Joe Perches <joe@perches.com>
To: John Whitmore <johnfwhitmore@gmail.com>, linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org
Subject: Re: [PATCH 04/17] staging:rtl8192u: Rename eqMacAddr macro - Style
Date: Wed, 08 Aug 2018 01:12:53 -0700 [thread overview]
Message-ID: <f06112b569731e2c5de3958d1b9de5a039b7ed0d.camel@perches.com> (raw)
In-Reply-To: <20180807211255.29343-5-johnfwhitmore@gmail.com>
On Tue, 2018-08-07 at 22:12 +0100, John Whitmore wrote:
> The eqMacAddr(a, b) macro causes a checkpatch issue, due to CamelCase
> naming, so has been renamed to eq_mac_addr(a, b).
>
> This is a coding style change which should not impact on runtime code
> execution.
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/dot11d.h b/drivers/staging/rtl8192u/ieee80211/dot11d.h
[]
> @@ -30,7 +30,7 @@ struct rt_dot11d_info {
> enum dot11d_state state;
> };
>
> -#define eqMacAddr(a, b) (((a)[0] == (b)[0] && \
> +#define eq_mac_addr(a, b) (((a)[0] == (b)[0] && \
> (a)[1] == (b)[1] && (a)[2] == (b)[2] && (a)[3] == (b)[3] && \
> (a)[4] == (b)[4] && (a)[5] == (b)[5]) ? 1 : 0)
I'd check to see if the etherdevice.h ether_addr_equal
would be used instead of this macro.
next prev parent reply other threads:[~2018-08-08 8:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-07 21:12 [PATCH 00/17] staging:rtl8192u: Coding style changes John Whitmore
2018-08-07 21:12 ` [PATCH 01/17] staging:rtl8192u: Remove stale comment - Style John Whitmore
2018-08-07 21:12 ` [PATCH 02/17] staging:rtl8192u: Add spaces around '+' operator " John Whitmore
2018-08-07 21:12 ` [PATCH 03/17] staging:rtl8192u: Remove unused macro definitions " John Whitmore
2018-08-07 21:12 ` [PATCH 04/17] staging:rtl8192u: Rename eqMacAddr macro " John Whitmore
2018-08-08 8:12 ` Joe Perches [this message]
2018-08-08 8:52 ` John Whitmore
2018-08-07 21:12 ` [PATCH 05/17] staging:rtl8192u: Rename cpMacAddr Macro " John Whitmore
2018-08-08 8:14 ` Joe Perches
2018-08-07 21:12 ` [PATCH 06/17] staging:rtl8192u: Rename macro parameter __pIeeeDev " John Whitmore
2018-08-07 21:12 ` [PATCH 07/17] staging:rtl8192u: Rename __pTa " John Whitmore
2018-08-07 21:12 ` [PATCH 08/17] staging:rtl8192u: Lines should not end with a '(' " John Whitmore
2018-08-07 21:12 ` [PATCH 09/17] staging:rtl8192u: Rename Dot11d_Init " John Whitmore
2018-08-07 21:12 ` [PATCH 10/17] staging:rtl8192u: Rename Dot11d_Reset " John Whitmore
2018-08-07 21:12 ` [PATCH 11/17] staging:rtl8192u: Rename Dot11d_UpdateCountryIe " John Whitmore
2018-08-07 21:12 ` [PATCH 12/17] staging:rtl8192u: Rename dot11d_update_country_ie() parameters " John Whitmore
2018-08-07 21:12 ` [PATCH 13/17] staging:rtl8192u: Rename DOT11D_GetMaxTxPwrInDbm " John Whitmore
2018-08-07 21:12 ` [PATCH 14/17] staging:rtl8192u: Rename Channel " John Whitmore
2018-08-07 21:12 ` [PATCH 15/17] staging:rtl8192u: Rename DOT11D_ScanComplete " John Whitmore
2018-08-07 21:12 ` [PATCH 16/17] staging:rtl8192u: Rename IsLegalChannel " John Whitmore
2018-08-07 21:12 ` [PATCH 17/17] staging:rtl8192u: Rename ToLegalChannel " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f06112b569731e2c5de3958d1b9de5a039b7ed0d.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®