From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74C8F393DE0; Fri, 22 Aug 2025 00:23:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755822212; cv=none; b=dKin0jJJv9R557p9m+SID9NxuclOE9XIfZt0ei3Q3G/kFzwBs9VFiUwn9D5zgZQ6PBM+ixiiE9Yh2fnJG7MOLk8ogr8/dN2e0+jSxWZNcKTG3A0ToKU8rVX6setRge52/PiHZ3XVBpaZVVC2OY2WRHYivi+zRvQdtAbPDrfGyPU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755822212; c=relaxed/simple; bh=d8uSlCdsb6IxON+UB2gioFYxQjDtQKGH8lLrzfJm/6o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=F/0hN4fyLMzRNUryZNkHPGlU3FvoXSfpb8AXQ44e/k8g0qGQCDQ74edHtlvLG6E3KH5zbME9yl0llUnJ0AB3xMl8QKDilw9+qt93SdynuHjJxzMUbz2OeXCzVBZJCC+EXdTZVCUF6N4PfuuwxhTb/xcN3jt2MF5PdoPR3zkmGD8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=b4rlDsE+; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="b4rlDsE+" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=pdwFPjIY1pZ9q97xgTvS+donn5rx+Zx9UyAGAblGIoo=; b=b4rlDsE+x09keSlPfhZmsxsNcf WLJHrpSr7MLO27TernWqiGoCe1RkjcVgcxcM+xKsVb1bkB3Pkf6ZXdAYJpV/KMundEGdEksxs83Ff mbBBnJLPcUxVQmUVltH+HCOPvo/jGx9yjP5JpUsuYvyCMgWFvfPaToGHM3TctiCgCGZc=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1upFYx-005W7H-AA; Fri, 22 Aug 2025 02:23:23 +0200 Date: Fri, 22 Aug 2025 02:23:23 +0200 From: Andrew Lunn To: Yeounsu Moon Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dlink: fix multicast stats being counted incorrectly Message-ID: References: <20250821114254.3384-1-yyyynoom@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250821114254.3384-1-yyyynoom@gmail.com> On Thu, Aug 21, 2025 at 08:42:53PM +0900, Yeounsu Moon wrote: > `McstFramesRcvdOk` counts the number of received multicast packets, and > it reports the value correctly. > > However, reading `McstFramesRcvdOk` clears the register to zero. As a > result, the driver was reporting only the packets since the last read, > instead of the accumulated total. > > Fix this by updating the multicast statistics accumulatively instaed of > instantaneously. This looks like a fix. Please could you add a Fixes: tag and submit to net. https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html Andrew --- pw-bot: cr