From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F51DC38A2B for ; Fri, 17 Apr 2020 11:10:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31AB921D95 for ; Fri, 17 Apr 2020 11:10:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730193AbgDQLK2 (ORCPT ); Fri, 17 Apr 2020 07:10:28 -0400 Received: from szxga06-in.huawei.com ([45.249.212.32]:60934 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729468AbgDQLK1 (ORCPT ); Fri, 17 Apr 2020 07:10:27 -0400 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 3A4A7F3EA52CC01CAB9E; Fri, 17 Apr 2020 19:10:25 +0800 (CST) Received: from [127.0.0.1] (10.166.213.7) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Fri, 17 Apr 2020 19:10:15 +0800 Subject: Re: [PATCH] irqchip/irq-bcm7038-l1: make bcm7038_l1_of_init() static To: Marc Zyngier CC: Sergei Shtylyov , , , , , , , , Hulk Robot References: <20200417074036.46594-1-yanaijie@huawei.com> From: Jason Yan Message-ID: Date: Fri, 17 Apr 2020 19:10:15 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.4.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.166.213.7] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/4/17 19:07, Marc Zyngier 写道: > On 2020-04-17 11:56, Jason Yan wrote: >> 在 2020/4/17 18:26, Sergei Shtylyov 写道: >>> Hello! >>> >>> On 17.04.2020 10:40, Jason Yan wrote: >>> >>>> Fix the following sparse warning: >>>> >>>> drivers/irqchip/irq-bcm7038-l1.c:419:12: warning: symbol >>>> 'bcm7038_l1_of_init' was not declared. Should it be static? >>>> >>>> Reported-by: Hulk Robot >>>> Signed-off-by: Jason Yan >>>> --- >>>>   drivers/irqchip/irq-bcm7038-l1.c | 2 +- >>>>   1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/irqchip/irq-bcm7038-l1.c >>>> b/drivers/irqchip/irq-bcm7038-l1.c >>>> index eb9bce93cd05..fd7c537fb42a 100644 >>>> --- a/drivers/irqchip/irq-bcm7038-l1.c >>>> +++ b/drivers/irqchip/irq-bcm7038-l1.c >>>> @@ -416,7 +416,7 @@ static const struct irq_domain_ops >>>> bcm7038_l1_domain_ops = { >>>>       .map            = bcm7038_l1_map, >>>>   }; >>>> -int __init bcm7038_l1_of_init(struct device_node *dn, >>>> +static int __init bcm7038_l1_of_init(struct device_node *dn, >>>>                     struct device_node *parent) >>> >>>     Reindent the above line please, it should start under *struct* on >>> the 1st line. >> >> OK, will cook a new one. > > Please don't bother. I've picked the patch already, and it is on its way > to Linus. > I have send v2 before I saw this. You can just ignore it. Thanks, Jason > Thanks, > >         M.