From: "André Draszik" <andre.draszik@linaro.org>
To: Roy Luo <royluo@google.com>,
Thinh.Nguyen@synopsys.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: badhri@google.com, peter.griffin@linaro.org
Subject: Re: [PATCH v1] usb: dwc3: gadget: Fix incorrect UDC state after manual deconfiguration
Date: Mon, 23 Dec 2024 06:51:15 +0000 [thread overview]
Message-ID: <f06eb1fb7fa12880b04310d702e1b06af5b25276.camel@linaro.org> (raw)
In-Reply-To: <20241223042536.1465299-1-royluo@google.com>
On Mon, 2024-12-23 at 04:25 +0000, Roy Luo wrote:
> The UDC state in sysfs (/sys/class/udc/<udc>/state) should accurately
> reflect the current state of the USB Device Controller.
>
> Currently, the UDC state is not handled consistently during gadget
> disconnection. While the disconnect interrupt path correctly sets the
> state to "not-attached", manual deconfiguration leaves the state in
> "configured", misrepresenting the actual situation.
>
> This commit ensures consistent UDC state handling by setting the state to
> "not-attached" after manual deconfiguration. This accurately reflects the
> UDC's state and provides a consistent behavior regardless of the
> disconnection method.
>
> Signed-off-by: Roy Luo <royluo@google.com>
> ---
Reviewed-by: André Draszik <andre.draszik@linaro.org>
Tested-by: André Draszik <andre.draszik@linaro.org>
prev parent reply other threads:[~2024-12-23 6:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-23 4:25 Roy Luo
2024-12-23 6:51 ` André Draszik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f06eb1fb7fa12880b04310d702e1b06af5b25276.camel@linaro.org \
--to=andre.draszik@linaro.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=badhri@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=royluo@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®