From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752632AbdEJLeY (ORCPT ); Wed, 10 May 2017 07:34:24 -0400 Received: from mail-wr0-f195.google.com ([209.85.128.195]:36395 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbdEJLeX (ORCPT ); Wed, 10 May 2017 07:34:23 -0400 Subject: Re: [PATCH] Soc: mediatek - Fix possible NULL derefrence. To: Shailendra Verma , John Crispin , Henry Chen , Daniel Kurtz , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, p.shailesh@samsung.com, ashish.kalra@samsung.com, Shailendra Verma References: <1485515868-3671-1-git-send-email-shailendra.v@samsung.com> From: Matthias Brugger Message-ID: Date: Wed, 10 May 2017 13:34:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1485515868-3671-1-git-send-email-shailendra.v@samsung.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/01/17 12:17, Shailendra Verma wrote: > of_match_device could return NULL, and so can cause a NULL > pointer dereference later. > > Signed-off-by: Shailendra Verma I fixed the subject line and queued it for v4.12-next/soc Sorry for the (huge) delay. Matthias > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c > index a5f1093..c48db98 100644 > --- a/drivers/soc/mediatek/mtk-pmic-wrap.c > +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c > @@ -1117,6 +1117,11 @@ static int pwrap_probe(struct platform_device *pdev) > const struct of_device_id *of_slave_id = NULL; > struct resource *res; > > + if (!of_id) { > + dev_err(&pdev->dev, "Error: No device match found\n"); > + return -ENODEV; > + } > + > if (pdev->dev.of_node->child) > of_slave_id = of_match_node(of_slave_match_tbl, > pdev->dev.of_node->child); >