mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Simek <michal.simek@xilinx.com>
To: Markus Elfring <Markus.Elfring@web.de>,
	Xu Wang <vulab@iscas.ac.cn>,
	linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	Michal Simek <michal.simek@xilinx.com>
Subject: Re: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun_start()
Date: Thu, 30 Apr 2020 11:19:57 +0200	[thread overview]
Message-ID: <f07532ca-0bf3-7e1b-2d53-6f5555d5e451@xilinx.com> (raw)
In-Reply-To: <9cf516c9-3a29-fb39-8943-49c906b3eea7@web.de>

On 30. 04. 20 11:00, Markus Elfring wrote:
>> In ioremap we should return -ENOMEM when it reports an
>> memory allocation failure.
> 
> I suggest to improve this change description.
> 
> Will the tag “Fixes” be relevant because of the adjusted error code?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d2cc5ac6f6668cc15216d51051103c61467d7e8#n183

I don't think this was found by bisection because arm smp code cares
only about 0 - success and !0. I would expect any static program
analysis tool like coccinelle.

Would be good to rewrite that commit message and simply say that
failures from ioremaps returns -ENOMEM.

Thanks,
Michal


  reply	other threads:[~2020-04-30  9:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-30  9:00 Markus Elfring
2020-04-30  9:19 ` Michal Simek [this message]
2020-04-30 10:37   ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f07532ca-0bf3-7e1b-2d53-6f5555d5e451@xilinx.com \
    --to=michal.simek@xilinx.com \
    --cc=Markus.Elfring@web.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=vulab@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®