From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Google-Smtp-Source: AIpwx49radkw87M4I54n4XjgI9cHhQjclRitutGv/J7/OsKHuEqQCIHBnAYIYPImvR00lp+Hc2hf ARC-Seal: i=1; a=rsa-sha256; t=1523988983; cv=none; d=google.com; s=arc-20160816; b=IudBc+nmo4Tm0w7Y4AbLr66pF7rLn6kKzo45BJ9Z9wlbS5a+NhZAvyYKEydPJf5tPU P2E0HbR5iHXOAd3NHhWPxxDkm+qEyJEk+9+ic6gFA4sfOoRRxA1r7tpqOJpsAOU89eZH wPDgtWOYXJ5lbjm87OE9z4uywReuSFHLwIDtXHBKVoqB9+46WBYVfiZNQWDdnvNZmI9T d7akLhZ0/Niyaf9MjIglhIwW8I+umPQO1V3+sHE39+NBcy4dAT+7FxLqdgr4LfurS9GT /7XRPe8Xw6M2isUx/rzIMAuni7kaOK0QUYXTCwTp/SqoSIT5wa3PCRzQz7p2ofGAnUW/ Lo0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:content-language:in-reply-to:mime-version :user-agent:date:message-id:from:references:cc:to:subject :arc-authentication-results; bh=Gt8c2MC9rTa6rB94Q3r0V3ibUoij6v6v/ZKdgj5ug6g=; b=LH+RonV4b4V2KQt5d5h4VM88n/RWdrQFDBCAW5gYepY2LYjDm2BOVZ9Nl9n2vovUK9 BcZD1cQOsbJmBL3k78EBFmL4uLVT7Q0YWJZOhkFPAk9g6VSR2okO8eAzPKJMqHJ83XBm hrybHPq/4h6prIFO/IYSnDq2g7jA7/Umu73iwk8N6HL5Iz1cWrJA35VfDWi2RTGByCAK FMioklEgm03tMZmJ6ZFLccs/mpdqXq48U0/2dDFIOl1mn/5nasQ5u/AOPNZIIvWVAO2g kMCgSuNMHjsQgJvbZQAuPn+Dfx/zynipN0PGfW2yqxy7wruv+J/4oBckUr2EhQwznh/y u4gg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of jae.hyun.yoo@linux.intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=jae.hyun.yoo@linux.intel.com Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of jae.hyun.yoo@linux.intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=jae.hyun.yoo@linux.intel.com X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,464,1517904000"; d="scan'208";a="192235645" Subject: Re: [PATCH v3 04/10] Documentations: dt-bindings: Add a document of PECI adapter driver for Aspeed AST24xx/25xx SoCs To: Rob Herring Cc: Alan Cox , Andrew Jeffery , Andrew Lunn , Andy Shevchenko , Arnd Bergmann , Benjamin Herrenschmidt , Fengguang Wu , Greg KH , Guenter Roeck , Haiyue Wang , James Feist , Jason M Biils , Jean Delvare , Joel Stanley , Julia Cartwright , Miguel Ojeda , Milton Miller II , Pavel Machek , Randy Dunlap , Stef van Os , Sumeet R Pawnikar , Vernon Mauery , "linux-kernel@vger.kernel.org" , linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Linux HWMON List , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , OpenBMC Maillist References: <20180410183212.16787-1-jae.hyun.yoo@linux.intel.com> <20180410183212.16787-5-jae.hyun.yoo@linux.intel.com> <20180416181035.rcjvt4rlrwaj5yxf@rob-hp-laptop> <53ff5b2b-eba8-8311-64a9-abd4bc72226d@linux.intel.com> From: Jae Hyun Yoo Message-ID: Date: Tue, 17 Apr 2018 11:16:22 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: =?utf-8?q?1597385135853793781?= X-GMAIL-MSGID: =?utf-8?q?1598018272803865011?= X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On 4/17/2018 6:16 AM, Rob Herring wrote: > On Mon, Apr 16, 2018 at 6:12 PM, Jae Hyun Yoo > wrote: >> On 4/16/2018 11:10 AM, Rob Herring wrote: >>> >>> On Tue, Apr 10, 2018 at 11:32:06AM -0700, Jae Hyun Yoo wrote: >>>> >>>> This commit adds a dt-bindings document of PECI adapter driver for Aspeed >>>> AST24xx/25xx SoCs. > > [...] > >>>> +- clocks : Should contain clock source for PECI controller. >>>> + Should reference clkin. >>>> +- clock_frequency : Should contain the operation frequency of PECI >>>> controller >>>> + in units of Hz. >>>> + 187500 ~ 24000000 >>> >>> >>> This is the frequency of the bus or used to derive it? It would be >>> better to specify the bus frequency instead and have the driver >>> calculate its internal freq. And then use "bus-frequency" instead. >>> >> >> I agree with you. Actually, it is being used for operation frequency setting >> of PECI controller module in SoC so it's different from the meaning of >> "bus-frequency". I'll change it to "operation-frequency". > > No, now you've gone from a standard property name to something custom. > Why do you need to set the frequency in DT if it is not related to the > interface frequency? > > Rob > Actually, the interface frequency is affected by the operation frequency but there is no description of its relationship in datasheet. I'll check again about the detail to ASPEED chip vendor and will use 'bus-frequency' if available. Thanks, Jae