From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D8A8047FAE5 for ; Wed, 29 Jul 2026 12:14:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785327246; cv=none; b=TbiTGnZnBAKjj00OYWhRk8G9uGl73ztyni6UwOk0X1uBTxacS/Qz/djpHGb17ijG6bfiv0BAKEUj6A8Un7vpFuDGer8vLlSJzX0LYAkZ7Zi/OLu8/u8yISccMx+F+gPc2YfD+4PFIvE/anrhhMUCQ9282rOhLfuu0M1Wyc5lBic= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785327246; c=relaxed/simple; bh=adOZ8IdTMEdihpC3KzCA52vuQF91ikdtwyrajV90jJU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nOBXPg5UqpJEZVJpk9bWrYYBKl/R4njIpacUeshQC9aU3d8vhjjiB0hLnoM6gpQ3J2VvaTK/Sk1l4zmggxY/SDKzffYmC/3UGxvP47Zx7IbHc+U2i5FSrpPu93ARMuZ/4BWD0AUjb8hOBXfhye4LkND7rfrYKIS3slG8GhP+zmM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=a0pP44tg; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ct+3jGrE; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="a0pP44tg"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ct+3jGrE" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66TBtDTI1767784 for ; Wed, 29 Jul 2026 12:14:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DnhemxUxhzCOwZzgPx/FLXP2R0Zgl4o/iFWhHwiEHXs=; b=a0pP44tgBGaAhbfR Lf3wDoyZanTLXRENS+d/Eq4AbOj0AqBQD/aLIyrgsKrD9hb0SS2hIZf/pZlKiceY uta2ev1z8Z4g5jDcCW0swOUh7D2diGwx8HNM99CssNqzV+5e5Q5JxrP4iDn8jCcl 68IJJ6z0kz9iLWATJbCs75q+yhPw6Kk9gIOWHhJNMtdEu+dLBgWkOdLzXDSxJFdh DGUzNi1fE65sm2Yc6Lu/jur2SbRBAownu6K9xTril59o5IaB+SBVHFY1Tno0QG1v TN79giqeuG7fp9/KR/TsDBl491G0byMUaAqR1ygrVNN/9STcupzMYJH0cLH8+y3a dWJvjA== Received: from mail-pf1-f198.google.com (mail-pf1-f198.google.com [209.85.210.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fqh2kg2cc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 29 Jul 2026 12:14:03 +0000 (GMT) Received: by mail-pf1-f198.google.com with SMTP id d2e1a72fcca58-84a251c2e3eso2670717b3a.1 for ; Wed, 29 Jul 2026 05:14:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785327243; x=1785932043; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=DnhemxUxhzCOwZzgPx/FLXP2R0Zgl4o/iFWhHwiEHXs=; b=Ct+3jGrEmH49fbpSy7IYRgcVH0eebMLNi4UDBPl0DkCP19gFQRVg+nIUZqu0qnIAWZ ZXR/fPMQIZoTDXeLTj+AMgJcY0UBLV+IC8o2LsbSQ4g2KLJGFtPwsiV9j6d7q2T1Zfzu kDBL9AtMSTUEUifyCc/KeCuKwvdAMXKa3h8okdi5I5mqeJjXNppAJWvzRcPXzG49OQnr f6TRWb4b521YB7kZXXQOGy1UheZX187Bece6UrPu6HpQYWE6LsvQ/E1RSytY02YC5feQ k6Zp/tU4DfiU5bipChNI7CQkujn2Ngz/+khFXCprv6Aq/8bhZvAls2JBdFjuOzNG5qud t+/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785327243; x=1785932043; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DnhemxUxhzCOwZzgPx/FLXP2R0Zgl4o/iFWhHwiEHXs=; b=ARWWH2E6kz+1djvd16c+ndy6BqTmBg/kGzFIbKkPy7b2lx1y7h9wHBmr9KPLfj6Vh1 zNFRuE5AMgcrjcDsLaH0AGalVdpC7/GRBo7b1s7wlTitKX7txOcAw4qTjNWRj1YKqq4F qY5GE8ilhTjwqy3gRsePdPtBrNDdLTzE9/xgZbnAN74Qytc9L5QN4sE74YhcFCvKps12 8wpRbVr7BSQPVhFisCnW1hJ5QyTtNtfXzCuDi26hW61E0xTl3ybqyyumc2OeceoU6sCv EmExael5lL0Qluota1LmezwEtnYLp6ONtEa1Oj1hN8TuOp0/da0cI4iRHEcfNBSOKjxm nMpg== X-Forwarded-Encrypted: i=1; AHgh+RriYzKVGhJKnRwuq2rJycQgHd54armp/RS4pjCKUeJr0Sr+hdBSn76w+e/ROhdjvAJjf12Na6WCQ9uYYFw=@vger.kernel.org X-Gm-Message-State: AOJu0Yx0Ya6hkkzKRJzi3f/z6zIwwcuonBSjxTpYnVr2KFgQml710KVB S6oDzcY/wq71jyLz44rlAgqpRX1OkFYsl/hn4Q1YID39Ua4f6v6kyx6xjODzKYLKPiJwKqawgGp HTxwPR5AFNoUxqZx7gHZQjBRH6lx4uFE1hJtzz7uUlczUWBKEFxmWcQ9ZNq7tNDDw6uo= X-Gm-Gg: AR+sD11ZmQhWhqGOdZOW58pcUUXUjcKgC7+v3ImD2DUHl7eE5JUvqmVocLZpL7CPIl8 tW+V3pRH19OKNB67xXUo5vrs4Rp+vdfnEx5/HTuNYV27BtJYcgfD5h7q1Duikmj5vNoU5ScZZkj P8PXuET64yETcGNGbA1zUvZMnTAJJwrPPbmHMXiZtvKoM+IGxxwD/dDLC7IBhfpId40R0TJwPVb 0hEdvHtPSYDE+yrptM7bCkx95bWUY20ZyRIVSugE5vAeGFfsnqFpbZWaCbCRLY0YH8Q3+N2RvHc y1g94yM5vtHJDya3mocX51wAGF4W1Nf2mr4Ctk7E83XDGlhdzQmt4+NLvfq3UqHdhRA20g7fOLc lyMwKeRRVh5vusEm814+ZmDwCjlPu+va0tNJUWYi5CiASqRyXJEIAYfFDsAS8hurNFU49jS2GJ/ 5sRuliyuyUmGs7 X-Received: by 2002:a05:6a00:882:b0:84a:32ba:a262 with SMTP id d2e1a72fcca58-84ea7906f3cmr2145609b3a.7.1785327242652; Wed, 29 Jul 2026 05:14:02 -0700 (PDT) X-Received: by 2002:a05:6a00:882:b0:84a:32ba:a262 with SMTP id d2e1a72fcca58-84ea7906f3cmr2145569b3a.7.1785327242099; Wed, 29 Jul 2026 05:14:02 -0700 (PDT) Received: from [10.149.71.180] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-84ea0301b3csm1276886b3a.34.2026.07.29.05.13.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Jul 2026 05:14:01 -0700 (PDT) Message-ID: Date: Wed, 29 Jul 2026 17:43:51 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/8] dt-bindings: embedded-controller: qcom,hamoa-crd-ec: Add qcom,tsens To: Konrad Dybcio , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20260728-ec_add_more_commands-v1-0-771abd65ee1a@oss.qualcomm.com> <20260728-ec_add_more_commands-v1-1-771abd65ee1a@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI5MDEwMSBTYWx0ZWRfXwWn3weMY7xTo J+T/eDCfEJHMEqnjbYuq8EP0KfdlARXRdkh6EmOyi4KLpaZpa/wOc4y3F7Sk1K78gxQkTKzV6us HE+LN7v86ghibjyTkghZZw8SZ6xc+AGimwI3tZqKdlzxsb9xYGx9024oJox50aSy2mn0vuoJPuQ 9+NHk63DKlgrLlwWNdPELjVhrOWc7HFYDWXscgJvJRBBNFawNnqc7slpCdu5FxHV0wEkptecLy+ fxQTeRN7V0hRQQMzFoTBmJG0+7vuZUZJbiey7sc8bV8CSfdehbrZ5oIg2p2z0PN6ijKFx7FZBw8 EolLDLWcb9Lb7ZrLy6/M8xx4B8cPi4SQlZm9TpCCxe/cwunI0QFruw848xMZXmc5dcliI4EV8q3 zoIOJb3TkT8NinKM3ndRdHP17TQHMFi7Ai1TVEiqroR3UTPjlnWCMd9NptSmGIqZG+az9LlWn9Z CqzBasDLKfTIcNUNlNw== X-Proofpoint-GUID: EJOUTGihV7SSp29454iBZXcPx-98uZI8 X-Authority-Analysis: v=2.4 cv=Q4biJY2a c=1 sm=1 tr=0 ts=6a69ee8b cx=c_pps a=m5Vt/hrsBiPMCU0y4gIsQw==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=P4Ji7gahYyBqfBe6NxEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=IoOABgeZipijB_acs4fv:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI5MDEwMSBTYWx0ZWRfX2QVLm4lVkBw4 e7a3KQ8cH+wlglWdLb4SVLZra5ceWoBU9Vgau6T3Y0kfoGdxGOz3QLOdYvRA7IwfwcQMkc/XTqy XGSMDE35xaVws0971RxcnnHtRMV/xPg= X-Proofpoint-ORIG-GUID: EJOUTGihV7SSp29454iBZXcPx-98uZI8 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-29_04,2026-07-28_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 adultscore=0 suspectscore=0 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 spamscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607290101 On 7/29/2026 4:43 PM, Konrad Dybcio wrote: > On 7/28/26 7:44 PM, Anvesh Jain P wrote: >> Add the qcom,tsens property so Hamoa-based boards can list the tsens >> providers, and how many leading sensor IDs on each, whose readings the >> driver averages to compute the SoC junction temperature reported to >> the EC for fan control. >> >> The generic thermal-sensors property has no standard semantic for >> selecting a range of sensor IDs from a provider without enumerating >> each one, so a vendor-specific phandle-array with an explicit sensor >> count is used instead. >> >> Signed-off-by: Anvesh Jain P >> --- >> .../embedded-controller/qcom,hamoa-crd-ec.yaml | 31 ++++++++++++++++++++++ >> 1 file changed, 31 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml >> index c07483aa5937..ec809fcd03ab 100644 >> --- a/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml >> +++ b/Documentation/devicetree/bindings/embedded-controller/qcom,hamoa-crd-ec.yaml >> @@ -33,11 +33,40 @@ properties: >> interrupts: >> maxItems: 1 >> >> + # A generic "thermal-sensors" phandle only identifies individual sensor >> + # IDs, and thermal zones are a Linux-side grouping of those sensors, not >> + # a devicetree concept the EC cares about. What the driver actually needs >> + # is raw readings from a contiguous range of leading sensor IDs on each >> + # tsens provider, averaged together, so qcom,tsens pairs each provider >> + # phandle with a count instead of enumerating every sensor cell. >> + qcom,tsens: >> + description: >> + List of tsens providers and, for each, the number of leading sensor >> + IDs on that provider whose readings are averaged to compute the SoC >> + junction temperature reported to the EC for fan control. Only >> + applicable for Hamoa based devices. >> + $ref: /schemas/types.yaml#/definitions/phandle-array >> + minItems: 1 >> + maxItems: 2 >> + items: >> + items: >> + - description: phandle to a tsens thermal-sensor provider >> + - description: number of leading sensor IDs on that provider to average > > Why don't we want to look at all of the TSENS sensors? > > Konrad Each tsens provider has more physical sensors (16) than the count used here. The leading N we take exactly matches the number of sensors already wired to board thermal-zones for other purposes (CPU clusters, GPU, camera, etc.) on that provider — e.g. on hamoa, tsens2 has 11 such zones and tsens3 has 15, matching qcom,tsens = <&tsens2 11>, <&tsens3 15>;. The remaining sensor IDs aren't referenced by any thermal-zone on this platform, so there's no per-purpose reading to include in the SoC Tj average. -- Best Regards, Anvesh