From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE0BB2147F9
	for <linux-kernel@vger.kernel.org>; Tue, 19 May 2026 21:29:31 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1779226172; cv=none; b=ihxA1qQz9BOn1k/SwKo2B+gzw5pGsT0WuxacfAClERu4lEhMpR6uZm2bPXxl8eau93SOwUGVNYTfa3fafxgfkevGH2uU+TNL+XgBNFebnciaV0Bc9FUz+VkLnXtyGBAMD2krR56hWrNSpI6f7uJiZzGgvUrY+D6XTnuYqDbljaY=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1779226172; c=relaxed/simple;
	bh=lU6e/I6xAmss0TAwv2rKCunDs0j1msJdubdn9alDJL4=;
	h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References:
	 MIME-Version:Content-Type; b=jBPX8MSDkt4GO+VvEW35eY774UbQcXILOht4p5ZjJV/3Q7iP2wFN+UwazmjNyr3Vn5MahyF+9wIN9dCUacqrUlyff99R3l6RDQg8MOVEudeZCUO+/YQA3TWHaqLTPgdZRhiOEnXXXQBW7nqZKLkPQ0NrZQRVkHaHp100g7revZ4=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=mAtUme0z; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="mAtUme0z"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A4AAB1F000E9;
	Tue, 19 May 2026 21:29:30 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1779226171;
	bh=QMXRh40IUVnxLmZE2+sDE7X3HgJoRTKsMswa14DX5pQ=;
	h=Date:From:To:cc:Subject:In-Reply-To:References;
	b=mAtUme0zi7NDaYq//ogK4W36a1xFXE7ry5jtopm3g1sdUxa91DlMf5hiOeE2d1MlU
	 f19xEM9AgDqs6AymZJVBIIfdosKxeIJQKq/TEcYveT4xutY8dZB5Mgq063PTWfKaaR
	 jDJDSRA9gKp7oTfeKz5G7vmbpIBYS3TiOtRg05MUl7REwxsbyhhFhfbDAKwJY4WDif
	 waxbFFrN2nLBXrm2FCiiV0uCpEqU4Mxrzhkpp01y7rlFcSOFPknRogHaYkPDOklDnz
	 2ecVeXl1o+xYVBCoeLvrEOXLzUnb0eNx4eAv1SkIA5bpGVR/sQAm9nb0FzU/r0f25C
	 SAbCvRcn14n9Q==
Date: Tue, 19 May 2026 15:29:27 -0600 (MDT)
From: Paul Walmsley <pjw@kernel.org>
To: Florian Schmaus <florian.schmaus@codasip.com>
cc: Paul Walmsley <pjw@kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, 
    Albert Ou <aou@eecs.berkeley.edu>, Alexandre Ghiti <alex@ghiti.fr>, 
    Samuel Holland <samuel.holland@sifive.com>, 
    Andrew Jones <ajones@ventanamicro.com>, 
    Conor Dooley <conor.dooley@microchip.com>, 
    Sean Chang <seanwascoding@gmail.com>, Miaoqian Lin <linmq006@gmail.com>, 
    linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: module: Use generic cmp_int() instead of custom
 cmp_3way()
In-Reply-To: <20260512063231.708256-1-florian.schmaus@codasip.com>
Message-ID: <f0796b8a-ffc5-234e-bb9e-79e8deedf908@kernel.org>
References: <20260512063231.708256-1-florian.schmaus@codasip.com>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Tue, 12 May 2026, Florian Schmaus wrote:

> The module-sections.c file defines a custom cmp_3way() macro to perform
> 3-way comparisons during relocation sorting.
> 
> Instead of maintaining our own implementation, use the generic
> cmp_int() macro provided by the already included <linux/sort.h>. This
> removes redundant code and relies on standard kernel interfaces.
> 
> Signed-off-by: Florian Schmaus <florian.schmaus@codasip.com>

Thanks, queued for v7.2.  Looks like arm, arm64, and loongarch have the 
same problem.  Care to fix those too (in separate patches)?


- Paul