mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: K Prateek Nayak <kprateek.nayak@amd.com>,
	Breno Leitao <leitao@debian.org>
Cc: Andrea Righi <arighi@nvidia.com>, Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	Valentin Schneider <vschneid@redhat.com>,
	Christian Loehle <christian.loehle@arm.com>,
	Phil Auld <pauld@redhat.com>, Koba Ko <kobak@nvidia.com>,
	Felix Abecassis <fabecassis@nvidia.com>,
	Balbir Singh <balbirs@nvidia.com>,
	Joel Fernandes <joelagnelf@nvidia.com>,
	Shrikanth Hegde <sshegde@linux.ibm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: kmemleak: sched_domain_shared leaked on asymmetric-capacity + SCHED_CACHE
Date: Tue, 7 Jul 2026 17:31:16 +0200	[thread overview]
Message-ID: <f07a729e-ab26-4169-8dc9-a233ddf9b4e1@arm.com> (raw)
In-Reply-To: <fc6fe063-2983-4d1c-b317-382d153601bb@amd.com>

On 07.07.26 15:59, K Prateek Nayak wrote:
> Hello Breno,
> 
> On 7/7/2026 7:01 PM, Breno Leitao wrote:
>>> I may have found what might be happening. Since the last SD_SHARE_LLC
>>> and the first SD_ASYM_CPUCAPACITY_FULL overlap,
>>> init_sched_domain_shared() for SD_SHARE_LLC might just be overwriting
>>> the assignment from claim_asym_sched_domain_shared() and we are left
>>> with a non-zero refcounted shared that evades claim_allocations() but
>>> is not used anywhere either.
>>>
>>> Breno, could you try the below diff:
>>
>> Sure, I've tested it and I don't see the kmemleak report anymore, that
>> solved the issue I've raised.
>>
>> Feel free to include the following if you are planning to send it to the
>> list:
>>
>> Tested-by: Breno Leitao <leitao@debian.org>
> 
> Thanks a ton! I'll send out an official patch shortly for Peter to pick
> up once he is back from holidays after some more testing. Thank you
> again for the report and testing. Much appreciated _/\_

Switched to an Arm64 board (Juno) with {L B B L L L} where this issue
happens all the time since we rebuild the sched domain after CPU
capacity setup and EAS bringup during boot. Simple CPU hotplug also
shows it:

With additional printks:

base:

root@juno:~# dmesg | grep -i "shared\|sd->shared\|_domain"
[    0.224492] build_sched_domains() this_cpu=0
[    0.228817] build_sched_domains() cpu=0 sd=SMT
[    0.233284] claim_asym_sched_domain_shared() cpu=0 sd=SMT
[    0.238733] init_sched_domain_shared() this_cpu=0 cpu=0 flags=32
sd=MC sds=ffff00080003e800
          ^^^^^^^^^^^^^^^^
[    0.247129] build_sched_domains() cpu=0 sd=MC has SD_SHARE_LLC
[    0.252987] init_sched_domain_shared() this_cpu=0 cpu=1 flags=512
sd=MC sds=ffff00080003e7e0
          ^^^^^^^^^^^^^^^^
[    0.261460] build_sched_domains() cpu=1 sd=SMT
...
[    2.066061] free_sched_domain_shared() sds=ffff00080003e7e0 call
                                              ^^^^^^^^^^^^^^^^
kfree()


root@juno:~# echo scan > /sys/kernel/debug/kmemleak
[  104.064760] kmemleak: unreferenced object 0xffff00080003e800 (size
                                             ^^^^^^^^^^^^^^^^^^
32):
[  104.064778] kmemleak:   comm "swapper/0", pid 1, jiffies 4294892335
[  104.064786] kmemleak:   hex dump (first 32 bytes):
[  104.064793] kmemleak:     06 00 00 00 06 00 00 00 00 00 00 00 20 00
00 00  ............ ...
[  104.064800] kmemleak:     00 00 00 00 00 00 00 00 00 00 00 00 00 00
00 00  ................
[  104.064805] kmemleak:   backtrace (crc 560f497a):
root@juno:~# [  104.064809] kmemleak:     kmemleak_alloc+0x38/0x44
[  104.064825] kmemleak:     __kmalloc_cache_node_noprof+0x2bc/0x3a8
[  104.064837] kmemleak:     build_sched_domains+0x228/0x1540
[  104.064846] kmemleak:     sched_init_domains+0xd8/0x134
[  104.064859] kmemleak:     sched_init_smp+0x88/0x10c
[  104.064868] kmemleak:     kernel_init_freeable+0x14c/0x2d4
[  104.064877] kmemleak:     kernel_init+0x2c/0x130
[  104.064884] kmemleak:     ret_from_fork+0x10/0x20

w/ patch:

[    0.224451] build_sched_domains() this_cpu=0
[    0.228778] build_sched_domains() cpu=0 sd=SMT
[    0.233245] claim_asym_sched_domain_shared() cpu=0 sd=SMT
[    0.238694] init_sched_domain_shared() this_cpu=0 cpu=0 flags=32
sd=MC sds=ffff00080003e800
          ^^^^^^^^^^^^^^^^
[    0.247090] build_sched_domains() cpu=0 sd=MC has SD_SHARE_LLC
[    0.252948] init_sched_domain_shared() this_cpu=0 sd=MC
sd->shared=ffff00080003e800
[    0.252958] build_sched_domains() cpu=1 sd=SMT
...
[    2.090601] free_sched_domain_shared() sds=ffff00080003e800 call
                                              ^^^^^^^^^^^^^^^^
kfree()


Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>



  reply	other threads:[~2026-07-07 15:31 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-09 18:07 [PATCH v6 0/5 RESEND] sched/fair: SMT-aware asymmetric CPU capacity Andrea Righi
2026-05-09 18:07 ` [PATCH 1/5] sched/fair: Drop redundant RCU read lock in NOHZ kick path Andrea Righi
2026-05-11 13:04   ` Vincent Guittot
2026-05-15  6:49   ` Shrikanth Hegde
2026-05-16  5:45     ` Andrea Righi
2026-05-16 17:15       ` Shrikanth Hegde
2026-05-20  8:34   ` [tip: sched/core] " tip-bot2 for Andrea Righi
     [not found]   ` <CGME20260521194704eucas1p19ffbed79a4ae514fb1136218c567add6@eucas1p1.samsung.com>
2026-05-21 19:47     ` [PATCH 1/5] " Marek Szyprowski
2026-05-21 20:13       ` Andrea Righi
2026-05-09 18:07 ` [PATCH 2/5] sched/fair: Attach sched_domain_shared to sd_asym_cpucapacity Andrea Righi
2026-05-11 13:04   ` Vincent Guittot
2026-05-15 10:05   ` Shrikanth Hegde
2026-05-16  5:58     ` [PATCH v2 " Andrea Righi
2026-05-16 17:19       ` Shrikanth Hegde
2026-05-18 20:58       ` Peter Zijlstra
2026-05-18 21:31         ` Andrea Righi
2026-05-19  5:52         ` K Prateek Nayak
2026-05-19  6:43           ` Andrea Righi
2026-05-19  7:47             ` K Prateek Nayak
2026-05-19  7:54               ` Andrea Righi
2026-05-19  8:46           ` Peter Zijlstra
2026-05-19 11:27             ` K Prateek Nayak
2026-05-19 11:47               ` Peter Zijlstra
2026-05-25  8:30                 ` Chen, Yu C
2026-05-20  8:34       ` [tip: sched/core] " tip-bot2 for K Prateek Nayak
2026-07-03 10:22   ` kmemleak: sched_domain_shared leaked on asymmetric-capacity + SCHED_CACHE Breno Leitao
2026-07-03 10:35     ` K Prateek Nayak
2026-07-03 16:19       ` Breno Leitao
2026-07-04  6:16         ` K Prateek Nayak
2026-07-06 14:38           ` Dietmar Eggemann
2026-07-07  4:11             ` K Prateek Nayak
2026-07-07 13:31               ` Breno Leitao
2026-07-07 13:59                 ` K Prateek Nayak
2026-07-07 15:31                   ` Dietmar Eggemann [this message]
2026-05-09 18:07 ` [PATCH 3/5] sched/fair: Prefer fully-idle SMT cores in asym-capacity idle selection Andrea Righi
2026-05-11 13:07   ` Vincent Guittot
2026-05-11 13:45     ` Andrea Righi
2026-05-11 14:25     ` [PATCH v2 " Andrea Righi
2026-05-20  8:34       ` [tip: sched/core] " tip-bot2 for Andrea Righi
2026-05-09 18:07 ` [PATCH 4/5] sched/fair: Reject misfit pulls onto busy SMT siblings on asym-capacity Andrea Righi
2026-05-11 13:07   ` Vincent Guittot
2026-05-15 10:09   ` Shrikanth Hegde
2026-05-16  9:04     ` Andrea Righi
2026-05-20  8:34   ` [tip: sched/core] " tip-bot2 for Andrea Righi
2026-05-09 18:07 ` [PATCH 5/5] sched/fair: Add SIS_UTIL support to select_idle_capacity() Andrea Righi
2026-05-11 13:08   ` Vincent Guittot
2026-05-20  8:34   ` [tip: sched/core] " tip-bot2 for K Prateek Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f07a729e-ab26-4169-8dc9-a233ddf9b4e1@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=arighi@nvidia.com \
    --cc=balbirs@nvidia.com \
    --cc=bsegall@google.com \
    --cc=christian.loehle@arm.com \
    --cc=fabecassis@nvidia.com \
    --cc=joelagnelf@nvidia.com \
    --cc=juri.lelli@redhat.com \
    --cc=kobak@nvidia.com \
    --cc=kprateek.nayak@amd.com \
    --cc=leitao@debian.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=mingo@redhat.com \
    --cc=pauld@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=vschneid@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox