From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C12921DDC1D for ; Wed, 1 Oct 2025 08:31:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759307478; cv=none; b=TDEDp8CpkznQbBCaDhB5nO5mlc18r8jNXEuje1CVLRYIInpA76L3diFZPv5LaLlYXZvvxUVI58BeoyBtw4oAolkejQzFzCVbfu0fd4L3cd/5jyPrNxLaesNAq/XccKmXshw5XgLoYNsfUfh0fXqW2rEVpFYLxwvwQpBwWOdLIMg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1759307478; c=relaxed/simple; bh=rvWr+qW5iRruB8PE+IXtAXff+O7p4eTPZC0KfWJkMsg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZTxXUvHv+wNiYuj1q1TLb7IIeepslaGRadYZ8hJqf9IxsZLmuoTO78d09nRzH3NL+xvDSTX0/ACzCKnEhXAq0V/Vcf4zA0RGbkHMm5EBu6UQRtBoCaWJhDjFv7qRPuKCaQ8QXETdFQAZggG8QZVuHto+4cO7YK9badXfd4bG3Tc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=XDnLYHNF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="XDnLYHNF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1759307474; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=fbIlFATZ6UVCcGy9lyO07KqDsSW2SUYrIm+1237ezXk=; b=XDnLYHNF1A3DkYsb9Ai0MRpuAPPmToNSvyXxwTlhe02EJSfRqWd4HbCVy4H/Fcyyz0rtnj qnYDTOh2XtumIoJvwPm7px655+WaddWMOjw9hvTgiOM0MHWw/49w6ntjlSzU3iolvsT8NJ veGzA81FlIYXRme6Gwah6T1wvbfxFus= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-284-tGfYEA2yNcqbl7XkxV5FfA-1; Wed, 01 Oct 2025 04:31:13 -0400 X-MC-Unique: tGfYEA2yNcqbl7XkxV5FfA-1 X-Mimecast-MFC-AGG-ID: tGfYEA2yNcqbl7XkxV5FfA_1759307470 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-3f384f10762so4280851f8f.3 for ; Wed, 01 Oct 2025 01:31:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759307470; x=1759912270; h=content-transfer-encoding:in-reply-to:autocrypt:content-language :from:references:cc:to:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=fbIlFATZ6UVCcGy9lyO07KqDsSW2SUYrIm+1237ezXk=; b=FQw3x2/WKhbBp1aY8xQlDEsMLPsudKMTSujaT7i6KdNnNqFWGFSx34G9hqMISOnWiy 8DHqm+HhkbgizzkVwAGjpamPnLtlYqGXG9d25kZ0ACt1XRgXqKQgGSpHQet9iOp1ku2g GrDZEFpA1sBwSTdOioGgngXzkC3xOovpuPM8Oixtut6M5F0/uK0DXSjjWdhCSNgMpuUk UcSqB3s00I43P2m6JiH9UjwpxPn5InMwdSOkFD3g98yQuVnrnXBsOp5h2HYLGl92bOx/ NqYGBDaOiH5qRSvfCDsFSItOLYne4l6yuYSmhiQwZnZfB90hrc0Xjq+UOH4MZU5xHMxm 5APA== X-Forwarded-Encrypted: i=1; AJvYcCUQKQf9mW4NmRbP6b79iobfVsmImyA0DlqrZv7gG8f0wdXNtGiPjEhxeU2RTm2gdiUKFviLLbP3J2FTtO8=@vger.kernel.org X-Gm-Message-State: AOJu0YxKADd01aIjGe8exB08vH0B87DW95qq6rBWgTgrYYsWsVGONjWG Izr7EGd0dMaJhr87hxwNrevqtiIQZr6U+IpnFyvofD8Fs2C7dymRYbZLkqa8H/GVrfxTkKYNhlD Wl9ug6hbnd650N1FprponzPLPoQKenikysuhpNXRU8fHXsgc5x/UTw6dQl/+4wV5/2Q== X-Gm-Gg: ASbGncvXxGqqW0teIjSyKyEF84WKsmw0x/LAJWqFv+MPVMPt3Z6UdwxLRKfRX63kGV/ jpW2WObVjjA5yNA/hPkyo6z4rglPs0vO+gHXhv6PlSm7FVTvOXbn1AjMlHyRbXfHav86j7xPoNa jNjihrCSlEnOjc+xE6KpY/SpUVqLQAvuNlkhhoWPtC7rol2n/iyiSQWLuWPUn18WdY9S2r8gG5C 6UspPYHKNaxaCuplHWnuRIe621McF4jVuD+KmIi32mlf5ODtM3KMlU3AsTLj+KhPcGATnFOueMb EEzcqu1sDjB+rgUuBuV5vYrcXZXH/Rn2FCpIzYiKDaqQSZ7CxdI4fbNfEjSwr3DOkK0O0oYUekb WskvGzvuN X-Received: by 2002:a5d:588a:0:b0:3ec:248f:f86a with SMTP id ffacd0b85a97d-425578183aamr1941042f8f.48.1759307470279; Wed, 01 Oct 2025 01:31:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnDRo/HdWJbr5v9aDJ0k8vKbpUkQ5j+9O/NfoSAui1M83Tp2E1gqTmYLdgDjWsOAfIifq5WA== X-Received: by 2002:a5d:588a:0:b0:3ec:248f:f86a with SMTP id ffacd0b85a97d-425578183aamr1941007f8f.48.1759307469775; Wed, 01 Oct 2025 01:31:09 -0700 (PDT) Received: from [192.168.3.141] (tmo-080-144.customers.d1-online.com. [80.187.80.144]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e61a029a0sm27915195e9.13.2025.10.01.01.31.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Oct 2025 01:31:09 -0700 (PDT) Message-ID: Date: Wed, 1 Oct 2025 10:31:07 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH mm-new v2 1/1] mm/khugepaged: abort collapse scan on non-swap entries To: Lance Yang , akpm@linux-foundation.org Cc: lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, baohua@kernel.org, baolin.wang@linux.alibaba.com, dev.jain@arm.com, hughd@google.com, ioworker0@gmail.com, kirill@shutemov.name, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mpenttil@redhat.com, npache@redhat.com, ryan.roberts@arm.com, ziy@nvidia.com, richard.weiyang@gmail.com References: <20251001032251.85888-1-lance.yang@linux.dev> From: David Hildenbrand Content-Language: en-US Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZoEEwEIAEQCGwMCF4ACGQEFCwkIBwICIgIG FQoJCAsCBBYCAwECHgcWIQQb2cqtc1xMOkYN/MpN3hD3AP+DWgUCaJzangUJJlgIpAAKCRBN 3hD3AP+DWhAxD/9wcL0A+2rtaAmutaKTfxhTP0b4AAp1r/eLxjrbfbCCmh4pqzBhmSX/4z11 opn2KqcOsueRF1t2ENLOWzQu3Roiny2HOU7DajqB4dm1BVMaXQya5ae2ghzlJN9SIoopTWlR 0Af3hPj5E2PYvQhlcqeoehKlBo9rROJv/rjmr2x0yOM8qeTroH/ZzNlCtJ56AsE6Tvl+r7cW 3x7/Jq5WvWeudKrhFh7/yQ7eRvHCjd9bBrZTlgAfiHmX9AnCCPRPpNGNedV9Yty2Jnxhfmbv Pw37LA/jef8zlCDyUh2KCU1xVEOWqg15o1RtTyGV1nXV2O/mfuQJud5vIgzBvHhypc3p6VZJ lEf8YmT+Ol5P7SfCs5/uGdWUYQEMqOlg6w9R4Pe8d+mk8KGvfE9/zTwGg0nRgKqlQXrWRERv cuEwQbridlPAoQHrFWtwpgYMXx2TaZ3sihcIPo9uU5eBs0rf4mOERY75SK+Ekayv2ucTfjxr Kf014py2aoRJHuvy85ee/zIyLmve5hngZTTe3Wg3TInT9UTFzTPhItam6dZ1xqdTGHZYGU0O otRHcwLGt470grdiob6PfVTXoHlBvkWRadMhSuG4RORCDpq89vu5QralFNIf3EysNohoFy2A LYg2/D53xbU/aa4DDzBb5b1Rkg/udO1gZocVQWrDh6I2K3+cCs7BTQRVy5+RARAA59fefSDR 9nMGCb9LbMX+TFAoIQo/wgP5XPyzLYakO+94GrgfZjfhdaxPXMsl2+o8jhp/hlIzG56taNdt VZtPp3ih1AgbR8rHgXw1xwOpuAd5lE1qNd54ndHuADO9a9A0vPimIes78Hi1/yy+ZEEvRkHk /kDa6F3AtTc1m4rbbOk2fiKzzsE9YXweFjQvl9p+AMw6qd/iC4lUk9g0+FQXNdRs+o4o6Qvy iOQJfGQ4UcBuOy1IrkJrd8qq5jet1fcM2j4QvsW8CLDWZS1L7kZ5gT5EycMKxUWb8LuRjxzZ 3QY1aQH2kkzn6acigU3HLtgFyV1gBNV44ehjgvJpRY2cC8VhanTx0dZ9mj1YKIky5N+C0f21 zvntBqcxV0+3p8MrxRRcgEtDZNav+xAoT3G0W4SahAaUTWXpsZoOecwtxi74CyneQNPTDjNg azHmvpdBVEfj7k3p4dmJp5i0U66Onmf6mMFpArvBRSMOKU9DlAzMi4IvhiNWjKVaIE2Se9BY FdKVAJaZq85P2y20ZBd08ILnKcj7XKZkLU5FkoA0udEBvQ0f9QLNyyy3DZMCQWcwRuj1m73D sq8DEFBdZ5eEkj1dCyx+t/ga6x2rHyc8Sl86oK1tvAkwBNsfKou3v+jP/l14a7DGBvrmlYjO 59o3t6inu6H7pt7OL6u6BQj7DoMAEQEAAcLBfAQYAQgAJgIbDBYhBBvZyq1zXEw6Rg38yk3e EPcA/4NaBQJonNqrBQkmWAihAAoJEE3eEPcA/4NaKtMQALAJ8PzprBEXbXcEXwDKQu+P/vts IfUb1UNMfMV76BicGa5NCZnJNQASDP/+bFg6O3gx5NbhHHPeaWz/VxlOmYHokHodOvtL0WCC 8A5PEP8tOk6029Z+J+xUcMrJClNVFpzVvOpb1lCbhjwAV465Hy+NUSbbUiRxdzNQtLtgZzOV Zw7jxUCs4UUZLQTCuBpFgb15bBxYZ/BL9MbzxPxvfUQIPbnzQMcqtpUs21CMK2PdfCh5c4gS sDci6D5/ZIBw94UQWmGpM/O1ilGXde2ZzzGYl64glmccD8e87OnEgKnH3FbnJnT4iJchtSvx yJNi1+t0+qDti4m88+/9IuPqCKb6Stl+s2dnLtJNrjXBGJtsQG/sRpqsJz5x1/2nPJSRMsx9 5YfqbdrJSOFXDzZ8/r82HgQEtUvlSXNaXCa95ez0UkOG7+bDm2b3s0XahBQeLVCH0mw3RAQg r7xDAYKIrAwfHHmMTnBQDPJwVqxJjVNr7yBic4yfzVWGCGNE4DnOW0vcIeoyhy9vnIa3w1uZ 3iyY2Nsd7JxfKu1PRhCGwXzRw5TlfEsoRI7V9A8isUCoqE2Dzh3FvYHVeX4Us+bRL/oqareJ CIFqgYMyvHj7Q06kTKmauOe4Nf0l0qEkIuIzfoLJ3qr5UyXc2hLtWyT9Ir+lYlX9efqh7mOY qIws/H2t In-Reply-To: <20251001032251.85888-1-lance.yang@linux.dev> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 01.10.25 05:22, Lance Yang wrote: > From: Lance Yang > > Currently, special non-swap entries (like migration, hwpoison, or PTE > markers) are not caught early in hpage_collapse_scan_pmd(), leading to > failures deep in the swap-in logic. > > hpage_collapse_scan_pmd() > `- collapse_huge_page() > `- __collapse_huge_page_swapin() -> fails! > > As David suggested[1], this patch skips any such non-swap entries > early. If any one is found, the scan is aborted immediately with the > SCAN_PTE_NON_PRESENT result, as Lorenzo suggested[2], avoiding wasted > work. > > [1] https://lore.kernel.org/linux-mm/7840f68e-7580-42cb-a7c8-1ba64fd6df69@redhat.com > [2] https://lore.kernel.org/linux-mm/7df49fe7-c6b7-426a-8680-dcd55219c8bd@lucifer.local > > Suggested-by: David Hildenbrand > Suggested-by: Lorenzo Stoakes > Signed-off-by: Lance Yang > --- Could have mentioned you adjust the flow of code to resemble what we have in __collapse_huge_page_isolate(). Acked-by: David Hildenbrand -- Cheers David / dhildenb