mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yu Kuai <yukuai1@huaweicloud.com>
To: Pavel Machek <pavel@ucw.cz>, Yu Kuai <yukuai1@huaweicloud.com>
Cc: Eric Blake <eblake@redhat.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	josef@toxicpanda.com, linux-block@vger.kernel.org,
	nbd@other.debian.org, "yukuai (C)" <yukuai3@huawei.com>
Subject: Re: nbd: please don't spawn 16 threads when nbd is not even in use
Date: Thu, 24 Nov 2022 19:17:05 +0800	[thread overview]
Message-ID: <f07f496d-3bf7-eb84-eb90-df2d43c5c01b@huaweicloud.com> (raw)
In-Reply-To: <Y39CFnRwNGBGIsCH@duo.ucw.cz>

Hi,

在 2022/11/24 18:06, Pavel Machek 写道:
> 
> Can we get that reverted?
> 
> That is rather obscure bug (how many GFP_KERNEL failures do you
> normally see?) and it costs, dunno, 100KB? of unswappable memory.
> 

No, I don't think that can be reverted. Introduce a BUG just to save
some memory sounds insane.

If you really want to do this. I think the right thing to do is to move
the allocation of recv_workq back to start device, and also fix the
problem properly.

Thanks,
Kuai
> Best regards,
> 								Pavel
> 


      reply	other threads:[~2022-11-24 11:18 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-22 11:56 Pavel Machek
2022-11-23 20:09 ` Eric Blake
2022-11-23 22:01   ` Pavel Machek
2022-11-24  1:17     ` Yu Kuai
2022-11-24 10:06       ` Pavel Machek
2022-11-24 11:17         ` Yu Kuai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f07f496d-3bf7-eb84-eb90-df2d43c5c01b@huaweicloud.com \
    --to=yukuai1@huaweicloud.com \
    --cc=eblake@redhat.com \
    --cc=josef@toxicpanda.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nbd@other.debian.org \
    --cc=pavel@ucw.cz \
    --cc=yukuai3@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®