mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jiri Valek - 2N <jiriv@axis.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: cap11xx - stop using chip ID when configuring it
Date: Wed, 24 Jan 2024 17:57:12 +0100	[thread overview]
Message-ID: <f081bad4-2828-4d2f-bbe6-165ad2ba1655@axis.com> (raw)
In-Reply-To: <ZalnEZ83M0jlQI2s@google.com>

On 1/18/24 18:59, Dmitry Torokhov wrote:
> On Tue, Dec 12, 2023 at 09:33:58PM -0800, Dmitry Torokhov wrote:
>> struct cap11xx_hw_model is supposed to describe the chip capabilities,
>> however later code changes introduced checks against chip ID.
>>
>> Introduce new capabilities in cap11xx_hw_model and use them when applying
>> chip configuration, and remove the enum for chip ID. While at it, rename
>> no_gain to has_gain to match the rest of the new capabilities.
> 
> Jiri, if you could give this a spin on your device that would be great.
> 
> Thanks!
> 
Hi Dmitry,

thanks for changes. Looks good to me.
I verified the functionality on real HW with CAP1293.

Reviewed-by: Jiri Valek - 2N <jiriv@axis.com>



      reply	other threads:[~2024-01-24 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13  5:33 Dmitry Torokhov
2024-01-18 17:59 ` Dmitry Torokhov
2024-01-24 16:57   ` Jiri Valek - 2N [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f081bad4-2828-4d2f-bbe6-165ad2ba1655@axis.com \
    --to=jiriv@axis.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®