From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7D914215F5C for ; Mon, 7 Apr 2025 18:01:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744048875; cv=none; b=ST3Du+HR1QZItgqD4rgYWCq2aEZCh0CWCB3ICIN8P+oAkaGY33pv8fWE+jBA8eLQ6vIoFoB4nokRmx8e/qIF5raaGOoknxkp0WQ5guPFmbgagfV+4Q/FVpMPnN39j26ZhQBg7z50dNldsHNJdUWHVW+X7aFm6+AjcXgSAlTHDWw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744048875; c=relaxed/simple; bh=/sCS8P3oFfkM8Y2joQwtk/+GhkDfttep80wMIA9Oi6I=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=MHrTVJqTaxa29B39U4lbEqQlPu/FMvy1beyWwDxmF3W+Uv+BGoN+bZyxnW0rmer0roD6evxgGgXplBcXRmUVeSBXTvlsi/zPlbKeshH4CmSiJ0+8fhfbv5hoGY6wZXWKFRCxDp7HqksMB5ChvyqIVM+mOA4dS7eHQcOJDeVKTvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=UaAlCC/s; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UaAlCC/s" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3914a5def6bso2764494f8f.1 for ; Mon, 07 Apr 2025 11:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1744048871; x=1744653671; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=dQN6XEoSUCzS4EezoIiiguwwZ733hElp98GvikZveLg=; b=UaAlCC/ssZRpuNqnybDl1wxtEI3s4qVn/UvY8jRV7ExlXN+0QFhpLs41mGwToOvvnI NbtBUXIlHKMxeMVaa86iOzapveOJ3xvyuxuRM87ZrpWvkOGlKTz6l7XMLXJo6kwXsMmx ufSH20gDsA7Ga5Iw7yrp71qtKJ0+xmB0YePw9JD0SoTeGi/8RY0AcAdtvl/B/YH/vq1n w5ueJNP6B7KnvH5nkRev5W7+Bnxl88vuDarQsEiJ0GJOVeGp0aIN7vF1PGdVhUYzCWN7 pwAFQXFeWCL0XH6mX+CL0Re9PGKxKx9tvBJoJO03CdC9HAXLy7i14jl6Gbma5YBcqSyf rYrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744048871; x=1744653671; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=dQN6XEoSUCzS4EezoIiiguwwZ733hElp98GvikZveLg=; b=R0FG/QUkXDvQ7sHzPhybvh2sf2tjHhJsFDyIdVP4EW+K/3GLNW5oGy0ebC7DTakmXS RFTBfAS4Pl8lW/6vkBuojRlFf1rS4R0AwOwX6jXG12aTXKJf93N47JeTJ1ZD9Eb0w4GS gvGEJ9BgBQVD7ELtZ0xW+DUM/hA1YCspEjXgOrHeH0NRTcmwAQ/nix4IBd0U2kpIKVkp hoRcIZQagbgLBmp9jGYWkXE0ECUXm5df/qx4mB7NazfDv+NfGwzCbIO6SfxZ3I9kofmZ yu/fcur81rMxySZunMGdTFfsJoeKi+aHSCAHK1HOU/DThat+zrk5zr2lkibJPwk4etWS pFiQ== X-Forwarded-Encrypted: i=1; AJvYcCVsh9J1hBqUXD5VfZ0qzOOIA/UwIeMQ9WxhJy93j1uOGV86bP+5eYvTZFWeqMqxmzTlM3KyvwRsT2LG5c0=@vger.kernel.org X-Gm-Message-State: AOJu0YyRFBsnhhkgQeWW4iMadHmOjqoxI6kIO3UldGZkM0tc3wFolbba hyAMvToNqayMvNhQMxUr9ij0zmoE/TIii+2Ud8BayNQ3/zgWqy46ur8wY4y0D4E= X-Gm-Gg: ASbGncspafNwZKOJ9BlvNoWqM/N5PVePRaasVKokUBTlhnLtP/7FJECldz92e/PVh2k qQfiGY7cA/VIb6tVCm4D+S7XhjfgcF8Yy0zXkY/6PzMywYJGu2yXdxVdVXxgB6i6rFh65/JM74T PgQOvwtDz3wA3ywim1ECGo4q7pA08/5At5HUyQ/6xIGFbiBSDey0ntpuoJ6aVzmgdRtvZc3fkf8 Zg4qX3h2ZmE9IQaO4jIzRTietH7qJnG8PSHWsOg3Yh6w5sTe0iAzoHaOF5+BeoyauvaBSq3eFMy aMPG4Z0Kjr+SNwgNYIoZvxiLgfDvpZIawRbW8HCjAdVvjcAhu14wM0xhUkFNUutnkplnNZ/t2EA FejnAOFFZA0WUO+HCDhRaSQ== X-Google-Smtp-Source: AGHT+IFF2Y1FxHLGIXFsVRY7QrXVRey4g/u9EJsx9mznd/SmL2dCJdrLW+gsYJud45OzuRqxEedf1A== X-Received: by 2002:a05:6000:1a8d:b0:391:487f:282a with SMTP id ffacd0b85a97d-39cba93cdd3mr11366157f8f.50.1744048870736; Mon, 07 Apr 2025 11:01:10 -0700 (PDT) Received: from ?IPV6:2a01:e0a:3d9:2080:f2a4:b974:cba3:a605? ([2a01:e0a:3d9:2080:f2a4:b974:cba3:a605]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b6321sm12508357f8f.44.2025.04.07.11.01.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 07 Apr 2025 11:01:10 -0700 (PDT) Message-ID: Date: Mon, 7 Apr 2025 20:01:09 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH v3 5/5] media: platform: qcom/iris: add sm8650 support To: Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Abhinav Kumar , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Philipp Zabel Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250407-topic-sm8x50-iris-v10-v3-0-63569f6d04aa@linaro.org> <6zCwYEsWlyaz8z8Elw573sfjWDZBB46nc0IA4Eu_-pKdy3O1WzYh2sr0jdSPRr0uBHqfgMaK3WC5d9sN6-O6cA==@protonmail.internalid> <20250407-topic-sm8x50-iris-v10-v3-5-63569f6d04aa@linaro.org> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 07/04/2025 17:52, Bryan O'Donoghue wrote: > On 07/04/2025 16:24, Neil Armstrong wrote: >> Add support for the SM8650 platform by re-using the SM8550 >> definitions and using the vpu33 ops. >> >> The SM8650/vpu33 requires more reset lines, but the H.284 > > h264. > >> decoder capabilities are identical. >> >> Signed-off-by: Neil Armstrong >> --- >>   .../platform/qcom/iris/iris_platform_common.h      |  1 + >>   .../platform/qcom/iris/iris_platform_sm8550.c      | 64 ++++++++++++++++++++++ >>   drivers/media/platform/qcom/iris/iris_probe.c      |  4 ++ >>   3 files changed, 69 insertions(+) >> >> diff --git a/drivers/media/platform/qcom/iris/iris_platform_common.h b/drivers/media/platform/qcom/iris/iris_platform_common.h >> index fdd40fd80178c4c66b37e392d07a0a62f492f108..6bc3a7975b04d612f6c89206eae95dac678695fc 100644 >> --- a/drivers/media/platform/qcom/iris/iris_platform_common.h >> +++ b/drivers/media/platform/qcom/iris/iris_platform_common.h >> @@ -35,6 +35,7 @@ enum pipe_type { >> >>   extern struct iris_platform_data sm8250_data; >>   extern struct iris_platform_data sm8550_data; >> +extern struct iris_platform_data sm8650_data; >> >>   enum platform_clk_type { >>       IRIS_AXI_CLK, >> diff --git a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c >> index 35d278996c430f2856d0fe59586930061a271c3e..d0f8fa960d53367023e41bc5807ba3f8beae2efc 100644 >> --- a/drivers/media/platform/qcom/iris/iris_platform_sm8550.c >> +++ b/drivers/media/platform/qcom/iris/iris_platform_sm8550.c >> @@ -144,6 +144,10 @@ static const struct icc_info sm8550_icc_table[] = { >> >>   static const char * const sm8550_clk_reset_table[] = { "bus" }; >> >> +static const char * const sm8650_clk_reset_table[] = { "bus", "core" }; >> + >> +static const char * const sm8650_controller_reset_table[] = { "xo" }; > > > At the risk of asking a stupid question, where are these resets in your dts ? > > You're missing core here ? > > 20250407-topic-sm8x50-upstream-iris-8550-dt-v1-1-1f7ab3083f49@linaro.org This one if for sm8550, this very patch is adding support for sm8650 which needs core & xo in addition to bus Neil > > --- > bod