From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8900259499 for ; Tue, 7 Jan 2025 14:49:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261388; cv=none; b=idG9gd9h0VNvZjtoGPNncU+rU1EhEakT3h7O4g4kBRnsh+HwgNJ5i5Bwxp0iep842z/St2kVTVT3iyhBlclOGJgQLn+T2ej9eAdw25sOGy3JuLcbWX7dlX9jl2orfu9yY05Zss3zUcblOo/bBeLh4Mf06a9XZJ+/I0nYoAO+0W8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736261388; c=relaxed/simple; bh=QEG4Lt3mn+Wq0xsRQRMvQJKA2t4dMpLwC9XZ0QsUKgg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=euo7qtQUDicUujpMPahPwfMRWbJvAcsmHuoPKFdFcFPMm/kz//YviLSkYq7wlsD6ap3UUnPDY+vjng6ePfcevqwF5LzZtCWwssxn1oO2tRmJiXXeuWwn+TqsO7JUTq4Uka+iDgiuoTYL3ALw8KCp6LR5Yp1bSO0P+ZzdLiQrw8w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=AoktLoBd; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="AoktLoBd" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4361815b96cso104444745e9.1 for ; Tue, 07 Jan 2025 06:49:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1736261382; x=1736866182; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=K3u/NmEcbizgpdqDtJODTjPeBG7JBU/0LlN4PU1so0U=; b=AoktLoBdRxn2k2l8cQA27v1UUvDErCQDRqwswWyInVEC0rj04Rd4USJqq+fBK6ey4U NBDZbOM6rSx0N7iYoYHxHaiGOI1lI0fSWMsMTiml8e8v7UmD9dTrRwJ3yPWzhcSC+sDW LX8+hzuX6PKTpWgSgGOpGbJen6DsjXLHG1IW1+SyMywhrkREy0ZWXFDQNSKq+iw6hUt6 oQWuNjNpgZDrB35o5IhuE5EB12Lu9vriRhjYbQK9xkXg4+5ccRqMNAovgD7uaYwxRNIU 3X3kLxHYfu6hxo/gIIKHOr7zw1gK1bTJE2vY6XrAy4MpvYLfPrvJHp3RteE0icgrS5Ij batA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736261382; x=1736866182; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=K3u/NmEcbizgpdqDtJODTjPeBG7JBU/0LlN4PU1so0U=; b=iXN2TXwAwsSup0alo/aMvmdVoY4HXCVBBUxzZbQ6xTeOiiuIGxonm1krr0qkrHX7NI uQTW5nBkoM4KJ7YBfL3pZiu8VXFY9zT1F0xrJfK2+mLKx0gfRRZddx27ahoRRWjE4iyn cbHu7Qf206N0jxOyxGAy4GwLMI2buYfnLYhI1xoaMVtQPAR/A8lyREnyBFJR6E90iOad KBfrdZvCkhCnYQUBVzfNqLOMuKFxUtHepQpT1Y6s7PPkqn98PhyNlEaRurx/uaLeIUe0 532xDA4Om+0hjxT+UdULlKNNBiB8SLuY5a86Djs0xmHaGyAEk9Mi/IUYyeMR5VWB7Spl L60w== X-Forwarded-Encrypted: i=1; AJvYcCWdomlXK043k8QQsgxByLgozDMYecTzPES6Qw0L7vW7WTTyGiU9yD8jv4HuFUaW4r1CT460k0NfXTdhBPY=@vger.kernel.org X-Gm-Message-State: AOJu0YxSd6JzE8N/q7r279pb22tpOeWGGFBFK2k2kyMPjKNyt3KV95Kx lMuZqZ6e2xzgkmalopAWJyRmyHHmzumlYb2HKLPbTagX1IP7KC5qT4DUj7j1acA= X-Gm-Gg: ASbGncsTinPTLaS3XB8vQa+VIUVbW0zt9WPTA9zJp58gJswygIvFCAxJH4t8d9wwe+R HcrceUA1FepIlTJRMJ2yhyl9t/fChlGp60/t1z0mTLG0QfFNmlrt9YfGXfKVTy+qWwfE4t3txCi w4Vf2yyojWniJfC0IecUIJpW/SO9FiifSrTIUfTblyIDzrx8B3VaZfwregvqzLaqp9jR+Xpkqul YRyyo1y9d3uoj715XjhvPp84rgEI+y6WSPWeFJ4TXO081eI7H5azLE6sIWfb957JpA= X-Google-Smtp-Source: AGHT+IFGvFPkSlYeeurN8gZ+h8Ez+4npmK5Z8xyVNs2V2PckDfXpluAxmlP4Ufddd+X9OkHCgV4ZkA== X-Received: by 2002:a05:600c:3b24:b0:436:2923:d23a with SMTP id 5b1f17b1804b1-43668b7a683mr422892985e9.33.1736261382081; Tue, 07 Jan 2025 06:49:42 -0800 (PST) Received: from [192.168.68.163] ([145.224.66.180]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-436dd11d8b4sm15046065e9.1.2025.01.07.06.49.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2025 06:49:41 -0800 (PST) Message-ID: Date: Tue, 7 Jan 2025 14:49:40 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/3] perf test: Update ftrace test to use --graph-opts To: Namhyung Kim Cc: Jiri Olsa , Adrian Hunter , Peter Zijlstra , Ingo Molnar , LKML , linux-perf-users@vger.kernel.org, Thomas Richter , Arnaldo Carvalho de Melo , Ian Rogers , Kan Liang References: <20250103231630.928815-1-namhyung@kernel.org> <20250103231630.928815-3-namhyung@kernel.org> Content-Language: en-US From: James Clark In-Reply-To: <20250103231630.928815-3-namhyung@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 03/01/2025 11:16 pm, Namhyung Kim wrote: > I found it failed on machines with limited memory because 16M byte > per-cpu buffer is too big. The reason it added the option is not to > miss tracing data. Thus we can limit the data size by reducing the > function call depth instead of increasing the buffer size to handle the > whole data. > > As it used the same option in the test_ftrace_trace() and it was able > to find the sleep function, it should work with the profile subcommand. > > Get rid of other grep commands which might be affected by the depth > change. > > Cc: Thomas Richter > Signed-off-by: Namhyung Kim > --- > tools/perf/tests/shell/ftrace.sh | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > Reviewed-by: James Clark > diff --git a/tools/perf/tests/shell/ftrace.sh b/tools/perf/tests/shell/ftrace.sh > index 2df05052c324a21c..c243731d2fbf67aa 100755 > --- a/tools/perf/tests/shell/ftrace.sh > +++ b/tools/perf/tests/shell/ftrace.sh > @@ -67,11 +67,8 @@ test_ftrace_latency() { > > test_ftrace_profile() { > echo "perf ftrace profile test" > - perf ftrace profile -m 16M sleep 0.1 > "${output}" > + perf ftrace profile --graph-opts depth=5 sleep 0.1 > "${output}" > grep ^# "${output}" > - grep sleep "${output}" > - grep schedule "${output}" > - grep execve "${output}" > time_re="[[:space:]]+1[[:digit:]]{5}\.[[:digit:]]{3}" > # 100283.000 100283.000 100283.000 1 __x64_sys_clock_nanosleep > # Check for one *clock_nanosleep line with a Count of just 1 that takes a bit more than 0.1 seconds