From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90E7CCDB482 for ; Wed, 18 Oct 2023 13:42:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231784AbjJRNm6 (ORCPT ); Wed, 18 Oct 2023 09:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231582AbjJRNmr (ORCPT ); Wed, 18 Oct 2023 09:42:47 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BC7D410F for ; Wed, 18 Oct 2023 06:42:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697636525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SK4S43IHlmF4EFyh15THtbxj/W0Jb2/UfHyPZ4GJTqE=; b=jQYL3FACK3SVPU++LK/l3ec/W6cGQHrDJauL/CfBxYUX9rGipF35HEYDtToWpsmuNkQPaI arbC/+ovlJMXVdh1+OjrdWCt3E8AIcJE7ieGHx2vjL4fc0dIH8LE7IQM3P4jIEEIGQthmb zVjJ2ATsalf2Yjpo+SVGBIbfzl/eLqg= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-256-4tCOJONpNZqwDQD7x5P0Zw-1; Wed, 18 Oct 2023 09:41:53 -0400 X-MC-Unique: 4tCOJONpNZqwDQD7x5P0Zw-1 Received: by mail-ed1-f70.google.com with SMTP id 4fb4d7f45d1cf-53db0df5b7cso5662281a12.1 for ; Wed, 18 Oct 2023 06:41:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697636512; x=1698241312; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SK4S43IHlmF4EFyh15THtbxj/W0Jb2/UfHyPZ4GJTqE=; b=UOBD7VqQwQjvHq4d9ywmnVqV2eTplrxBZq+nNSkYYBT+6WokREGnccZ6VXlo0118It 8iJX6Tq3GJnPEPkYeFDWrIuzUl/IImHnrB0Di+En/WYu2dXlQ3WPBcmdbaTbMhWhEPW7 wr35KkaFn/fsSRHu1ovL5FSmL4ixUiFn6MPR+fNFdrtNeCngXbU1B9pyunoGdlAywW9u rkcNWmoBTVwsolNAIb8A24OgKJZQJrmbU78sJIZuJUrUSLlzyLRsqqHhr6gVujC1eV+t E/2lcR3RiB6sfQEq9aoG+PvVhMnZu95JblAf7xH4U8rOeFCp8joph86epApwtZ3Z2xtT Jvxw== X-Gm-Message-State: AOJu0YyMAPLScH3oeAvLN4pMTXYZ52hNKnSrMEDFo0DjBPcvu40wWhS0 Ro9jGpODh5Q3mZXnH7FW1qi/yMoGrHDYrd+AGtDv0KNkIKXcQ02aY1FdhMIvlzOaAkAXV1nqvhS AwiePkHRXBC7W3FqvkGPV/QZZ X-Received: by 2002:a05:6402:40d0:b0:53e:2af1:e966 with SMTP id z16-20020a05640240d000b0053e2af1e966mr4813597edb.1.1697636512702; Wed, 18 Oct 2023 06:41:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEbfRLmV3HcaMlvTLlgoeZtSny2aGLcRuG+gXxjIoyNiH2+Bv7O/IFtGCUm/O675WpbzIvUZA== X-Received: by 2002:a05:6402:40d0:b0:53e:2af1:e966 with SMTP id z16-20020a05640240d000b0053e2af1e966mr4813579edb.1.1697636512402; Wed, 18 Oct 2023 06:41:52 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id s26-20020a056402037a00b00532eba07773sm2816133edw.25.2023.10.18.06.41.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 06:41:51 -0700 (PDT) Message-ID: Date: Wed, 18 Oct 2023 15:41:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v2] platform/mellanox: mlxbf-tmfifo: Fix a warning message Content-Language: en-US, nl To: Liming Sun , Vadim Pasternak , David Thompson , Mark Gross , Dan Carpenter Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20231012230235.219861-1-limings@nvidia.com> From: Hans de Goede In-Reply-To: <20231012230235.219861-1-limings@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/13/23 01:02, Liming Sun wrote: > This commit fixes the smatch static checker warning in function > mlxbf_tmfifo_rxtx_word() which complains data not initialized at > line 634 when IS_VRING_DROP() is TRUE. > > Signed-off-by: Liming Sun > --- > v1->v2: Logic adjustment for Hans's comment > - Adjust the logic to avoid confusion. Thank you for your patch/series, I've applied this patch (series) to the pdx86 fixes branch: https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=fixes I will include this patch in my next fixes pull-req to Linus for the current kernel development cycle. Regards, Hans > v1: Initial version. > --- > drivers/platform/mellanox/mlxbf-tmfifo.c | 21 +++++++++++---------- > 1 file changed, 11 insertions(+), 10 deletions(-) > > diff --git a/drivers/platform/mellanox/mlxbf-tmfifo.c b/drivers/platform/mellanox/mlxbf-tmfifo.c > index f3696a54a2bd..d9615ad60012 100644 > --- a/drivers/platform/mellanox/mlxbf-tmfifo.c > +++ b/drivers/platform/mellanox/mlxbf-tmfifo.c > @@ -607,24 +607,25 @@ static void mlxbf_tmfifo_rxtx_word(struct mlxbf_tmfifo_vring *vring, > > if (vring->cur_len + sizeof(u64) <= len) { > /* The whole word. */ > - if (!IS_VRING_DROP(vring)) { > - if (is_rx) > + if (is_rx) { > + if (!IS_VRING_DROP(vring)) > memcpy(addr + vring->cur_len, &data, > sizeof(u64)); > - else > - memcpy(&data, addr + vring->cur_len, > - sizeof(u64)); > + } else { > + memcpy(&data, addr + vring->cur_len, > + sizeof(u64)); > } > vring->cur_len += sizeof(u64); > } else { > /* Leftover bytes. */ > - if (!IS_VRING_DROP(vring)) { > - if (is_rx) > + if (is_rx) { > + if (!IS_VRING_DROP(vring)) > memcpy(addr + vring->cur_len, &data, > len - vring->cur_len); > - else > - memcpy(&data, addr + vring->cur_len, > - len - vring->cur_len); > + } else { > + data = 0; > + memcpy(&data, addr + vring->cur_len, > + len - vring->cur_len); > } > vring->cur_len = len; > }