mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Finn Thain <fthain@linux-m68k.org>
To: Mike Rapoport <rppt@kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	Stephen Walsh <vk3heg@vk3heg.net>,
	John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Cc: linux-m68k@lists.linux-m68k.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: mm: Move initrd phys_to_virt handling after paging_init()
Date: Tue, 28 Feb 2023 09:48:41 +1100 (AEDT)	[thread overview]
Message-ID: <f0877485-16df-1bda-c935-5ef56afacc8d@linux-m68k.org> (raw)
In-Reply-To: <dff216da09ab7a60217c3fc2147e671ae07d636f.1677528627.git.geert@linux-m68k.org>

On Mon, 27 Feb 2023, Geert Uytterhoeven wrote:

> When booting with an initial ramdisk on platforms where physical memory
> does not start at address zero (e.g. on Amiga):
> 
>     initrd: 0ef0602c - 0f800000
>     Zone ranges:
>       DMA      [mem 0x0000000008000000-0x000000f7ffffffff]
>       Normal   empty
>     Movable zone start for each node
>     Early memory node ranges
>       node   0: [mem 0x0000000008000000-0x000000000f7fffff]
>     Initmem setup node 0 [mem 0x0000000008000000-0x000000000f7fffff]
>     Unable to handle kernel access at virtual address (ptrval)
>     Oops: 00000000
>     Modules linked in:
>     PC: [<00201d3c>] memcmp+0x28/0x56
> 
> As phys_to_virt() relies on m68k_memoffset and module_fixup(), it must
> not be called before paging_init().  Hence postpone the phys_to_virt
> handling for the initial ramdisk until after calling paging_init().
> 

Thanks for debugging this issue.

> While at it, reduce #ifdef clutter by using IS_ENABLED() instead.
> 
> Fixes: 376e3fdecb0dcae2 ("m68k: Enable memtest functionality")

I apologise for the trouble caused by that patch.

  reply	other threads:[~2023-02-27 22:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 20:14 Geert Uytterhoeven
2023-02-27 22:48 ` Finn Thain [this message]
2023-02-28  7:48   ` Geert Uytterhoeven
2023-02-28  9:47     ` Finn Thain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0877485-16df-1bda-c935-5ef56afacc8d@linux-m68k.org \
    --to=fthain@linux-m68k.org \
    --cc=geert@linux-m68k.org \
    --cc=glaubitz@physik.fu-berlin.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=rppt@kernel.org \
    --cc=vk3heg@vk3heg.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®