From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E1C4C433E0 for ; Thu, 21 Jan 2021 07:25:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 039DE23788 for ; Thu, 21 Jan 2021 07:25:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727247AbhAUHZH (ORCPT ); Thu, 21 Jan 2021 02:25:07 -0500 Received: from mail.kernel.org ([198.145.29.99]:40560 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727228AbhAUHUC (ORCPT ); Thu, 21 Jan 2021 02:20:02 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 462E5239D0; Thu, 21 Jan 2021 07:18:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1611213508; bh=x28SiU6l6j7WY3/WuLOb8FaTKIg2knDGi8jFvYYTrbo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EGaDM58hfJN9YE84ayR73e9cGjciWAu/pxtNF113RFQahEnMaag+vc+ZXhtjuzQPt o/VFU/XI3ZGKdp8ySYW9Ez+Lcecv49QkTkaeZn7bCKs/FqReozcJ0Y1b1lI4VI9E2S 4EQSCBuR/idN6sZxl/nL61I5tgYd0K2KQYpXai9hSwoqlDoYSpm4zyr40xugcykgLk 4YPBn1rQAtD5BH6zMaD37XFKRSBfjq+oyUcH65xmsyqpqLSdiaCH4A74OOtXNAhtt0 JsJ2kWStqvGMGy45m+Yxy3BFhWPcll8jjhHAgNPgxtu/XqL57VJpGmRkPduy7YjKtN cOo7VH4azm+6Q== Received: by mail.kernel.org with local (Exim 4.94) (envelope-from ) id 1l2UEb-004BsK-KG; Thu, 21 Jan 2021 08:18:25 +0100 From: Mauro Carvalho Chehab To: Mark Brown , Lee Jones Cc: Mauro Carvalho Chehab , Greg Kroah-Hartman , Mayulong , devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 12/21] staging: hikey9xx: hi6421v600-regulator: fix get_optimum_mode Date: Thu, 21 Jan 2021 08:18:14 +0100 Message-Id: X-Mailer: git-send-email 2.29.2 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: Mauro Carvalho Chehab Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org During the driver refactor, a regression broke the logic inside hi6421_spmi_regulator_get_optimum_mode(). Basically, if a LDO has eco_uA == 0, it doesn't support economic mode. So, it should return REGULATOR_MODE_NORMAL. If economic mode is supported, it can return either REGULATOR_MODE_IDLE or REGULATOR_MODE_NORMAL, depending on the load current. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/hikey9xx/hi6421v600-regulator.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/hikey9xx/hi6421v600-regulator.c b/drivers/staging/hikey9xx/hi6421v600-regulator.c index 9f096d4e46db..382a0b21643e 100644 --- a/drivers/staging/hikey9xx/hi6421v600-regulator.c +++ b/drivers/staging/hikey9xx/hi6421v600-regulator.c @@ -206,7 +206,7 @@ hi6421_spmi_regulator_get_optimum_mode(struct regulator_dev *rdev, { struct hi6421_spmi_reg_info *sreg = rdev_get_drvdata(rdev); - if (load_uA || ((unsigned int)load_uA > sreg->eco_uA)) + if (!sreg->eco_uA || ((unsigned int)load_uA > sreg->eco_uA)) return REGULATOR_MODE_NORMAL; return REGULATOR_MODE_IDLE; -- 2.29.2