From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751949AbdJDLsP (ORCPT ); Wed, 4 Oct 2017 07:48:15 -0400 Received: from foss.arm.com ([217.140.101.70]:60514 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbdJDLsO (ORCPT ); Wed, 4 Oct 2017 07:48:14 -0400 Cc: Sudeep Holla , ALKML , LKML , DTML , Roy Franz , Harb Abdulhamid , Nishanth Menon , Loc Ho , Alexey Klimov , Ryan Harkin , Jassi Brar Subject: Re: [PATCH v3 16/22] firmware: arm_scmi: add arm_mhu specific mailbox interface To: Arnd Bergmann References: <1506604306-20739-1-git-send-email-sudeep.holla@arm.com> <1506604306-20739-17-git-send-email-sudeep.holla@arm.com> From: Sudeep Holla Organization: ARM Message-ID: Date: Wed, 4 Oct 2017 12:48:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/10/17 12:36, Arnd Bergmann wrote: > On Thu, Sep 28, 2017 at 3:11 PM, Sudeep Holla wrote: >> This patch adds ARM MHU specific mailbox interface for SCMI. >> >> Cc: Arnd Bergmann >> Signed-off-by: Sudeep Holla > > This clearly needs an explanation why we need another driver. > Yes, I understand. I myself is not convinced that we need one. Jassi disagrees to add support to use each bit as doorbell in the ARM MHU driver though the MHU specification states it clearly(3.4.4 Message Handling Unit (MHU) of Juno TRM)[1]. This shim was added to deal with that with I agree is wrong IMO but Jassi thinks that's right way to deal with it. -- Regards, Sudeep [1] http://infocenter.arm.com/help/topic/com.arm.doc.ddi0515f/DDI0515F_juno_arm_development_platform_soc_trm.pdf