From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70DBC1E9B35 for ; Thu, 7 May 2026 15:36:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168214; cv=none; b=SQytmq5kdNihcl4OsDqBmb2TOujXx3iK/pGhITd1pBSPy1fQOq8X5OOntz+o0bjh1a3uQ9T73St5H/npbbLYfCnx5j1ry7r7jgvTmsoaCAZ/QPpSxPUWCuM1hjvDfL6ZbwktcxMtWB65Bkvc9xs9xcM/TYh2QKrw6EFSoSBy5d0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778168214; c=relaxed/simple; bh=39Cd0XB/f3Lw8q8C/99dYqS2zLHkZ/m/EsX89jRtohE=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=PLgVS07pUp08XjhEAYbzA0JNUiIeQo0kH521wBU1idGZZZ54xGs1dFOU0Oue2blW1LYu3iZp8gxYqYxxXPVNrnPzuovJVzef+ASPDnwwmW3wsRoIjNf1r8lQkEtd3OudqAUKaavSEH/DqM3i6QRgxzxLYqvhbdAeQTM9Zq2dtro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=rw8HHpAi; arc=none smtp.client-ip=209.85.128.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rw8HHpAi" Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-48d146705b4so12567925e9.3 for ; Thu, 07 May 2026 08:36:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778168212; x=1778773012; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=TC+WcOmSnmbCmszuAYvNK3p+hdwx02QbAixg42UI5rI=; b=rw8HHpAiQ60ppWh00C8IpAsTr3mvyiZTEX8sNAIY/IM2VTKq6lbp8lCtHFJWPMmFmv oZHHROGGFQiV9RpVhR6ZFGUShTHFSYWZTWJRCF/rQcPn/xV6WDAl4tt74hgGHD8jH06y wlESIl065Nc6+LThjSXzj51S8/wpNbTu2Q40vNtTI+VCzQpbTCwGMu0NvgItIknSyKwP q6K7BJmRU9K4Ja+m0YAAMTHP7T1BxSfS6JxKZNnFl16tOUY60xHeVB9ZdJ2GD49QaIJU c7Z2bHN/HcijKMAMbn0VBkww9qrHFqRBktLCXfH56RZ1n/szcoMedeTwz/7VobN3+CBH STiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778168212; x=1778773012; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TC+WcOmSnmbCmszuAYvNK3p+hdwx02QbAixg42UI5rI=; b=NRCWaBF1LQdFswQS4QTNzn7gX8DxIx3LnsVekn2il8zWT77lnx1FPX2rkf3h2UiT19 6lXYBCDnwETZb41LTo+y5oMepvm/OIjowqB+IszWCri4XeoYeFFrNBNuXBTpiNU++GNT zrtxHmt+4XQ2Ca12WKTF8O7xZGktJRh61W9s57GM9VkQ97W/IWzKblPdlPLtnch4PD29 BjDKaxmwmVqNjvrV/hOj9BPDQJl6Hx3d8+c7kc8yXXVwvmAGuuspilnYaqqCm+WGJ6Nr E8dZIoqS02zR8RqhtbycZ62mZu/7v9pyZcgQ2+8BiIa0vA8f3SnY2LftEmTDK+l5WKMV wxTw== X-Forwarded-Encrypted: i=1; AFNElJ/ryGNKUXhme/i1ZgqApVPg0vvbq1gTgobgen1DjzpQg+zSNwaXphw8r8Knf37mV1DcMMkQIReZRN7JDfw=@vger.kernel.org X-Gm-Message-State: AOJu0YzvdGpFNQTCLkhZtlAt6CJ5gDz5BxqRwF7fugI+Twch1uDt5H3U 9xL+FP8tcTY+IBntLfgPHwIwdUQB6LCWPqDqqDgrmraUQI7TNO6RS90ju2hYHINrg8U= X-Gm-Gg: AeBDievF60ahqB4J5KrhTzKGpzJQy0cfp55HFSDSYdA8MbORRwLMfxJWaGCiDMevSpe nC8hIsuQH3GtI8vNXM7HnyrXk5rc4BiNhauC2BcGHNEU2QrGFdVBF8dg0uWSKYX7KbKiunYhPVo HKbl/ZcWXv0uONFCRxgR0jBIx9BgCeBgpafs38QsHLIPJ3oXFfhCQQoNVrNjyox3vg0ePsMWRGh l7UGY6SaTmbEsDmsCfpVAwoP7pcOe8Ze/zxOXEXUW/iK634KB5uywmTdWeUe4VEEASfQIqgGxhd fxomNuto9Lc+O/Yc/h/HA7/jqArJH2dwG2q8Rex8+gia6A3HVwLfTnW7xI7f21ovDDwerQLP3L2 eP07Jze+NcIAj0afiNKpcYOxsc05Wqdetfuq0FsEAGZT+kuRdgcTCq9hY6SqL9G1rKV2zMVVi7n Gu3aQbouN4bJMA7HgtQrzwQzAglZxp4lrkjhAexWE0wy/wzrNk2tBgpdMJw84h3W/M4l9LMWQpm WclXVlXc2gW9zeCsAlq7xKrVrOc X-Received: by 2002:a05:600c:1d18:b0:48a:906b:14ca with SMTP id 5b1f17b1804b1-48e51f46e46mr136818815e9.20.1778168211126; Thu, 07 May 2026 08:36:51 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:6762:47bb:1e06:ff70? ([2a01:e0a:106d:1080:6762:47bb:1e06:ff70]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e5389da63sm133465345e9.4.2026.05.07.08.36.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 08:36:50 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 17:36:49 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH 07/10] drm/panel/sharp-ls043t1le01: Use refcounted allocation in place of devm_kzalloc() To: Albert Esteve , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Michael Tretter , Michael Walle , Dario Binacchi Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260507-drm_panel_init_rm-v1-0-51f448c7c291@redhat.com> <20260507-drm_panel_init_rm-v1-7-51f448c7c291@redhat.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260507-drm_panel_init_rm-v1-7-51f448c7c291@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/7/26 13:53, Albert Esteve wrote: > Move to using the new API devm_drm_panel_alloc() to allocate the > panel. In the call to the new API, avoid using explicit type and use > __typeof() for more type safety. > > Signed-off-by: Albert Esteve > --- > drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c > index dd1eaba23ad3c..989b030ea22de 100644 > --- a/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c > +++ b/drivers/gpu/drm/panel/panel-sharp-ls043t1le01.c > @@ -199,8 +199,6 @@ static int sharp_nt_panel_add(struct sharp_nt_panel *sharp_nt) > gpiod_set_value(sharp_nt->reset_gpio, 0); > } > > - drm_panel_init(&sharp_nt->base, &sharp_nt->dsi->dev, > - &sharp_nt_panel_funcs, DRM_MODE_CONNECTOR_DSI); > sharp_nt->base.prepare_prev_first = true; > > ret = drm_panel_of_backlight(&sharp_nt->base); > @@ -231,9 +229,12 @@ static int sharp_nt_panel_probe(struct mipi_dsi_device *dsi) > MIPI_DSI_CLOCK_NON_CONTINUOUS | > MIPI_DSI_MODE_NO_EOT_PACKET; > > - sharp_nt = devm_kzalloc(&dsi->dev, sizeof(*sharp_nt), GFP_KERNEL); > - if (!sharp_nt) > - return -ENOMEM; > + sharp_nt = devm_drm_panel_alloc(&dsi->dev, __typeof(*sharp_nt), base, > + &sharp_nt_panel_funcs, > + DRM_MODE_CONNECTOR_DSI); > + > + if (IS_ERR(sharp_nt)) > + return PTR_ERR(sharp_nt); > > mipi_dsi_set_drvdata(dsi, sharp_nt); > > Reviewed-by: Neil Armstrong Thanks, Neil