From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9B0C433ED for ; Fri, 30 Apr 2021 15:14:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8700A6143D for ; Fri, 30 Apr 2021 15:14:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbhD3PPJ (ORCPT ); Fri, 30 Apr 2021 11:15:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57374 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbhD3PPI (ORCPT ); Fri, 30 Apr 2021 11:15:08 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30948C06174A; Fri, 30 Apr 2021 08:14:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:Content-Type: In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender :Reply-To:Content-ID:Content-Description; bh=vkFMbuZAZ/puHNl5B/OrVt67vNKKlW694NLPue0ybHQ=; b=ETJkd5rAALSRQHU96f9wHczJ8n crIsJrjDIqi0M3Sz0s+TmvfaaZA4Im+odul9V3kDkkpfNrES2O6RNjIXoE9COlGx15bsdneNDusI3 xSFURWW+3+Pyfew+b6/Y6++J4oUVSk+bDptDGUl6IZ7J9eWhHWmjjm3kQyeX+TiORTiNGIKTInrRc +f0ot2Jc8dOjciAtk5QzP1k6K+5BfQ+6iMpzZkqShdol6XpvSqgH9nO33QM5vLrqiHzq/DtlNd2D6 BvNiw29R8vlCrnVxj5KRpUfKOsfzdVb1LMw+2Dk3nWHJ01o/Hfkr1NtyKzIc4bg4Tc8TWwsgPkUv+ Zp2FrHOg==; Received: from [2601:1c0:6280:3f0::df68] by casper.infradead.org with esmtpsa (Exim 4.94 #2 (Red Hat Linux)) id 1lcUpR-00BBpW-Tk; Fri, 30 Apr 2021 15:13:27 +0000 Subject: Re: [PATCH net-next v1 1/1] net: selftest: provide option to disable generic selftests To: Oleksij Rempel , Shawn Guo , Sascha Hauer , Andrew Lunn , Florian Fainelli , Heiner Kallweit , Fugang Duan Cc: Geert Uytterhoeven , kernel@pengutronix.de, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-imx@nxp.com, Fabio Estevam , David Jander , Russell King , Philippe Schenker References: <20210430095308.14465-1-o.rempel@pengutronix.de> From: Randy Dunlap Message-ID: Date: Fri, 30 Apr 2021 08:13:12 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210430095308.14465-1-o.rempel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/30/21 2:53 AM, Oleksij Rempel wrote: > Some systems may need to disable selftests to reduce kernel size or for > some policy reasons. This patch provide option to disable generic selftests. > > Reported-by: Geert Uytterhoeven > Fixes: 3e1e58d64c3d ("net: add generic selftest support") > Signed-off-by: Oleksij Rempel > --- > net/Kconfig | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/net/Kconfig b/net/Kconfig > index f5ee7c65e6b4..dac98c73fcd8 100644 > --- a/net/Kconfig > +++ b/net/Kconfig > @@ -431,7 +431,12 @@ config SOCK_VALIDATE_XMIT > > config NET_SELFTESTS > def_tristate PHYLIB > + prompt "Support for generic selftests" > depends on PHYLIB && INET > + help > + These selftests are build automatically if any driver with generic built > + selftests support is enabled. This option can be used to disable > + selftests to reduce kernel size. > > config NET_SOCK_MSG > bool > Thanks for the patch/option. But I think it should just default to n, not PHYLIB. -- ~Randy