From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF263C04A95 for ; Thu, 29 Sep 2022 07:26:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235012AbiI2H0r (ORCPT ); Thu, 29 Sep 2022 03:26:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42012 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234740AbiI2H0m (ORCPT ); Thu, 29 Sep 2022 03:26:42 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C59AF12DED8 for ; Thu, 29 Sep 2022 00:26:41 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id b6so571537ljr.10 for ; Thu, 29 Sep 2022 00:26:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=0QojmCv3XyXLKahc21RdevQ8wm/OGlW2KEduxpTikTs=; b=wj/ZggVGLQtSixwm02m62S1QU56czuifNAbMW0uaoSWTSgIY88zBE7WzHbcVHxE7sA 2FAIWDeeIHOV+PFJipkXix2JHOJBwaywfwqkgtDrxQHoyUyLGT1kXMdFNL6m6/p9FiwO aZLSEQRKIH0BMN2E+0ILif3JZ2DNBYFzPrarDo5Tv3BmNFHXcYqrjhGB1rhRlhNWnkJu u8rBPdYmiP4ZpErdmSQ+4pTzGUgs/Uy27Y/s++DCn/wFhqHE+usYbSM9XHX63/JrcVWl uuwqCPhM6BceXJZf06e/t2+LuO/g2jp/dr23oBT8jKV1tHZ5xQ7g813HW+Aokwe/p1rO eaXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=0QojmCv3XyXLKahc21RdevQ8wm/OGlW2KEduxpTikTs=; b=J7L+6OD7uFswPwSkeXEf2r7UArLinTJ1H522NWYfSjkW9Ij2kl6C0x9WIs/tMoRcPy TutGBeICerCurr5juV0QwQz2ObDnGI2cl1csDHj3tlsmQF0WE2B1FPPChqW/j2dRgFq4 DWM2me/nJcgVB+fzkNunzjdD80JGpNTFB8sOYWDpj2kNbQL+OxkEczQPULC/pehvyJgE OKmmvt9UO/9orWBLLyP+If6t4eqIR08Xnic6Lk/iGuE6JJETUFbQnm8kaPpfmprC0Swj 13jKnUVDGuCx1yx300jMe9ekXecdZbR7Mqtifx7VqbXQ9DYnnwVdC28ZpFLyIfQ5efzR b4Xw== X-Gm-Message-State: ACrzQf0B0T1ttgreEdCnfv/9c+V0jKQNDzB6N6goqldasZuXaD2Gz6Rn +7gIEKzGVLVYamQrvSpcjOu5dQ== X-Google-Smtp-Source: AMsMyM7bMSu6MsJnPv+Ov3YJTIFzSVfDQHgLZ3onZn0YpYET5Phht0XophDhqVt78myNxyQcu5j9yw== X-Received: by 2002:a2e:9bcf:0:b0:26c:5a9d:531f with SMTP id w15-20020a2e9bcf000000b0026c5a9d531fmr610851ljj.144.1664436399972; Thu, 29 Sep 2022 00:26:39 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id g5-20020a2eb5c5000000b0026bfc8d4bbbsm632153ljn.125.2022.09.29.00.26.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 00:26:39 -0700 (PDT) Message-ID: Date: Thu, 29 Sep 2022 09:26:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH net-next 1/2] nfc: s3fwrn5: fix order of freeing resources Content-Language: en-US To: Dmitry Torokhov , Krzysztof Opasiak Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220929050426.955139-1-dmitry.torokhov@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220929050426.955139-1-dmitry.torokhov@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 29/09/2022 07:04, Dmitry Torokhov wrote: > Caution needs to be exercised when mixing together regular and managed > resources. In case of this driver devm_request_threaded_irq() should > not be used, because it will result in the interrupt being freed too > late, and there being a chance that it fires up at an inopportune > moment and reference already freed data structures. Non-devm was so far recommended only for IRQF_SHARED, not for regular ones. Otherwise you have to fix half of Linux kernel drivers... why is s3fwrn5 special? Please use scripts/get_maintainers.pl to Cc also netdev folks. > > Signed-off-by: Dmitry Torokhov > --- > drivers/nfc/s3fwrn5/i2c.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Best regards, Krzysztof