From: Marek Szyprowski <m.szyprowski@samsung.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-debug: ensure mappings are created and released with matching attributes
Date: Wed, 25 Mar 2026 21:54:59 +0100 [thread overview]
Message-ID: <f09c9c3e-ae11-440d-b36e-b88fd4645648@samsung.com> (raw)
In-Reply-To: <20260325175622.GS814676@unreal>
On 25.03.2026 18:56, Leon Romanovsky wrote:
> On Wed, Mar 25, 2026 at 06:28:41PM +0100, Marek Szyprowski wrote:
>> On 23.03.2026 21:20, Leon Romanovsky wrote:
>>> From: Leon Romanovsky <leonro@nvidia.com>
>>>
>>>
>>> The DMA API expects that callers use the same attributes when mapping
>>> and unmapping. Add tracking to verify this and catch mismatches.
>>>
>>>
>>> Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
>> Applied to dma-mapping-for-next, thanks!
> Thanks a lot.
It looks I've hurries a bit too much. This patch is not yet ready for -next:
1. attrs are not passed to debug_dma_unmap_{phys, sg}
2. attrs are not propagated to 'struct dma_debug_entry ref' in
debug_dma_free_{coherent, pages}
3. DMA_ATTR_NO_WARN and DMA_ATTR_ALLOC_SINGLE_PAGES should be probably
ignored, as are they don't make any sense to check in free calls
The above issues result in dozens of false-positive warnings, even in
drivers doing simple dma_alloc_wc(...) and then dma_free_wc(...).
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
next prev parent reply other threads:[~2026-03-25 20:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20260323202058eucas1p1946c1763123f2ceb493ebef25165f453@eucas1p1.samsung.com>
2026-03-23 20:20 ` Leon Romanovsky
2026-03-25 17:28 ` Marek Szyprowski
2026-03-25 17:56 ` Leon Romanovsky
2026-03-25 20:54 ` Marek Szyprowski [this message]
2026-03-26 10:36 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f09c9c3e-ae11-440d-b36e-b88fd4645648@samsung.com \
--to=m.szyprowski@samsung.com \
--cc=iommu@lists.linux.dev \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®